From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7925CDB479 for ; Thu, 25 Jun 2026 15:26:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gmN1h0cYlz2yft; Fri, 26 Jun 2026 01:26:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a11:7980:1::2:0" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1782401175; cv=none; b=iEtNLf9xJb/qXhtJuVV7aiFVZXQ69/eQPf1DpRbmlbymyXokK6NVhFP5wx/Vg/CannshqFcKOq6iPSEZ4GMwDO1gnVkZUF5tmpuNoe0FFF2CcRi5z812DlExTYK+LNjS6FW9RzLfxbh9HKrbabZX/YjQ41Pb5ocwjYhUlrFaX9ZGVIIikjzw9ANP+IjjKGw9Bqcx64EX2USwUl6b35TwuUF98EkoB+UQV1IlGdZlegsS3RUZbJD9EdndUmcqxZkN78WapGxcdjYDu5Udde2TxxWij/qecDgvWjEK/CJWyMQbIaohCJ/tL/DcnHVq1+8F4dkLzIsvJ0GOwGr+jMvcYg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1782401175; c=relaxed/relaxed; bh=EPEc1pvNNTn4Dvd2PhEVJBYnnhjseBlAaeLSgmHJr6Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kpx8LYFO5zlrC4Z3aeBhC9r4VMQjLF+3KH2fkNh60ZT3sVSj+of2UlYW+mV50zQA3d5EvS8vSMfkWoJs3io/hEm9Lq7Ll6OzHVPfPz3KOtCdio33z0CUrmgypFaALMlYCsO1UfGqII1lgB/uMMTEnyig08qHE4SOET2aVuX9E1hv6ql6SqwYwWP8Rarz0FQL+gBu+yer6297PWHf82VbVHiKNNl256PtZpuIoxTPw55wxDZHSjfk0qkB+8YwOKoDvaOXZNld4ly+1J8IaF6srC1Jk5RHrWdAbe6fhudsJHD9sTSyCKlI06wfukYuf5B93v6+zpTS0PvOomXABgGQiw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=grrlz.net; dkim=pass (1024-bit key; secure) header.d=grrlz.net header.i=@grrlz.net header.a=rsa-sha256 header.s=stigmate header.b=feYw0QtE; dkim-atps=neutral; spf=pass (client-ip=2a11:7980:1::2:0; helo=confino.investici.org; envelope-from=include@grrlz.net; receiver=lists.ozlabs.org) smtp.mailfrom=grrlz.net Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=grrlz.net Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=grrlz.net header.i=@grrlz.net header.a=rsa-sha256 header.s=stigmate header.b=feYw0QtE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=grrlz.net (client-ip=2a11:7980:1::2:0; helo=confino.investici.org; envelope-from=include@grrlz.net; receiver=lists.ozlabs.org) Received: from confino.investici.org (confino.investici.org [IPv6:2a11:7980:1::2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gmN1g28Pzz2yZc for ; Fri, 26 Jun 2026 01:26:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grrlz.net; s=stigmate; t=1782401172; bh=EPEc1pvNNTn4Dvd2PhEVJBYnnhjseBlAaeLSgmHJr6Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=feYw0QtEnBuwHcM8rR/iTMN8OLs8uoVHJopmOwbb0ppQrVnkC1rycr7CH7uSxYdZZ fn0qPfP2vlgzHxtVG4xBX2AxYGvSTIVtP8AzNy5MkBWQWrKYlHvXC+F6RCrZ9eqKNF GO7SH7rSFWaZ4Lhdj2p6/SHdIUlYAaWeJx6iKlrg= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4gmN1c5sDpz10tQ; Thu, 25 Jun 2026 15:26:12 +0000 (UTC) Received: by mx1.investici.org (Postfix) id 4gmN1c10GGz10jY; Thu, 25 Jun 2026 15:26:12 +0000 (UTC) From: Bradley Morgan To: Andrew Morton Cc: Petr Mladek , Feng Tang , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Madhavan Srinivasan , Douglas Anderson , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, Bradley Morgan Subject: [PATCH v3 2/4] watchdog: use sys_info_with_filter() to avoid duplicate backtraces Date: Thu, 25 Jun 2026 15:25:56 +0000 Message-ID: <20260625152558.7450-3-include@grrlz.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625152558.7450-1-include@grrlz.net> References: <20260625152558.7450-1-include@grrlz.net> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The watchdog prints all CPU backtraces itself. When the watchdog mask contains only SYS_INFO_ALL_BT, stripping that bit leaves zero and sys_info(0) falls back to kernel_sys_info. Use sys_info_with_filter() so an explicit all_bt mask does not request the global default. Fixes: a9af76a78760 ("watchdog: add sys_info sysctls to dump sys info on system lockup") Cc: stable@vger.kernel.org Signed-off-by: Bradley Morgan --- kernel/watchdog.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 87dd5e0f6968..ff284593cb90 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -208,6 +208,7 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs) { int hardlockup_all_cpu_backtrace; unsigned int this_cpu; + unsigned long si_mask; unsigned long flags; if (per_cpu(watchdog_hardlockup_touched, cpu)) { @@ -216,7 +217,8 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs) return; } - hardlockup_all_cpu_backtrace = (hardlockup_si_mask & SYS_INFO_ALL_BT) ? + si_mask = READ_ONCE(hardlockup_si_mask); + hardlockup_all_cpu_backtrace = (si_mask & SYS_INFO_ALL_BT) ? 1 : sysctl_hardlockup_all_cpu_backtrace; /* * Check for a hardlockup by making sure the CPU's timer @@ -286,7 +288,7 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs) clear_bit_unlock(0, &hard_lockup_nmi_warn); } - sys_info(hardlockup_si_mask & ~SYS_INFO_ALL_BT); + sys_info_with_filter(si_mask, SYS_INFO_ALL_BT); if (hardlockup_panic) nmi_panic(regs, "Hard LOCKUP"); @@ -798,6 +800,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer) struct pt_regs *regs = get_irq_regs(); int softlockup_all_cpu_backtrace; int duration, thresh_count; + unsigned long si_mask; unsigned long flags; if (!watchdog_enabled) @@ -809,7 +812,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer) if (panic_in_progress()) return HRTIMER_NORESTART; - softlockup_all_cpu_backtrace = (softlockup_si_mask & SYS_INFO_ALL_BT) ? + si_mask = READ_ONCE(softlockup_si_mask); + softlockup_all_cpu_backtrace = (si_mask & SYS_INFO_ALL_BT) ? 1 : sysctl_softlockup_all_cpu_backtrace; watchdog_hardlockup_kick(); @@ -900,7 +904,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer) } add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK); - sys_info(softlockup_si_mask & ~SYS_INFO_ALL_BT); + sys_info_with_filter(si_mask, SYS_INFO_ALL_BT); thresh_count = duration / get_softlockup_thresh(); if (softlockup_panic && thresh_count >= softlockup_panic) -- 2.53.0