From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B5C8C4451B for ; Fri, 17 Jul 2026 18:08:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4h1ybF5NxBz3c8l; Sat, 18 Jul 2026 04:08:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1784311737; cv=none; b=LRROc4Oe8xWN1i1PnEPEEgUoBMuwHLJPYsclyRy73gIkwhvJdF8HVDNjP/ujJgBJwGFyO+4nb2s+nhJdqffulK1RVO7RgrgyN2FFu0tez3NVS9JJxqL9Mj80/Yy2cyWTET0gfX5MJpo0Q0iN1cI2Q62Zj5yxAj/OMBlMAub5F1rUPBvc79/xYopZKbBixDP0QEIdtIZ7SymLYO5q+XxQGAOg/4ka3zP9OjepbuN2mBDnlHR3ulT41lYpwoRPs0f75yxpSsWy+FHMdaDiXhcAaSdayv4GUgguuyRtZb5CLCDq8+0151gjE6ltwlvBU/dlrAdHcO0s2dGX9Hr9ZwtsFg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1784311737; c=relaxed/relaxed; bh=EwNHrZwSusGthQDiVN8gv3gZ/NqcRGqEVZjtKRv5t3M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ISo5pzru2i5OJhn8Z15iVImpEEMQUDgtxqyiTnV1UkLK+ElKkK0L/1Sv+C7FqHZ5U92zqv/SxtV7STfupj2CFYuO7K7RJFgG/7eQZfZgLmOPPIaSEvVwu7S0vGvAylwCBW95XU+DUv5Hw+ypaYxWGyRZGu+ry9tfkvNad2qs/hiaVC1L/uEJ/xg0nVvMebL6Gp8Tgb6yLJaQo6p/N/BOzIF57KOODVRt/NOga1s7K2uphoxAjfB9yWOu4DpGBHSIhBnZHQd9cjuIE1RFEq+8FixSqodYhVW303b3kop5iqSs8ETheKHaW2NdbXFnP21oq41FO+iodU3O9AFmhd5NOA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=P+so4Cn9; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=aneesh.kumar@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=P+so4Cn9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=aneesh.kumar@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4h1ybD71bqz3c4l for ; Sat, 18 Jul 2026 04:08:56 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1BD60600DA; Fri, 17 Jul 2026 18:08:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB10D1F000E9; Fri, 17 Jul 2026 18:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784311734; bh=EwNHrZwSusGthQDiVN8gv3gZ/NqcRGqEVZjtKRv5t3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P+so4Cn9Bp/lktmtgwcfowHs6E4slI6aZAzD2tpNiBuY1Zm9/zccXXr2TLAjVxfUD q143dSuzlsOH/opFm3EBoMxg8xypyOsYyPtjXLRif5H2C70sQyZ9xZFA02T2W/K162 bIcOqD+oqZbRbtNXiQsShnjDhr7+GY9m2Sxw1FgcymZInV0hfCkqzznGb5TpFsdd2u 555J/pjq6j7dtU3oHQjF5mnuRzCwg/T1Lo1bl9egA+1w3ZP+C6Izeu9onXFXcfpMbR xxjyhcVwpdILCOnQqzb0d4clRjUm5i0m3TJr3PDmjB3mpGwYCZxyk3hmScCXTY1vyj vM8LlSDWutWsA== From: "Aneesh Kumar K.V (Arm)" To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev Cc: "Aneesh Kumar K.V (Arm)" , Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Jason Gunthorpe , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Jason Gunthorpe , Michael Kelley Subject: [PATCH v8 20/23] dma-direct: rename ret to cpu_addr in alloc helpers Date: Fri, 17 Jul 2026 23:34:38 +0530 Message-ID: <20260717180442.110954-21-aneesh.kumar@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717180442.110954-1-aneesh.kumar@kernel.org> References: <20260717180442.110954-1-aneesh.kumar@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ret in dma_direct_alloc() and dma_direct_alloc_pages() holds the returned CPU mapping, not a generic return value. Rename it to cpu_addr and update the remaining uses to match. This makes the allocation paths easier to follow and keeps the local naming consistent with what the variable actually represents. Reviewed-by: Jason Gunthorpe Tested-by: Michael Kelley Tested-by: Mostafa Saleh Reviewed-by: Petr Tesarik Signed-off-by: Aneesh Kumar K.V (Arm) --- kernel/dma/direct.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index eb0ce0787885..50a8335f3830 100644 --- a/kernel/dma/direct.c +++ b/kernel/dma/direct.c @@ -206,7 +206,7 @@ void *dma_direct_alloc(struct device *dev, size_t size, bool mark_mem_decrypt = false; bool allow_highmem = true; struct page *page; - void *ret; + void *cpu_addr; if (force_dma_unencrypted(dev)) attrs |= __DMA_ATTR_ALLOC_CC_SHARED; @@ -266,9 +266,10 @@ void *dma_direct_alloc(struct device *dev, size_t size, */ if ((remap || (attrs & __DMA_ATTR_ALLOC_CC_SHARED)) && dma_direct_use_pool(dev, gfp)) { - page = dma_direct_alloc_from_pool(dev, size, dma_handle, - &ret, gfp, attrs); - return page ? ret : NULL; + page = dma_direct_alloc_from_pool(dev, size, + dma_handle, &cpu_addr, + gfp, attrs); + return page ? cpu_addr : NULL; } if (is_swiotlb_for_alloc(dev)) { @@ -315,34 +316,33 @@ void *dma_direct_alloc(struct device *dev, size_t size, arch_dma_prep_coherent(page, size); /* create a coherent mapping */ - ret = dma_common_contiguous_remap(page, size, prot, - __builtin_return_address(0)); - if (!ret) + cpu_addr = dma_common_contiguous_remap(page, size, prot, + __builtin_return_address(0)); + if (!cpu_addr) goto out_encrypt_pages; } else { - ret = page_address(page); + cpu_addr = page_address(page); } - memset(ret, 0, size); + memset(cpu_addr, 0, size); if (set_uncached) { void *uncached_cpu_addr; arch_dma_prep_coherent(page, size); - uncached_cpu_addr = arch_dma_set_uncached(ret, size); + uncached_cpu_addr = arch_dma_set_uncached(cpu_addr, size); if (IS_ERR(uncached_cpu_addr)) goto out_free_remap_pages; - ret = uncached_cpu_addr; + cpu_addr = uncached_cpu_addr; } *dma_handle = phys_to_dma_direct(dev, page_to_phys(page), attrs & __DMA_ATTR_ALLOC_CC_SHARED); - return ret; - + return cpu_addr; out_free_remap_pages: if (remap) - dma_common_free_remap(ret, size); + dma_common_free_remap(cpu_addr, size); out_encrypt_pages: if (mark_mem_decrypt && @@ -434,21 +434,21 @@ struct page *dma_direct_alloc_pages(struct device *dev, size_t size, { unsigned long attrs = 0; struct page *page; - void *ret; + void *cpu_addr; if (force_dma_unencrypted(dev)) attrs |= __DMA_ATTR_ALLOC_CC_SHARED; if ((attrs & __DMA_ATTR_ALLOC_CC_SHARED) && dma_direct_use_pool(dev, gfp)) return dma_direct_alloc_from_pool(dev, size, dma_handle, - &ret, gfp, attrs); + &cpu_addr, gfp, attrs); if (is_swiotlb_for_alloc(dev)) { page = dma_direct_alloc_swiotlb(dev, size, attrs); if (!page) return NULL; - ret = page_address(page); + cpu_addr = page_address(page); goto setup_page; } @@ -456,12 +456,12 @@ struct page *dma_direct_alloc_pages(struct device *dev, size_t size, if (!page) return NULL; - ret = page_address(page); + cpu_addr = page_address(page); if ((attrs & __DMA_ATTR_ALLOC_CC_SHARED) && - dma_set_decrypted(dev, ret, size)) + dma_set_decrypted(dev, cpu_addr, size)) goto out_leak_pages; setup_page: - memset(ret, 0, size); + memset(cpu_addr, 0, size); *dma_handle = phys_to_dma_direct(dev, page_to_phys(page), attrs & __DMA_ATTR_ALLOC_CC_SHARED); return page; -- 2.43.0