From: "Dmitry V. Levin" <ldv@strace.io>
To: Mukesh Kumar Chaurasiya <mkchauras@linux.ibm.com>
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
chleroy@kernel.org, ryabinin.a.a@gmail.com, glider@google.com,
andreyknvl@gmail.com, dvyukov@google.com,
vincenzo.frascino@arm.com, oleg@redhat.com, kees@kernel.org,
luto@amacapital.net, wad@chromium.org, mchauras@linux.ibm.com,
thuth@redhat.com, ruanjinjie@huawei.com, sshegde@linux.ibm.com,
akpm@linux-foundation.org, charlie@rivosinc.com, deller@gmx.de,
macro@orcam.me.uk, segher@kernel.crashing.org,
peterz@infradead.org, bigeasy@linutronix.de,
namcao@linutronix.de, tglx@linutronix.de, mark.barnett@arm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com
Subject: Re: [PATCH v4 5/8] powerpc: add exit_flags field in pt_regs
Date: Wed, 22 Jul 2026 10:01:55 +0300 [thread overview]
Message-ID: <20260722070155.GA11808@strace.io> (raw)
In-Reply-To: <20260123073916.956498-6-mkchauras@linux.ibm.com>
On Fri, Jan 23, 2026 at 01:09:13PM +0530, Mukesh Kumar Chaurasiya wrote:
> From: Mukesh Kumar Chaurasiya <mchauras@linux.ibm.com>
>
> Add a new field `exit_flags` in the pt_regs structure. This field will hold
> the flags set during interrupt or syscall execution that are required during
> exit to user mode.
Apparently, this change breaks PTRACE_GETREGS as the latter has no means
to communicate the size of struct pt_regs being written to userspace.
As result, the kernel with this patch will write to userpsace 32 more
bytes than before, and unless the userspace is re-compiled with the latest
ptrace.h, 32 bytes of userspace memory after struct pt_regs will be
overwritten.
This issue was detected by strace test suite, specifically, the test that
checks whether the actual number of bytes written by
ptrace(PTRACE_GETREGS) matches sizeof(struct pt_regs), and that test failed
with runtime version v7.1 and headers version v7.2-rc1.
> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h b/arch/powerpc/include/uapi/asm/ptrace.h
> index 01e630149d48..a393b7f2760a 100644
> --- a/arch/powerpc/include/uapi/asm/ptrace.h
> +++ b/arch/powerpc/include/uapi/asm/ptrace.h
> @@ -55,6 +55,8 @@ struct pt_regs
> unsigned long dar; /* Fault registers */
> unsigned long dsisr; /* on 4xx/Book-E used for ESR */
> unsigned long result; /* Result of a system call */
> + unsigned long exit_flags; /* System call exit flags */
> + unsigned long __pt_regs_pad[3]; /* Maintain 16 byte interrupt stack alignment */
> };
>
> #endif /* __ASSEMBLER__ */
--
ldv
next prev parent reply other threads:[~2026-07-22 7:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 7:39 [PATCH v4 0/8] Generic IRQ entry/exit support for powerpc Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 1/8] powerpc: rename arch_irq_disabled_regs Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 2/8] powerpc: Prepare to build with generic entry/exit framework Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 3/8] powerpc: introduce arch_enter_from_user_mode Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 4/8] powerpc: Introduce syscall exit arch functions Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 5/8] powerpc: add exit_flags field in pt_regs Mukesh Kumar Chaurasiya
2026-07-22 7:01 ` Dmitry V. Levin [this message]
2026-07-22 7:54 ` Florian Weimer
2026-07-22 10:30 ` Mukesh Kumar Chaurasiya
2026-07-23 2:37 ` Madhavan Srinivasan
2026-01-23 7:39 ` [PATCH v4 6/8] powerpc: Prepare for IRQ entry exit Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 7/8] powerpc: Enable GENERIC_ENTRY feature Mukesh Kumar Chaurasiya
2026-01-23 7:39 ` [PATCH v4 8/8] powerpc: Remove unused functions Mukesh Kumar Chaurasiya
2026-01-23 17:54 ` [PATCH v4 0/8] Generic IRQ entry/exit support for powerpc Shrikanth Hegde
2026-01-30 7:24 ` Venkat
2026-01-30 8:41 ` David Gow
2026-01-30 18:14 ` Samir M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722070155.GA11808@strace.io \
--to=ldv@strace.io \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=charlie@rivosinc.com \
--cc=chleroy@kernel.org \
--cc=deller@gmx.de \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@amacapital.net \
--cc=macro@orcam.me.uk \
--cc=maddy@linux.ibm.com \
--cc=mark.barnett@arm.com \
--cc=mchauras@linux.ibm.com \
--cc=mkchauras@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=namcao@linutronix.de \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=ruanjinjie@huawei.com \
--cc=ryabinin.a.a@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=sshegde@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=vincenzo.frascino@arm.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox