From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Yury Murashka <yurypm@arista.com>,
Matthew W Carlis <mattc@purestorage.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
Qingshun Wang <qingshun.wang@linux.intel.com>,
Yicong Yang <yang.yicong@picoheart.com>,
dio.sun@enflame-tech.com, linux-pci@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver OHalloran <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Terry Bowman <terry.bowman@amd.com>,
". Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Arjun Govindjee <agovindjee@purestorage.com>,
Ashish Karkare <ashishk@purestorage.com>,
Jasjeet Rangi <jrangi@purestorage.com>,
Meeta Saggi <msaggi@purestorage.com>,
rhan@purestorage.com, sconnor@purestorage.com,
an.luo@enflame-tech.com, fernando.hu@enflame-tech.com,
bill.wu@enflame-tech.com, xin.wang@enflame-tech.com
Subject: Re: [PATCH 0/6] PCI/AER: Support Advisory Non-Fatal Errors
Date: Fri, 24 Jul 2026 17:39:03 -0500 [thread overview]
Message-ID: <20260724223903.GA1073029@bhelgaas> (raw)
In-Reply-To: <cover.1784905909.git.lukas@wunner.de>
On Fri, Jul 24, 2026 at 05:24:00PM +0200, Lukas Wunner wrote:
> PCIe r7.0 sec 6.2.4.3 specifies that certain Non-Fatal Errors may be
> signaled with ERR_COR instead of ERR_NONFATAL. These so-called Advisory
> Non-Fatal Errors are masked by default and hence not reported by Linux.
>
> This series seeks to change that. The meat of it is in patch [6/6].
> There have been several previous attempts to support Advisory Non-Fatal
> Errors which are all linked in the patch.
>
> The preceding patches contain prep work. In particular, they ensure that
> the detecting agent and layer is reported correctly for each error (patch
> [1/6] and [2/6]), simplify logging of the error source (patch [3/6]),
> fix reporting of the TLP Prefix/Header Log (patch [4/6]) and move code
> around (patch [5/6]).
>
> The patches have been tested internally, but further testing would be
> appreciated to raise the confidence. Thanks!
>
> Lukas Wunner (6):
> PCI/AER: Fix mapping of errors to agent & layer
> PCI/AER: Log agent & layer for each individual error
> PCI/AER: Deduplicate logging of Error Source Identification
> PCI/AER: Emit TLP Log only for unmasked errors
> PCI/AER: Move retrieval of FEP and TLP Log into helper
> PCI/AER: Support Advisory Non-Fatal Errors
>
> drivers/pci/pci.h | 4 +
> drivers/pci/pcie/aer.c | 250 ++++++++++++++++++++++++++++++++---------
> 2 files changed, 200 insertions(+), 54 deletions(-)
Applied to pci/aer with the intention of v7.3, thank you!
I noticed a sashiko comment on 6/6 but haven't had time to look at it
yet. I left the series on pci/aer for build testing in the meantime.
prev parent reply other threads:[~2026-07-24 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 15:24 [PATCH 0/6] PCI/AER: Support Advisory Non-Fatal Errors Lukas Wunner
2026-07-24 15:24 ` [PATCH 1/6] PCI/AER: Fix mapping of errors to agent & layer Lukas Wunner
2026-07-24 15:24 ` [PATCH 2/6] PCI/AER: Log agent & layer for each individual error Lukas Wunner
2026-07-24 15:24 ` [PATCH 3/6] PCI/AER: Deduplicate logging of Error Source Identification Lukas Wunner
2026-07-24 15:24 ` [PATCH 4/6] PCI/AER: Emit TLP Log only for unmasked errors Lukas Wunner
2026-07-24 15:24 ` [PATCH 5/6] PCI/AER: Move retrieval of FEP and TLP Log into helper Lukas Wunner
2026-07-24 15:24 ` [PATCH 6/6] PCI/AER: Support Advisory Non-Fatal Errors Lukas Wunner
2026-07-24 22:39 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724223903.GA1073029@bhelgaas \
--to=helgaas@kernel.org \
--cc=agovindjee@purestorage.com \
--cc=an.luo@enflame-tech.com \
--cc=ashishk@purestorage.com \
--cc=bill.wu@enflame-tech.com \
--cc=dio.sun@enflame-tech.com \
--cc=fernando.hu@enflame-tech.com \
--cc=jrangi@purestorage.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=mattc@purestorage.com \
--cc=msaggi@purestorage.com \
--cc=oohall@gmail.com \
--cc=qingshun.wang@linux.intel.com \
--cc=rhan@purestorage.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sconnor@purestorage.com \
--cc=terry.bowman@amd.com \
--cc=xin.wang@enflame-tech.com \
--cc=yang.yicong@picoheart.com \
--cc=yurypm@arista.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox