From: Gou Hao <gouhao@uniontech.com>
To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
chleroy@kernel.org, namcao@linutronix.de, peterz@infradead.org,
sshegde@linux.ibm.com, kees@kernel.org,
lgs201920130244@gmail.com, srikar@linux.ibm.com,
ynorov@nvidia.com, nilay@linux.ibm.com, clg@kaod.org,
benh@kernel.crashing.org, miltonm@bga.com, mkchauras@gmail.com,
akpm@linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
gouhaojake@163.com, kernel@uniontech.com
Subject: [PATCH v3 0/5] powerpc/xive: remove __GFP_NOFAIL and fix IPI error handling
Date: Mon, 27 Jul 2026 18:42:10 +0800 [thread overview]
Message-ID: <20260727104215.184786-1-gouhao@uniontech.com> (raw)
Changes in v3:
- Split into a separate xive-only series; the drm, test_hmm
and cxgb4 patches are unchanged since v1 and will no longer be updated here.
- Rework the first patch: instead of simply removing the unreachable
NULL check, remove __GFP_NOFAIL from the IPI allocation and make
all xive_ipis access paths NULL-safe (suggested by Andrew Morton [1]
and Cédric Le Goater).
- Add a patch to defer setting cause_ipi until IPI init succeeds,
so that smp_muxed_ipi_message_pass() does not call into a
half-initialized IPI path.
- Add a defensive NULL guard for cause_ipi in
smp_muxed_ipi_message_pass() as a safety net.
[1] https://lore.kernel.org/all/20260725202632.dcb325658896a470df91cf57@linux-foundation.org/
Changes in v2:
- Remove the now-unused out_free_domain error label in the xive
patch after deleting the unreachable NULL check goto.
- Fix a use-after-free of xive_ipis: when xive_init_ipis() fails,
the error path frees xive_ipis but xive_smp_probe() ignores the
error and proceeds to dereference it in xive_setup_cpu_ipi().
Propagate the error return through xive_smp_probe() and check
it in both pnv_smp_probe() and pSeries_smp_probe().
This is a code cleanup series that removes unreachable
NULL checks (and associated error handling) that follow allocations
using __GFP_NOFAIL, which guarantees non-NULL return.
v2: https://lore.kernel.org/all/20260724022851.466017-1-gouhao@uniontech.com/
v1: https://lore.kernel.org/all/20260723081813.176792-1-gouhao@uniontech.com/
Gou Hao (5):
powerpc/xive: make xive IPI allocation NULL-safe
powerpc/xive: add error return value to xive_smp_probe()
powerpc/xive: propagate IPI init errors to prevent use-after-free
powerpc/xive: defer setting cause_ipi until IPI init succeeds
powerpc/smp: add NULL guard for cause_ipi in
smp_muxed_ipi_message_pass
arch/powerpc/include/asm/xive.h | 4 ++--
arch/powerpc/kernel/smp.c | 3 +++
arch/powerpc/platforms/powernv/smp.c | 8 +++++---
arch/powerpc/platforms/pseries/smp.c | 8 +++++---
arch/powerpc/sysdev/xive/common.c | 28 ++++++++++++++++----------
5 files changed, 37 insertions(+), 14 deletions(-)
--
2.20.1
next reply other threads:[~2026-07-27 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 10:42 Gou Hao [this message]
2026-07-27 10:42 ` [PATCH v3 1/5] powerpc/xive: make xive IPI allocation NULL-safe Gou Hao
2026-07-27 10:42 ` [PATCH v3 2/5] powerpc/xive: add error return value to xive_smp_probe() Gou Hao
2026-07-27 10:42 ` [PATCH v3 3/5] powerpc/xive: propagate IPI init errors to prevent use-after-free Gou Hao
2026-07-28 2:47 ` Srikar Dronamraju
2026-07-28 10:26 ` Gou Hao
2026-07-27 10:42 ` [PATCH v3 4/5] powerpc/xive: defer setting cause_ipi until IPI init succeeds Gou Hao
2026-07-27 10:42 ` [PATCH v3 5/5] powerpc/smp: add NULL guard for cause_ipi in smp_muxed_ipi_message_pass Gou Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727104215.184786-1-gouhao@uniontech.com \
--to=gouhao@uniontech.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chleroy@kernel.org \
--cc=clg@kaod.org \
--cc=gouhaojake@163.com \
--cc=kees@kernel.org \
--cc=kernel@uniontech.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=miltonm@bga.com \
--cc=mkchauras@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=namcao@linutronix.de \
--cc=nilay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox