LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Babanpreet Singh <bbnpreetsingh@gmail.com>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <chleroy@kernel.org>,
	linuxppc-dev@lists.ozlabs.org, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Babanpreet Singh <bbnpreetsingh@gmail.com>
Subject: [PATCH 0/2] watchdog: Fix two kernel-doc parameter warnings
Date: Thu, 30 Jul 2026 06:06:15 +0000	[thread overview]
Message-ID: <20260730060617.7-1-bbnpreetsingh@gmail.com> (raw)

Two independent kernel-doc parameter fixes in drivers/watchdog, found by
scripts/kernel-doc -none. Both warnings are in .c files, so they appear in
a W=1 build, and both files are clean afterwards.

Patch 1 fixes a name mismatch: wdrtas_reboot() names its notifier block
argument 'this' while the doc block says '@nb'. Patch 2 adds the missing
description for the argument __booke_wdt_disable() receives from
on_each_cpu() and ignores.

They touch different drivers and are not a logical unit, so they are split
rather than squashed; either can be dropped without affecting the other.

One thing I would rather state than have assumed: both drivers are
PowerPC-only and I have no PowerPC toolchain here, so neither file was
compiled. The whole series is three lines and every one of them is inside
a /** */ block, so there is no code change to compile. Checked with
scripts/kernel-doc -none (3 warnings across these two files before, 0
after) and checkpatch --strict.

Babanpreet Singh (2):
  watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot()
  watchdog: booke_wdt: Document unused parameter of
    __booke_wdt_disable()

 drivers/watchdog/booke_wdt.c | 1 +
 drivers/watchdog/wdrtas.c    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.43.0



             reply	other threads:[~2026-07-30 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  6:06 Babanpreet Singh [this message]
2026-07-30  6:06 ` [PATCH 1/2] watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot() Babanpreet Singh
2026-07-30  6:06 ` [PATCH 2/2] watchdog: booke_wdt: Document unused parameter of __booke_wdt_disable() Babanpreet Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730060617.7-1-bbnpreetsingh@gmail.com \
    --to=bbnpreetsingh@gmail.com \
    --cc=chleroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox