LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tarun Sahu <tarunsahu@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Geoff Levand <geoff@infradead.org>,
	 "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	 Michael Ellerman <mpe@ellerman.id.au>,
	dmatlack@google.com, Borislav Petkov <bp@alien8.de>,
	 Madhavan Srinivasan <maddy@linux.ibm.com>,
	Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	djeffery@redhat.com,  Tony Luck <tony.luck@intel.com>,
	skhawaja@google.com,  Russell King <linux@armlinux.org.uk>,
	stuart.w.hayes@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	 linux-edac@vger.kernel.org, Tarun Sahu <tarunsahu@google.com>
Subject: [PATCH 1/4] ARM: locomo: use put_device() on device_register() failure
Date: Mon, 10 Aug 2026 16:28:11 +0000	[thread overview]
Message-ID: <20260810162814.1398016-2-tarunsahu@google.com> (raw)
In-Reply-To: <20260810162814.1398016-1-tarunsahu@google.com>

When device_register() fails, calling kfree(dev) directly bypasses the
device_release() callback (locomo_dev_release) and leaks internal driver
core structures allocated during device initialization.

Fix this by replacing direct kfree(dev) with put_device(&dev->dev) when
device_register() returns an error, ensuring proper refcount decrement
and cleanup via locomo_dev_release().

Signed-off-by: Tarun Sahu <tarunsahu@google.com>
---
 arch/arm/common/locomo.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c
index 55e360452828..0f6689d343b0 100644
--- a/arch/arm/common/locomo.c
+++ b/arch/arm/common/locomo.c
@@ -223,10 +223,8 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info)
 	int ret;
 
 	dev = kzalloc_obj(struct locomo_dev);
-	if (!dev) {
-		ret = -ENOMEM;
-		goto out;
-	}
+	if (!dev)
+		return -ENOMEM;
 
 	/*
 	 * If the parent device has a DMA mask associated with it,
@@ -255,10 +253,11 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info)
 
 	ret = device_register(&dev->dev);
 	if (ret) {
- out:
-		kfree(dev);
+		put_device(&dev->dev);
+		return ret;
 	}
-	return ret;
+
+	return 0;
 }
 
 #ifdef CONFIG_PM
-- 
2.55.0.679.g6767b8d81c-goog



  reply	other threads:[~2026-08-10 22:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 16:28 [PATCH 0/4] Convert manual kfree(dev) to put_device() Tarun Sahu
2026-08-10 16:28 ` Tarun Sahu [this message]
2026-08-10 16:28 ` [PATCH 2/4] firmware/edd: use kobject_put() on edd_device_register() failure Tarun Sahu
2026-08-10 16:28 ` [PATCH 3/4] EDAC/versalnet: use put_device() on device_register() failure Tarun Sahu
2026-08-11  6:44   ` Pandey, Radhey Shyam
2026-08-11 10:39     ` tarunsahu
2026-08-10 16:28 ` [PATCH 4/4] powerpc/ps3: use put_device() on device_register() failure in ps3_system_bus_device_register Tarun Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810162814.1398016-2-tarunsahu@google.com \
    --to=tarunsahu@google.com \
    --cc=bp@alien8.de \
    --cc=chleroy@kernel.org \
    --cc=djeffery@redhat.com \
    --cc=dmatlack@google.com \
    --cc=driver-core@lists.linux.dev \
    --cc=geoff@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=skhawaja@google.com \
    --cc=stuart.w.hayes@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox