From: Chris Chiu <chris.chiu@canonical.com>
To: maddy@linux.ibm.com, shuah@kernel.org
Cc: sshegde@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Chiu <chris.chiu@canonical.com>
Subject: [PATCH] selftests/powerpc: Fix exec_prot test failure on Hash MMU
Date: Wed, 9 Sep 2026 13:09:19 +0800 [thread overview]
Message-ID: <20260909050919.3344699-1-chris.chiu@canonical.com> (raw)
Hash MMU maps execute-only pages as readable at the PTE level, so reading
from a PROT_EXEC-only mapping does not fault there. The exec_prot test
currently treats that as a failure, while the rest of the permission
checks are still valid.
Use the existing using_hash_mmu() helper and skip only the read-on-
execute-only subtest on Hash MMU. Keep the rest of the test unchanged so
the fix stays local to the unsupported execute-only-read expectation.
Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
---
.../testing/selftests/powerpc/mm/exec_prot.c | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/powerpc/mm/exec_prot.c b/tools/testing/selftests/powerpc/mm/exec_prot.c
index db75b2225de1..bd44f49d8449 100644
--- a/tools/testing/selftests/powerpc/mm/exec_prot.c
+++ b/tools/testing/selftests/powerpc/mm/exec_prot.c
@@ -108,11 +108,14 @@ static int check_exec_fault(int rights)
static int test(void)
{
struct sigaction segv_act, trap_act;
+ bool hash_mmu;
int i;
/* Skip the test if the CPU doesn't support Radix */
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_00));
+ FAIL_IF(using_hash_mmu(&hash_mmu));
+
/* Check if pkeys are supported */
pkeys_supported = pkeys_unsupported() == 0;
@@ -167,13 +170,17 @@ static int test(void)
* Read an instruction word from the address when the page
* is execute only. This should generate an access fault.
*/
- fault_code = -1;
- remaining_faults = 1;
- printf("Testing read on --x, should fault...");
- FAIL_IF(mprotect(insns, pgsize, PROT_EXEC) != 0);
- i = *fault_addr;
- FAIL_IF(remaining_faults != 0 || !is_fault_expected(fault_code));
- printf("ok!\n");
+ if (!hash_mmu) {
+ fault_code = -1;
+ remaining_faults = 1;
+ printf("Testing read on --x, should fault...");
+ FAIL_IF(mprotect(insns, pgsize, PROT_EXEC) != 0);
+ i = *fault_addr;
+ FAIL_IF(remaining_faults != 0 || !is_fault_expected(fault_code));
+ printf("ok!\n");
+ } else {
+ printf("Testing read on --x, skipped on Hash MMU\n");
+ }
/*
* Write an instruction word to the address when the page
--
2.43.0
reply other threads:[~2026-09-09 12:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909050919.3344699-1-chris.chiu@canonical.com \
--to=chris.chiu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox