From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C549C982C1 for ; Wed, 16 Sep 2026 23:11:28 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hlZNF6tZ5z3cBb; Thu, 17 Sep 2026 09:09:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1789600189; cv=none; b=T9YJ9f69cTBD0+hmTslw8Zb/U5LfWUsHe4rR8m/1ULk3Inx592wm16mCAZMtjeT/myQhi6pc+SA/SCbULYqqVZG/ks6lCTrcNoOrqq/3dzKw3uUtD/xo1CJhBcj7wSG9FksaOFjsJiySL3WkCMyxqnHD+LzYDBP2ZSOs0YeezIsOsE3/xk2xc1MYLfPKN8HYE7AUghFF79XPzN1EVjMVnh5sYnbTxxL/T13k8DkiR76R/kiBKFyf8O+CI7MWuubO7BZ4a8YOLe6qeHk+d9KE/0G4aEku0oWmRdAy5VXN4Wa7E30yARl9DthQsaRqjb1pd92k99DeUzq4IfnPZtjrxg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1789600189; c=relaxed/relaxed; bh=/rkG2+RTcsFvr4mbe2ojqN4MphfaV5sN28KLxxZ4wlc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j0of20ruRV1wQfCdcicyA2w9CNavUbSzNFsHjrLF/VmQsqOpIzbZ5MRMQ5VFHG/uSTwrMa+jEDUt6jj6f3VoRXIhofMsuHaZHxzyEdm/rmzuSPKejdz0h8HTzdfNmaUG8ppo7zZ8yGirU21Jz763mNZKD3ngOhRHCPeNGQ8HlFnbM64NwjPNl2hG6I7fvQDHDK/64uMUD4EH/a//pkvNXEb4rv18I6tNV1SfPUcQVHJknGdEkR3yJsKpAEpWfWqDoQNYqni8U5FSMuxQXQq7btnB0mcRFQ8biWSnqsDHnZ9P2vNYIZ4xXpAJ70qfTaNQnUBIwrYS5YFJW6Fo6ryGGg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cGZAQmcT; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=tyreld@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cGZAQmcT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=tyreld@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hlZNF0xjdz3bm3 for ; Thu, 17 Sep 2026 09:09:48 +1000 (AEST) Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68GG1oqT2330705; Wed, 16 Sep 2026 23:09:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=/rkG2+ RTcsFvr4mbe2ojqN4MphfaV5sN28KLxxZ4wlc=; b=cGZAQmcTfgrM5HoxdNt2Di uejxLwBGGmes5RHOhLMQt3Bspvaqx3bghUypLuJ0IZ0d+dEqulIKZ438GZfOmx9G 7Sru1NUenoU69SrEFQXr/oQcJNPEkhXZ/vErxn8qPNJyTO7KALWtvVhpA0P0lnIs g73kO4z+21jhfWzsq0hwYO6jpGZ+u2Swy8vATbW71hijcrhd43p430Eeyj41tjw3 z2TgS5enXS05+YISuPKIsFUZ1LA8SLz1eT/SQ4QEoTToDcNxpbfwOy2k7kqYjz3k ifCGWuyDFGqwyx3BpDu+434tDYgR1SxJh67S7IR50XhBhTHNo6tEX8P5qDvK1F/Q == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gmxdqfda7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 23:09:46 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68GMrtMN2599742; Wed, 16 Sep 2026 23:09:45 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gpw6d9e9a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 23:09:45 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68GN91H022872730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Sep 2026 23:09:01 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CAB55804E; Wed, 16 Sep 2026 23:09:44 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B1F658060; Wed, 16 Sep 2026 23:09:43 +0000 (GMT) Received: from li-4c4c4544-0054-3910-8039-c3c04f423534.ibm.com.com (unknown [9.61.141.190]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 16 Sep 2026 23:09:42 +0000 (GMT) From: Tyrel Datwyler To: james.bottomley@hansenpartnership.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, brking@linux.ibm.com, davemarq@linux.ibm.com, Tyrel Datwyler Subject: [PATCH 15/20] scsi: ibmvfc: unregister NVMe local port on adapter removal Date: Wed, 16 Sep 2026 16:09:16 -0700 Message-ID: <20260916230921.2204729-16-tyreld@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260916230921.2204729-1-tyreld@linux.ibm.com> References: <20260916230921.2204729-1-tyreld@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDMyMiBTYWx0ZWRfXwW9pXpANmQA5 Sj++64eOXiaztnHyolCBtwpNKDSMASpH2zsZuhLGPDr82zVQdD571TJD4kovamOGjBDcGptyVGj SSgGJCJYlSoYq8K1dXsmrQ8lNKNsRXU7lz1jMvyIG6QDZojI0D6nYDg6KHtcSiJ+1tL8AjzRHmW 4OQ7mwWiHV6WnIGQbKDIML50JPpXKXckI0fRqDgAmuR5vt0qoCA22v0PtOEO/EshQ00/LgqjB+g G3Cl+LD9+QKRGt44VrSRtEkI8qeE9UeD7felT57JoimqtQ779NGvr2FgQa6lAEItIJ2KmxE79Cj qAa6WtpOFlq0QF01mmKcYh9ModmJHYPTkusOXl9zHqyzdkAl0N/9NoQ5bf0U6khPijVqI066V4t 0xh2V8UBDVzSRAlnhARhZKgFxKJV15XSK7t1Tj2aFp29qty47zZczpo0cQoSf+pIddQuaLIj19j PDW+DMQGsFU+FD+MkTQ== X-Proofpoint-GUID: LszIPjmvfXcB7eQhFi6jmif6JIC0g1Ai X-Authority-Analysis: v=2.4 cv=DobDa2/+ c=1 sm=1 tr=0 ts=6aab21ba cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=FP1yMjY_cEXO16Dv5WoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: LszIPjmvfXcB7eQhFi6jmif6JIC0g1Ai X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDMyMiBTYWx0ZWRfX7gOK1x4wWQk3 N9bevllTcC0b09UXTbqhQeN61OjX2dECBWdec0UqQ5VtqK2sFcp2uwwFG17xbFvfQ/joGOsdzhY a3i+c+wO6Fx+ETl8LRVUhMTOZVGMs98= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-16_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160322 ibmvfc_remove() tears down the CRQ and frees all host memory but never calls ibmvfc_nvme_unregister(). The NVMe-FC transport therefore retains a live reference to the local port whose private pointer points into the now-freed ibmvfc_host, leading to a use-after-free whenever the transport subsequently touches the port (queue creation, port scanning, etc.). ibmvfc_nvme_unregister() is already called from the NPIV logout and host reset paths during normal operation; driver removal simply missed it. Add the call after ibmvfc_release_crq_queue() — at which point the CRQ is torn down so no further completions can arrive — and before ibmvfc_free_mem(), so host memory is still valid while nvme_fc_unregister_localport() runs and waits for the localport_delete callback to complete. Fixes: 86e495358096 ("scsi: ibmvfc: implement LLDD callbacks for mapping nvme-fc queues") Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c index 190410847efb..7af1867b69c5 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c @@ -6995,6 +6995,8 @@ static void ibmvfc_remove(struct vio_dev *vdev) ibmvfc_release_sub_crqs(vhost); ibmvfc_release_crq_queue(vhost); + ibmvfc_nvme_unregister(vhost); + ibmvfc_free_mem(vhost); spin_lock(&ibmvfc_driver_lock); list_del(&vhost->queue); -- 2.55.0