From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06CD2C9830B for ; Wed, 23 Sep 2026 19:53:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hqnhk08z7z2yqw; Thu, 24 Sep 2026 05:53:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1790193221; cv=none; b=kCtPpD/7yvHe5wLwAy/XGqxGzmrdQeKEpuUtHl5HA9NAH+u7y/NBJqJwVQdjLQ+xWTMmqknpEf/R+9lyikqcv47pTAw+sSSxi5KK9nwPk4865UZOZ5n/+o6BDg2s4EVq2Ax9CcNiB4iTX4OBZO9I3mA11SRTq5g7HeuiG6PgWmSP14783yQeDlCIi//582v6kjA3WftYT24WEwHPveZjRTKXIdRqqPYyJOXYpJZZZToruy5KyTDCUJXpcx85HM4m2d6fEgYbEybiVo+3UafdHMBMUF+jA2sLX11L03DD+MwQEOlpHP4oKxRQkKs9vv6xd2DSprDx1+V+doz+P3HHww== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1790193221; c=relaxed/relaxed; bh=p4edf0YYCmWA79RL5zC8Xmz8p09vaatBemczrDrD/n0=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Une/7Cr/AX1ujCEWWftE8dco68f0Hto6++o6Iou23kdaFUQftwjSmGbzZT39qVT7UIqUoJdQ2Td982vY5nkevONqoU/TIcCXy6gt19fRHhPQUSJ/0guQjMbt3yReXXOvf89T6HlZEar8eK3tWkSIhcdHDU4o8de5hV1f0P2weeQvspgEBRheWsJ2SnCU294KFSd2k9//Vt4MF21ISMiChmE/lPKNgLeR+FHFU1o5DFBYJmoRb+O/3eIhGWpeSc9jOt4QqEHRkmLEARaPTyTUd/ErFJIbs4vB4WGFUt91ZJ2wfzNcZQHK0SJgH+es+dyIZrslwddQWTSqUNottuYGcQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=eE9WCS2o; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) smtp.mailfrom=linux-foundation.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=eE9WCS2o; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hqnhg4fV6z2xlw for ; Thu, 24 Sep 2026 05:53:38 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A726741A56; Wed, 23 Sep 2026 19:53:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF0D01F000FF; Wed, 23 Sep 2026 19:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1790193214; bh=p4edf0YYCmWA79RL5zC8Xmz8p09vaatBemczrDrD/n0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eE9WCS2ousaSTQemTQ4AA1ZkY9n6f+r4xISLZALK3AMHEPFEmixpwYev88YxZLXeN CHmB0H3Bw3SM8Ql9Z+14bUyIFrP0hgQ5aVwbxlPcF2pYaWAyJOWebDVlGCFrkFZrGM ck3P7oheu0DSTRvd14VSbm/sP0AV2Mko/VrdoIFk= Date: Wed, 23 Sep 2026 12:53:31 -0700 From: Andrew Morton To: "Lorenzo Stoakes (ARM)" Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Guo Ren , Brian Cain , Geert Uytterhoeven , Dinh Nguyen , Simon Schuster , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Rich Felker , John Paul Adrian Glaubitz , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Russell King , Vineet Gupta , Michal Simek , Chris Zankel , Max Filippov , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , "David S. Miller" , Andreas Larsson , Richard Henderson , Matt Turner , Magnus Lindholm , Catalin Marinas , Mark Rutland , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Yoshinori Sato , Shakeel Butt , Jonathan Corbet , Randy Dunlap , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-arch@vger.kernel.org, sparclinux@vger.kernel.org, linux-alpha@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, Hugh Dickins , Qi Zheng , linux-doc@vger.kernel.org Subject: Re: [PATCH v4 01/12] mm/khugepaged: deposit a newly allocated page table on collapse Message-Id: <20260923125331.882dfeb1f43d284b146a4633@linux-foundation.org> In-Reply-To: References: <20260922-rcu-pagetable-freeing-v4-0-fe1ad1f1e303@kernel.org> <20260922-rcu-pagetable-freeing-v4-1-fe1ad1f1e303@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 23 Sep 2026 08:14:01 +0100 "Lorenzo Stoakes (ARM)" wrote: > Andrew - would it be possible to make one quick fix up below? > > Fixup is here: > > - if (!pgtable) > - goto out_nolock; > + if (!pgtable) { > + result = SCAN_ALLOC_HUGE_PAGE_FAIL; > + goto out_nolock; > + } --- a/mm/khugepaged.c~mm-khugepaged-deposit-a-newly-allocated-page-table-on-collapse-fix +++ a/mm/khugepaged.c @@ -1329,8 +1329,10 @@ static enum scan_result collapse_huge_pa if (is_pmd_order(order)) { pgtable = alloc_deposit_pte(mm); - if (!pgtable) + if (!pgtable) { + result = SCAN_ALLOC_HUGE_PAGE_FAIL; goto out_nolock; + } } mmap_read_lock(mm); _