From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F34606A31A for ; Mon, 26 Oct 2026 08:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SGCGZ/n/ Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jCmNz2C9dz2yLF; Mon, 26 Oct 2026 19:04:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2001:41d0:1004:224b::a1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793001859; cv=none; b=E/TwFLWB343Ge6uEis/EzlOgGiLvCZah2CzzUjQufadtOJQ7YqFb7+Ofd8oFk4aUJfJv8EIuJOHr/XPEJnt9ecBroamJvbDr9jdSpmxKFo9Gg/JgnyUWnykH6OpYPV/+AyjSozJfo3yNzoAPzj4U1G6YqQdSoo/oNLZKSyYve+uCQeUxMkO7leBxlUt5EFEzlrEPUwPHc/88VQGNNfxvCry2Mj7LQGAt5IYYq15CA8eREKBzzjsXPb16ms41Etrd/KFJAA46sILbWDNCqPlfwW4zCIRRlWgG1vFrpFuBOANPXsr9Tc6l6JaG7AusbUGmO18RqJ2HFd1yq3CcHGaEmw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793001859; c=relaxed/relaxed; bh=hfZXr5B4QU7BP5U94Iy0bbprGRMIU7jhwwRUqW3NVmE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HaybliG+unjgtDIAHO1u3ucNucishMRYLB811LUcQd2eeQKkZBhIeu0yFkf3SXkS3d02/Zb4G1jUyaLK/jTzhcM8F390dj7h2S/uhjltGaxS2OTBWUUHEDoJJM5XgL7rCqWe4Hgbi68P28Xy7CIGZlADjZcI7L2+u3yOaNhQNkv2MsAVMraX3pjOWT/Jei8T4+BqH3GkKGo51H+CEFGLEneHF+FPP5nhjFQQ0WgUtuhLwEsdTWUuMf/XJsw/wUHpaqDRWe883ZIUg2uFDlMRwVk91dev8LFvCTLEPY/+Jf5D0pcVjBZgDRzMcNVwpNZOTUjuTkbs4jfDOIyjlDdT8w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SGCGZ/n/; dkim-atps=neutral; spf=pass (client-ip=2001:41d0:1004:224b::a1; helo=mta0.migadu.com; envelope-from=hao.ge@linux.dev; receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SGCGZ/n/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=2001:41d0:1004:224b::a1; helo=mta0.migadu.com; envelope-from=hao.ge@linux.dev; receiver=lists.ozlabs.org) Received: from mta0.migadu.com (out-161.mta0.migadu.com [IPv6:2001:41d0:1004:224b::a1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jCmNy1DPxz2yb9 for ; Mon, 26 Oct 2026 19:04:17 +1100 (AEDT) X-Envelope-To: linuxppc-dev@lists.ozlabs.org DKIM-Signature: a=rsa-sha256; bh=oeHSWM4q5xftJC3Ex7Fav4XAopE6RwVOINuuoKO7m0c=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793001839; v=1; x=1793606639; b=SGCGZ/n/U8cDqk8YgUjxgC2nmdpXEs8BIFEDK34EAyPbCRmaueDp/jDkCcu9fP5Axjo7QL8q WBaXPcyKTTikTpCEkZz71UKduS8b2acs7EUnQF6MFPT+4BDbez9n1naXq3LsKh4JmVJlT+k3+PF 35oLAAvPpoT30i8ugcJYLbcQ= X-Envelope-To: linuxppc-dev@lists.ozlabs.org Received: by smtp.migadu.com with ESMTPS id 9a1cb61258a50e8b; Mon, 26 Oct 2026 08:02:40 +0000 X-Mizu-Trace-ID: 9a1cb61258a50e8b X-Migadu-Flow: FLOW_OUT From: Hao Ge To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Uladzislau Rezki , Hao Ge , Suren Baghdasaryan , Dev Jain Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH v3 01/10] mm/kmsan: undo the shadow mapping when the origin mapping fails Date: Mon, 26 Oct 2026 16:03:20 +0800 Message-Id: <20261026080329.140244-2-hao.ge@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20261026080329.140244-1-hao.ge@linux.dev> References: <20261026080329.140244-1-hao.ge@linux.dev> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 kmsan_vmap_pages_range_noflush() first maps the shadow pages and then the origin pages. If the second mapping fails, the first one is left mapped, and the callers do not roll it back. The next vmap of the same metadata range hits the stale PTEs again and BUG()s on the huge mapping path, or gets -EBUSY with a WARN_ON() on the small page one. Undo the shadow mapping on that error path, the same way kmsan_ioremap_page_range() cleans up after a partial failure. __vunmap_range_noflush() only clears the PTEs; nothing has touched the shadow mapping, so no TLB flush is needed. Fixes: 47ebd0310e89 ("mm: kmsan: handle alloc failures in kmsan_vmap_pages_range_noflush()") Cc: stable@vger.kernel.org Reviewed-by: Suren Baghdasaryan Reviewed-by: Dev Jain Signed-off-by: Hao Ge --- mm/kmsan/shadow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c index 0c88d89bf0d6..2166086d3dc3 100644 --- a/mm/kmsan/shadow.c +++ b/mm/kmsan/shadow.c @@ -258,6 +258,10 @@ int kmsan_vmap_pages_range_noflush(unsigned long start, unsigned long end, o_pages, page_shift); kmsan_leave_runtime(); if (mapped) { + /* Undo the shadow mapping set up above. */ + kmsan_enter_runtime(); + __vunmap_range_noflush(shadow_start, shadow_end); + kmsan_leave_runtime(); err = mapped; goto ret; } -- 2.25.1