From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020DB606A329 for ; Wed, 28 Oct 2026 19:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=o2U/SxdW Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jFGwJ34Hcz30VF; Thu, 29 Oct 2026 06:03:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::448" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793214192; cv=none; b=ivQZFOFxrSrh0MFt3Iu7wMMThBIQ4rHmyeNQH6rxsadUvkXdtShUXstf/j0juw4evNVI48T2qNZADnmx+bgb5QOnBjkYnKi/z03MC+QzDUcMR9bINTbLynn3MuICfNe81iK/Y+7oAsrcCPQBmCjqpgCOZv/DxKf52PW3LmzgOk5FLueRGo74tszcz5t7R+T5a6SvJbCNkP6+HIeSQGQh49LssMC9Cjjb3LjCZuziVwK1E49FHuTQh/KpBVNyA1weoXZlfEYUGEH1FCTwk7ACnGdW9FTNQG9vcwv1ZdoUCqT5F2C7gHGjVIHrmeHAyo+c6NBwR2j/QX973BK2jxwFRQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793214192; c=relaxed/relaxed; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=K2AV+cE7mcbI5l4ObYM/ortyMpJOkqshuYcI9yuN2a+tAkA0Efj0iJi1fmJFqQFhjK2aoBJ4PjZqzR3AJTIy+A1Jt3qT7yJmsLZG6oiwecnAxBoflfeC+xvBR1qpDAl6OqJ6o7syRXokl25T6OoDyWMx0RLGWw+OTRyzlM0Lss+V/B825CtUEeKbbxqAUDM0mCu+yjp6c3Vf6vjRESK2+rumjCjWJSuhkhPI1LRSH0NJWNxnxvIueYMtahr1p3Yc7FN65oSqwazkyvI0JyPA11u6X63yjLJwuvJeJaRkaJmDI1+DRPX7m2kO24sJw5DQBOvOr+x9uOBn3k+EK0h0+Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=o2U/SxdW; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::448; helo=mail-pf1-x448.google.com; envelope-from=37ubiagykdgiseanjcgoogle.comlinuxppc-devlists.ozlabs.org@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=o2U/SxdW; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::448; helo=mail-pf1-x448.google.com; envelope-from=37ubiagykdgiseanjcgoogle.comlinuxppc-devlists.ozlabs.org@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pf1-x448.google.com (mail-pf1-x448.google.com [IPv6:2607:f8b0:4864:20::448]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jFGwH4JV3z30WF for ; Thu, 29 Oct 2026 06:03:11 +1100 (AEDT) Received: by mail-pf1-x448.google.com with SMTP id d2e1a72fcca58-8a01e2962a1so1732185b3a.2 for ; Wed, 28 Oct 2026 12:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793214189; x=1793818989; darn=lists.ozlabs.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=o2U/SxdWApyD8eTFp/HbdTwsz845mHtM7kh89Xi6vPk4BNqks3lDcKcbsxy0kGEDjk omuACtAuG+zhNiLfSCaJvBgSEDvMnwu6dhCmuX69R5rvrTqttrmql1V3lh2/o6zq7Nm2 d4PGTF9ywpbqpFLPQcSn75mDG/rD0WOy7lJfUzNnnYYNeHuLUpRO5ML/isL9bXXbAvlG ++4H2LZGkeJoU3Ce6lVgvgP3upsFu1RiNmE3i2zH5mPOSzwaS/n+QewS6IuBSq2zk+/v UMuVVmwRd4ppPCGksx1do+XHhqzVLCM1M34ZrgCFCewU46HGp4ZBFkMl50dO2G6RygLY DQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793214189; x=1793818989; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=2kLXiNZ/2JDzrUkW6HUWk6KJcJiXK9nS2oKs7JyJpEYqaonHy6t0CPWkCqG2oHt7O5 HRiL31oJq/zN6JXvMZxn62bjoMN9BZpAHfe6kk8N67ZiGuSGjuYWIBAgJoQMnOZENsgi zOyZLZSedGBgab6438SpQeLUSVAz9UUEcBbKG8kWghuaAN6bEGSWDGP8W0jwG9mryTUr PmR/lnRlstARwBtZ8DLt+bpqyrsYCLNX9juA98YIq9KnL3X+11pqWDq5naH+bxORmnTs 5wmzEWVsm6TaeghV31Axn3i18eBCywaOTeMwDG7ruWVHC834jGuUj2eAxalthsVMYaDs VSLA== X-Forwarded-Encrypted: i=1; AKwUvBw+wIBDLkR2U+sgDjFpn8LRIfhRctFBRYW9xwLC3snqLsMDJzg5/CEsK/KrK+p+a/JTayoFqRm33/Hb1QE=@lists.ozlabs.org X-Gm-Message-State: AFq9FYL32GQq2Omls1gvXP5lNDsvhXSDGjCatMkgOuc+xJeMl3ZPb8QR ForBwGYYB16zzDqnwdvRi+MPTVmkJKalihgsTEZ3Rs0xVOyCER3QT1VqEseiGTlA6Z1S0ox58oI rd0xU2A== X-Received: from pghw14.prod.google.com ([2002:a63:f50e:0:b0:cda:c74c:ca8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4b86:b0:3ac:a11a:7c84 with SMTP id 98e67ed59e1d1-3ae58195de0mr2519930a91.65.1793214189231; Wed, 28 Oct 2026 12:03:09 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 28 Oct 2026 12:02:58 -0700 In-Reply-To: <20261028190259.1819571-1-seanjc@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: Mime-Version: 1.0 References: <20261028190259.1819571-1-seanjc@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028190259.1819571-7-seanjc@google.com> Subject: [PATCH 6/7] KVM: Plumb the full request into __kvm_vcpu_kick() From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Nicholas Piggin , Atish Patra , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Teodorescu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Plumb the full request instead of just a "wait" boolean into __kvm_vcpu_kick() so that it can use kvm_request_needs_ipi() instead of the flawed kvm_vcpu_should_kick(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 2 +- include/linux/kvm_host.h | 6 +++--- virt/kvm/kvm_main.c | 17 +++++++++-------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bbe7378ad0ef..011dc422af78 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -38,7 +38,7 @@ */ static inline void kvmppc_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, true); + __kvm_vcpu_kick(vcpu, 0, true); } /* diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 9db42f58c561..035b1bdd8c09 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1570,11 +1570,11 @@ void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu); bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu); #ifndef CONFIG_S390 -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force); +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int request, bool force); static inline void kvm_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, false); + __kvm_vcpu_kick(vcpu, 0, false); } #endif @@ -2314,7 +2314,7 @@ static __always_inline void kvm_make_request(int req, struct kvm_vcpu *vcpu) static inline void kvm_make_request_and_kick(int req, struct kvm_vcpu *vcpu) { kvm_make_request(req, vcpu); - __kvm_vcpu_kick(vcpu, req & KVM_REQUEST_WAIT, false); + __kvm_vcpu_kick(vcpu, req, false); } #endif diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e1a9da8b43d7..f1792256576b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3913,7 +3913,7 @@ EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_vcpu_wake_up); /* * Kick a sleeping VCPU, or a guest VCPU in guest mode, into host kernel mode. */ -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int req, bool force) { int me, cpu; @@ -3948,14 +3948,15 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) cpu = READ_ONCE(vcpu->cpu); if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) { /* - * Use a reschedule IPI to kick the vCPU if the caller - * doesn't need to wait for a response, as KVM allows - * kicking vCPUs while IRQs are disabled, but using the - * SMP function call framework with IRQs disabled can - * deadlock due to taking cross-CPU locks. + * Use a reschedule IPI to kick the vCPU if the request + * doesn't need to wait for a response (or there is no + * request), as KVM allows kicking vCPUs while IRQs are + * disabled, but using the SMP function call framework + * with IRQs disabled can deadlock due to taking cross- + * CPU locks. */ - if (wait) - smp_call_function_single(cpu, ack_kick, NULL, wait); + if (req & KVM_REQUEST_WAIT) + smp_call_function_single(cpu, ack_kick, NULL, true); else smp_send_reschedule(cpu); } -- 2.56.0.313.g2479322e68-goog