From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC4C6070DB0 for ; Mon, 2 Nov 2026 15:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g7GASIyP Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jJFKw19G4z2y8r; Tue, 03 Nov 2026 02:02:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793631732; cv=none; b=LuqXu7F9S79d9TvPfxF3qwrRo3FT3eQqftIUJ80XyPh7hyQV4lMu1JDv3uvqTd2ESpLx3uFN4W1xl/1D6anMMKSdDpH16OdbuyEpbcmru0hvmUeBitB8HQb8F6E3TAv6sa0VQ4fsKMbjSUvXO/qr27HQzFSevcqjMHDl87VDSEzNS1hf5jRQSlsur3uNHJXHlbJwtauhjJ2d6LZvybkbDam4caqSvYPjJtcyS3Vlyl/Ze8s5bcA5gXdifGn1mle3SNKuBI5G0GyHlhlTMkbW/zNF+xuiWnQ2vrxXh5eH1nKdg046D46BsDVT6bfw4u2NEKf8GNwv07lALdISB2j8tg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793631732; c=relaxed/relaxed; bh=RCWYzTdROaZ//Ublq96X/PsjFPNs26aKqDomYMjplOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YVhdRIggZj7Jh2JSZgbISnMNoBoLw7qWsgc+HxM0Nc7nr2qC5PfQU+e1pW7YrhJQ1kOYYHw55e6qH097ua71y5dBc3Tf76yoknz5JqxIykNSBkwv/u9Uxs1rCXFF5NrcvTrrX1OCxHIvE9o7IDh7gbosrGKZ57ic4D0l9Kr21MZMVY4sgxtQy7dy+ZM9jMRZ4v5KarEEqqB+IhFOPuDlJsWaQfjjoFG1ki/hCQxH2d58MIXt5e5poaSt57J/xznjI3xgUNrIe8DW55zW1+9U1TqGpXQ77Go2YD0pPczNWahlNx4vn9QmxYBLadB/iwu5H3+NWuJMKU9fofLvjEZKHA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g7GASIyP; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g7GASIyP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jJFKv1TCsz2yNj for ; Tue, 03 Nov 2026 02:02:11 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id ACB6443EE2; Mon, 2 Nov 2026 15:02:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAB381F00A1C; Mon, 2 Nov 2026 15:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793631729; bh=RCWYzTdROaZ//Ublq96X/PsjFPNs26aKqDomYMjplOg=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=g7GASIyP66iaHneT0IXLyxGE3Gv8uk+u36p3s2m270MYuKSf/lxqLAMSRJOW/mN5b cqw43daYhwXjGaH+bT+uzWlv1RtJgVmK1pKNWgKadSoQ4YP7xysJZZNazw538Ya2w8 aQyWb7PBw6LuxEkCbQCuHEsb1KvYSgmQDTGlChVmndzt2sLknpmWaqisu0NyUvlM/y hG208gvk6GSsXAzvoi3yhFcxnrvr/4f9iVDAGppDZvhr/8T+2kNPcVMo4GJLXJAgLG J6pV+INZeS4SdtLtP2ZjONMRNNmVsgjQI6Fx9jjazJ3kAgIbreGUlE2x6BQYTDKlDz uF54rLOl1jq1A== From: Christian Brauner Date: Mon, 02 Nov 2026 16:01:28 +0100 Subject: [PATCH RFC 01/22] alpha: srm_env: let procfs copy in writes X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-work-procfs-arch-v1-1-c9492ab08480@kernel.org> References: <20261102-work-procfs-arch-v1-0-c9492ab08480@kernel.org> In-Reply-To: <20261102-work-procfs-arch-v1-0-c9492ab08480@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever X-Mailer: b4 0.17-dev X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Implement ->proc_write_buf() so procfs copies in what is written to /proc/srm_environment/* before it pins the entry, and hand that copy to the console callback through the page it used before. Signed-off-by: Christian Brauner (Amutable) --- arch/alpha/kernel/srm_env.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/alpha/kernel/srm_env.c b/arch/alpha/kernel/srm_env.c index faafc2df7886..6a1742b09a82 100644 --- a/arch/alpha/kernel/srm_env.c +++ b/arch/alpha/kernel/srm_env.c @@ -81,7 +81,7 @@ static int srm_env_proc_show(struct seq_file *m, void *v) return ret; } -static ssize_t srm_env_proc_write(struct file *file, const char __user *buffer, +static ssize_t srm_env_proc_write(struct file *file, char *buffer, size_t count, loff_t *pos) { int res; @@ -92,13 +92,8 @@ static ssize_t srm_env_proc_write(struct file *file, const char __user *buffer, if (!buf) return -ENOMEM; - res = -EINVAL; - if (count >= PAGE_SIZE) - goto out; - res = -EFAULT; - if (copy_from_user(buf, buffer, count)) - goto out; + memcpy(buf, buffer, count); buf[count] = '\0'; ret1 = callback_setenv(id, buf, count); @@ -109,14 +104,13 @@ static ssize_t srm_env_proc_write(struct file *file, const char __user *buffer, res = (int) ret1; } - out: free_page((unsigned long)buf); return res; } static const struct proc_ops srm_env_proc_ops = { .proc_show = srm_env_proc_show, - .proc_write = srm_env_proc_write, + .proc_write_buf = srm_env_proc_write, }; static int __init -- 2.53.0