From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99CD606B0C5 for ; Mon, 2 Nov 2026 15:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g5jXfmAk Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jJFR534qtz3br5; Tue, 03 Nov 2026 02:06:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793632001; cv=none; b=HJfcOruYYrjTWEokEzXU91Ijy4OVsyBYwTSd9vOyp9HNo9kPJPDR4eHtLZKbaiRMU2TRYo9ZBUojPDCq+AMqit5WiEfek2RY+QbEDDxFpbCctgYdEpg0lTXvpRrfUvndnYd7gGTaii36qYleoe+N54K2lXQK/NQF7jA9PPLh2Mjv4L4vYuu2dawUEXaR/JLMSSMnrfS+NLUu+xzzG+x2AG+CMAQRgcXxeAU6htPzVBDOHy/eb9gSY/KGsFKf+TlbcNWddJ21aP0jraZJBrMfSfn2FI4m/phzvy+mcXDd30a4LrEdYtP2V7smMTvxq/1Ipls7biMkeMo4NHCYkSf++A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793632001; c=relaxed/relaxed; bh=D0DFho69O6i+rlC573E8+GaY0MO1KK9pTFWx3bkx1uo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h9ZVyecPl9t15gDH0tKxDUpoENhFfGCsNHc3M3+Klw18zFBgfTeaOhKs6IqzWUGT9o7NAmBAyQSFn0CuwQw5eXHdB85hr9ySV+Bea0xBLKZHl9xn+PURI94Yk/DMKsDBPn18/itfTd0/RoItR3/pt+bT6lhn8uBtb3mKEbrL0HcaJUaPLxtnBDLfThdoxZ31zj31PuDAaVbhHqobz+TXZBMSuJHrQEFj5+tNCjUNUeoBas6Y/lr2xBHyHkHNvEBjHjzUY6Q5vZjLRQ2b2RWtY5z5KGyO+7G+j5zTbbmKdwKX8GUD2Qnv/SZtkBY0z/aNwiSiB0RilHAtGXY67VfNRA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g5jXfmAk; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g5jXfmAk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jJFR44L9Qz30gY for ; Tue, 03 Nov 2026 02:06:40 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 175FF6012A; Mon, 2 Nov 2026 15:06:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C9F61F00A18; Mon, 2 Nov 2026 15:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793631997; bh=D0DFho69O6i+rlC573E8+GaY0MO1KK9pTFWx3bkx1uo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=g5jXfmAkkpbVCcZt3JDC6TsuxQAsfUSbPkDCW7uGVgAQzBE/zvcO7qIvScymWJQ1K n8VazwD2M6Wv79JGlT69a8nmYNWac2kVIU0U/zNaRABKDdAMHpHFgYNA7PEr0PWLeq AebGp1CYYILUE3HH0K8Y/R8JSuxQScRPfh8nZYzeZx50h2vf5qPHNhypeg7PD0iwQv 2+ikdTJsIqiI2yCYwee54jqzaLiVLYJuCtuzzPKkyLzadUHizvSp/DBA0MNt56rv5I 6IBbiNCpEUyFyP/cack1HnEo1QC0pmP0eyaIxCT6k4iIzuTLNpD4qjm+qx0GtucpmL 2tYUkabqdbO9Q== From: Christian Brauner Date: Mon, 02 Nov 2026 16:01:42 +0100 Subject: [PATCH RFC 15/22] xtensa: simdisk: let procfs copy in writes X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-work-procfs-arch-v1-15-c9492ab08480@kernel.org> References: <20261102-work-procfs-arch-v1-0-c9492ab08480@kernel.org> In-Reply-To: <20261102-work-procfs-arch-v1-0-c9492ab08480@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever X-Mailer: b4 0.17-dev X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Implement ->proc_write_buf() so procfs copies in what is written to the simdisk files before it pins the entry, and take the file name from that copy. The files took up to PAGE_SIZE bytes and keep doing that through ->proc_write_size. Signed-off-by: Christian Brauner (Amutable) --- arch/xtensa/platforms/iss/simdisk.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 7b115e023de9..b2f9e7f3ade3 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -241,7 +241,7 @@ static ssize_t proc_read_simdisk(struct file *file, char __user *buf, ssize_t len; char *temp; - /* a write sets at most a page, see proc_write_simdisk() */ + /* a write sets at most a page, see simdisk_proc_ops */ temp = kmalloc(PAGE_SIZE + 2, GFP_KERNEL); if (!temp) return -ENOMEM; @@ -255,40 +255,34 @@ static ssize_t proc_read_simdisk(struct file *file, char __user *buf, return len; } -static ssize_t proc_write_simdisk(struct file *file, const char __user *buf, +static ssize_t proc_write_simdisk(struct file *file, char *buf, size_t count, loff_t *ppos) { - char *tmp; struct simdisk *dev = pde_data(file_inode(file)); int err; - if (count == 0 || count > PAGE_SIZE) + if (count == 0) return -EINVAL; - tmp = memdup_user_nul(buf, count); - if (IS_ERR(tmp)) - return PTR_ERR(tmp); - err = simdisk_detach(dev); if (err != 0) - goto out_free; + return err; - if (count > 0 && tmp[count - 1] == '\n') - tmp[count - 1] = 0; + if (count > 0 && buf[count - 1] == '\n') + buf[count - 1] = 0; - if (tmp[0]) - err = simdisk_attach(dev, tmp); + if (buf[0]) + err = simdisk_attach(dev, buf); if (err == 0) err = count; -out_free: - kfree(tmp); return err; } static const struct proc_ops simdisk_proc_ops = { .proc_read = proc_read_simdisk, - .proc_write = proc_write_simdisk, + .proc_write_buf = proc_write_simdisk, + .proc_write_size = PAGE_SIZE, .proc_lseek = default_llseek, }; -- 2.53.0