From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0C3607E11E for ; Wed, 4 Nov 2026 21:14:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HDqRrYE5 Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jKdV9206Wz2xjQ; Thu, 05 Nov 2026 08:14:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793826849; cv=none; b=IqZKm8R+0ovsKKc/WsGPSTediagNU1r10HCsMEsWksDRHa8cEPjwMCszcJSuLL2p6KwtKlmlWrxvOF9TJhVSdm/nnX6lOL9ZJYLP2qcsA07Cn8+OzfkRlMglatBBkyzMNWM7ypknyNuHNj1/Ija8o0NvCw3dSS8rp7z9l5BlFqWmezZnneJO+JM9bfQs4T120hsuvMHrjQd6+GzsBN4GOiIxAEROLnXM0k8NE2aPgXnR8PV1YSiHaP9vkRlE7oV9FnpD7F4UuDtOjZQEnr/ODMm9i/9pgMb7wVsxgNSyC7rbU+q8jdreYRO7o4PPHrG9BtSWA6fDXx+P9QwbKseUsg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793826849; c=relaxed/relaxed; bh=pmnFGMOE2v1+F0PJGOHw4Gdli7q7gPuktrXwX9LNfoQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QWu2a74QuwZjhlHWXmz2hwxpD355ng8SsDyAb+jw1jmsjVYxSMImFHptKPAH+9J9tGB/I2lLCFY5Od7yoRhBxq4BqfD/dtGwD5rmpUTrdubFvZxWtk1bGvCn9lPAX9siwoxipXrvE1DkknvKLbCn+AymtMFKGwS7QY4bGaK1N0ETvujcHxfIAHTBgkTDTsi6S81+SHjypWbqBDN8EzhJOtEQ/F21ES0rRcqbVkKO514/bxCMWMbyZnN1vG5PVT/QVtp4F/rdZF3RDJjCw5dkwlzqWWKvE7rjpuSeLzqCEJHHKFPk+ieXOG90b1FRrEkKOTeY2NiIoPwl6a6qpfda7Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HDqRrYE5; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HDqRrYE5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jKdV83yYjz2xjN for ; Thu, 05 Nov 2026 08:14:08 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 12C6D43A2A; Wed, 4 Nov 2026 21:14:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED3161F00A16; Wed, 4 Nov 2026 21:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793826845; bh=pmnFGMOE2v1+F0PJGOHw4Gdli7q7gPuktrXwX9LNfoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HDqRrYE5SVW+uz41qBUdlkd/AOD1buzc7yItKvdItI4h8/KuGepVfYio6GPLtiP+J fJ+d4qHm1iNZ/NDis/KF73HhMgppcwATjDAXFRShJfdyGVij/MvKpTe6tFtKF741Vv 9yp+EZP4p3+D40HqIzZkbNueee34dY/20SfSqgn7hMRMXKqxj+niSBoAZb0ACNJwD5 svjcjblOGDnpwrFFpcVVC8ty8x1qq0lEfDdas7ia8TH66801cLAyTfvtLHFeDvwr5b wnb5hluHHKL8qJsYPeHy3t4IGfFFNO/QeKXi/O6wCL4MG4JyRwvT2v3Tf1yj0HE3IE HkKfxGaP/VkNg== From: Christian Brauner To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever Subject: [PATCH RESEND v2 11/13] samples/kfifo: let procfs copy in writes Date: Wed, 4 Nov 2026 22:13:51 +0100 Message-ID: <20261104-work-procfs-net-v2-11-221e2437fed1@kernel.org> In-Reply-To: <20261104-work-procfs-net-v2-0-221e2437fed1@kernel.org> References: <20261104-work-procfs-net-v2-0-221e2437fed1@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3950; i=brauner@kernel.org; h=from:subject:message-id; bh=wqPh89nrehb8eXTwTved41pSSj+cx0NGgazKeJSdQJg=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS97jOYLqMh//ThRIEnvPOqE4X+CB0XWpFzR35zdGxZZ Orh2Zc1O0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACZSsJ7hv7tH6Z8s80W8RROO rN/N/UIp0stetDs498C/PTpXF150cGL4Z+evlr2YbcZl0dpm/huN/+I/eGm9CCnf3nXvVeRZRhs PTgA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Implement ->proc_write_buf() so procfs copies in what is written before it pins the entry, and put that copy into the fifo with kfifo_in() instead of kfifo_from_user(). Writes larger than PAGE_SIZE - 1 bytes fail with -EINVAL now. kfifo_from_user() cut a record to 255 bytes, what the one byte that holds its length can say, so the record sample keeps doing that with PROC_ENTRY_SHORT_WRITES. Signed-off-by: Christian Brauner (Amutable) --- samples/kfifo/bytestream-example.c | 9 +++------ samples/kfifo/inttype-example.c | 10 ++++------ samples/kfifo/record-example.c | 12 ++++++------ 3 files changed, 13 insertions(+), 18 deletions(-) diff --git a/samples/kfifo/bytestream-example.c b/samples/kfifo/bytestream-example.c index 4ae29a12cc8a..8c58fb46a2bf 100644 --- a/samples/kfifo/bytestream-example.c +++ b/samples/kfifo/bytestream-example.c @@ -110,20 +110,17 @@ static int __init testfunc(void) return 0; } -static ssize_t fifo_write(struct file *file, const char __user *buf, +static ssize_t fifo_write(struct file *file, char *buf, size_t count, loff_t *ppos) { - int ret; unsigned int copied; if (mutex_lock_interruptible(&write_access)) return -ERESTARTSYS; - ret = kfifo_from_user(&test, buf, count, &copied); + copied = kfifo_in(&test, buf, count); mutex_unlock(&write_access); - if (ret) - return ret; return copied; } @@ -148,7 +145,7 @@ static ssize_t fifo_read(struct file *file, char __user *buf, static const struct proc_ops fifo_proc_ops = { .proc_read = fifo_read, - .proc_write = fifo_write, + .proc_write_buf = fifo_write, .proc_lseek = noop_llseek, }; diff --git a/samples/kfifo/inttype-example.c b/samples/kfifo/inttype-example.c index e4f93317c5d0..c5d16b815e73 100644 --- a/samples/kfifo/inttype-example.c +++ b/samples/kfifo/inttype-example.c @@ -103,20 +103,18 @@ static int __init testfunc(void) return 0; } -static ssize_t fifo_write(struct file *file, const char __user *buf, +static ssize_t fifo_write(struct file *file, char *buf, size_t count, loff_t *ppos) { - int ret; unsigned int copied; if (mutex_lock_interruptible(&write_access)) return -ERESTARTSYS; - ret = kfifo_from_user(&test, buf, count, &copied); + copied = kfifo_in(&test, (const int *)buf, count / sizeof(int)) * + sizeof(int); mutex_unlock(&write_access); - if (ret) - return ret; return copied; } @@ -141,7 +139,7 @@ static ssize_t fifo_read(struct file *file, char __user *buf, static const struct proc_ops fifo_proc_ops = { .proc_read = fifo_read, - .proc_write = fifo_write, + .proc_write_buf = fifo_write, .proc_lseek = noop_llseek, }; diff --git a/samples/kfifo/record-example.c b/samples/kfifo/record-example.c index e4d1a2d7983c..dcc749247c64 100644 --- a/samples/kfifo/record-example.c +++ b/samples/kfifo/record-example.c @@ -117,20 +117,17 @@ static int __init testfunc(void) return 0; } -static ssize_t fifo_write(struct file *file, const char __user *buf, +static ssize_t fifo_write(struct file *file, char *buf, size_t count, loff_t *ppos) { - int ret; unsigned int copied; if (mutex_lock_interruptible(&write_access)) return -ERESTARTSYS; - ret = kfifo_from_user(&test, buf, count, &copied); + copied = kfifo_in(&test, buf, count); mutex_unlock(&write_access); - if (ret) - return ret; return copied; } @@ -155,8 +152,11 @@ static ssize_t fifo_read(struct file *file, char __user *buf, static const struct proc_ops fifo_proc_ops = { .proc_read = fifo_read, - .proc_write = fifo_write, + .proc_write_buf = fifo_write, .proc_lseek = noop_llseek, + /* kfifo_from_user() cut a record to what its length byte holds */ + .proc_flags = PROC_ENTRY_SHORT_WRITES, + .proc_write_size = U8_MAX, }; static int __init example_init(void) -- 2.53.0