From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DF26606A31C for ; Sun, 8 Nov 2026 22:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=FD/sBXUm Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jN7CR3qZRz3btl; Mon, 09 Nov 2026 09:40:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::c48" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794177603; cv=none; b=Yg7w4UAsWYUVClj/QARGzgUVokBdABWNcVE0j7reXPhtHl5AW3SFuM9TeT7P+cIDMibtClsO4zJrluZHKL1pbU3jn45/HJvrZBARxz8CWtcPI/DijeQBWc+zmY8A6m4pb/irhYhpjNHWVIIayvomheO9VRN/m27yKv8NfsvCC8B6sssBqKAz/TBIE6DVzjCJMkUPcNCPkOxRX+aF4979NqgANd3nJ3ZIjMo49qpHwMD51c29j/1nf0Bibq3qtDtN4p+jcZVW7vII70gEeO4dH6BbYrGSQTIKxc2fVwua98XFUCOsvJALeO8aIu/fWBWwE4hXEmXU+OFIu2pj51hgeA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794177603; c=relaxed/relaxed; bh=cDMmI2UqRAqSDkjhtwDc5ZRUeFfMooMTF2CHO0kKXno=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mjrrlruJ3fxYwKr0uVhgQ17oVIhrq4cNwNtt3X6kgm6BKyTB4sHYhIU+h/qYgv0mdHARPw6JA5Ey/UK5I0XtVh6kBnxzmnWH4Xf39ZNo3blHenyC+VP3/KK/NFkM13yBMibnFRCyzs/jqHSJKvASiOOjuBKOANEsdz77TFgnp2MrvhvnBfIe6uMilg2PmlnYDV3uhu1RwPW0L3es610pig04BzdrJIZ1d9yycow7XfwPLGPHdGh8nstRntwmmCPoYTBIUugIjE6qADraYHE9UWZL0ecxqTmw9NrPCH+hnI3Wa+xQc1+lgU5U0rEBrtaTsge/1oIwk5T1kBEhrvOmVQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=FD/sBXUm; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::c48; helo=mail-oo1-xc48.google.com; envelope-from=3pvrwagckdfu5eb31ef3bb381.zb985ahkccz-01i85fgf.bm8xyf.be3@flex--irogers.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=FD/sBXUm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--irogers.bounces.google.com (client-ip=2607:f8b0:4864:20::c48; helo=mail-oo1-xc48.google.com; envelope-from=3pvrwagckdfu5eb31ef3bb381.zb985ahkccz-01i85fgf.bm8xyf.be3@flex--irogers.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc48.google.com (mail-oo1-xc48.google.com [IPv6:2607:f8b0:4864:20::c48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jN7CP73gwz2xmk for ; Mon, 09 Nov 2026 09:40:01 +1100 (AEDT) Received: by mail-oo1-xc48.google.com with SMTP id 006d021491bc7-716fbae1daaso369165eaf.1 for ; Sun, 08 Nov 2026 14:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177599; x=1794782399; darn=lists.ozlabs.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cDMmI2UqRAqSDkjhtwDc5ZRUeFfMooMTF2CHO0kKXno=; b=FD/sBXUm/aj0PQ+Y1cYWUOl0N4OH0ixUhMdxV2XKrbcFFPFPZZr6ToSYjd7O8EKawj EobB9m6H8ygV3ylj9iO6jq2+MHs9eWkrBArbYfaKiEiBJuJtbnufn1rBUUuDJWeWXoyy FqAyjVDWespPKsmElPD4uw7LjAupENozVmbPQJaF4OcfEM35FOOo1K5MZWZZqx8odPcR A176qh0tfMN8AJ5+xyh+ub+FZSZ4rRRe19RaSDYnixRvx7iIKZPYmgH+ByHFrZ8eYhRn 4PK0VZAsMm7R8XnUNKI49PLO6v0CGPaFt9GDOuNIKqRN/YOVRT4B/aL3oINXeA4OL/mT /S0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177599; x=1794782399; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cDMmI2UqRAqSDkjhtwDc5ZRUeFfMooMTF2CHO0kKXno=; b=BkvoizUlUnTEHo0/K1rU0bwAm0i36WL/rsjROTHs4XX88XXbomFrajgG/enEg3qr7l Ya6BaO7AjrSZiR00rN3LiWfN1bMxh7de/uSkzwQvcokuzX+hlreEZo7/BAtOyMQQ/oL7 PV1yDSyiPxm39CXKnGBEUfniYmT5uxjq0cNXZ42TzrCPnmbQGRa5bpYWEvrSg0wMq2dR rh9TrXtz+1IJ1MsGQXIDvi330n0DT5RLjTMZAYfqzUnkhXJaDtJC0uk5Va2vlaH7b4X3 +BS+mhN2HzweOqUAfMw7alwrTZEVg5jceP7PxnnbCYDLdy2gV9+79GSMcHThqweGJxWN VU9Q== X-Forwarded-Encrypted: i=1; AL+hErFqIPtqdIXJihlUhH015Bca8EwZK8qAzr+0KQHKKLJRP/oXacelY8eFEdjLDLqOgRpDE/LGcMD4vJOQJKY=@lists.ozlabs.org X-Gm-Message-State: APuU4Z+0+dhoN1N9o/ryGT7fTLC656oVwou+z24YRMzmDMjFdijf5TZW G2bBHzjmFUmze4kulWd/qBvdlKxd4h0Y4vsr7dzSeAzhzcC1pr5Prf8452oVUx7KflSefvTrdu6 Mw/4fghMZ6Q== X-Received: from jabkb9.prod.google.com ([2002:a05:6638:a489:b0:5fe:2546:25c9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6820:c0c3:10b0:6f6:b13f:5d2d with SMTP id 006d021491bc7-7170f1b1402mr914772eaf.12.1794177598756; Sun, 08 Nov 2026 14:39:58 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:13 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-10-irogers@google.com> Subject: [PATCH v3 9/9] kobject: Require explicit initialization of struct kobj_type::release From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Documentation/core-api/kobject.rst states: "One important point cannot be overstated: every kobject must have a release() method, and the kobject must persist (in a consistent state) until that method is called. If these constraints are not met, the code is flawed. Note that the kernel will warn you if you forget to provide a release() method. Do not try to get rid of this warning by providing an \"empty\" release function." Annotate struct kobj_type::release with __must_init so the compiler diagnoses any struct kobj_type initializer that omits .release. For the remaining legacy struct kobj_type definitions where the kobject is static, per-CPU, a permanent firmware structure, or embedded inside a devm- or parent-managed allocation rather than freed by kobject_put(), explicitly initialize .release = NULL with a comment documenting why no release callback is provided. Many of these legacy sites are not safe with CONFIG_DEBUG_KOBJECT_RELEASE (for example when backing memory is freed, zeroed, or unmapped on module unload while delayed kobject cleanup is still pending). Fixing those lifetimes is left to follow-up patches; this change does not alter their behavior. Link: https://lpc.events/event/20/contributions/2392/ Signed-off-by: Ian Rogers --- arch/arm64/kernel/cpuinfo.c | 5 +++++ drivers/acpi/sysfs.c | 2 ++ drivers/dma/ioat/sysfs.c | 7 +++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 5 +++++ drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 10 +++++++++ drivers/infiniband/hw/hfi1/sysfs.c | 5 +++++ drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 5 +++++ drivers/parisc/pdc_stable.c | 5 +++++ drivers/power/supply/ab8500_fg.c | 5 +++++ drivers/s390/char/sclp_mem.c | 2 ++ drivers/soc/hisilicon/kunpeng_hccs.c | 21 +++++++++++++++++++ .../fbdev/omap2/omapfb/dss/display-sysfs.c | 7 +++++++ .../fbdev/omap2/omapfb/dss/manager-sysfs.c | 8 +++++++ .../fbdev/omap2/omapfb/dss/overlay-sysfs.c | 8 +++++++ fs/erofs/sysfs.c | 10 +++++++++ fs/f2fs/sysfs.c | 15 +++++++++++++ fs/ocfs2/cluster/masklog.c | 5 +++++ include/linux/kobject.h | 2 +- 18 files changed, 126 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c index 94e6cd211d70..7a4ac8dd0b86 100644 --- a/arch/arm64/kernel/cpuinfo.c +++ b/arch/arm64/kernel/cpuinfo.c @@ -295,6 +295,11 @@ const struct seq_operations cpuinfo_op = { static const struct kobj_type cpuregs_kobj_type = { + /* + * Pre-existing: info->kobj is embedded in per-CPU cpu_data; + * cpuid_cpu_offline() only calls kobject_del(). + */ + .release = NULL, .sysfs_ops = &kobj_sysfs_ops, }; diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c index a4534b3e3cfb..a10f14524dd9 100644 --- a/drivers/acpi/sysfs.c +++ b/drivers/acpi/sysfs.c @@ -975,6 +975,8 @@ static struct attribute *hotplug_profile_attrs[] = { ATTRIBUTE_GROUPS(hotplug_profile); static const struct kobj_type acpi_hotplug_profile_ktype = { + /* Pre-existing: hotplug->kobj is embedded in static struct acpi_scan_hotplug objects. */ + .release = NULL, .sysfs_ops = &kobj_sysfs_ops, .default_groups = hotplug_profile_groups, }; diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c index 976134df8108..b9af60e198ef 100644 --- a/drivers/dma/ioat/sysfs.c +++ b/drivers/dma/ioat/sysfs.c @@ -167,6 +167,13 @@ static const struct attribute *const ioat_attrs[] = { ATTRIBUTE_GROUPS(ioat); const struct kobj_type ioat_ktype = { + /* + * Pre-existing: ioatdma_chan is freed by release_ioatdma(), not + * by kobject_put(). With CONFIG_DEBUG_KOBJECT_RELEASE the delayed + * kobject cleanup queued by ioat_kobject_del() may run after + * that kfree(), a use-after-free. + */ + .release = NULL, .sysfs_ops = &ioat_sysfs_ops, .default_groups = ioat_groups, }; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c index 6cd3927a7e82..a2a027e4b118 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c @@ -892,6 +892,11 @@ static const struct attribute_group ualink_xcp_info_group = { }; static const struct kobj_type ualink_xcp_info_ktype = { + /* + * Pre-existing: xcp->ualink.kobj is embedded in struct amdgpu_xcp_mgr + * rather than freed individually by kobject_put(). + */ + .release = NULL, .sysfs_ops = &kobj_sysfs_ops }; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c index ab14079d1c42..0847134a1391 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c @@ -797,6 +797,11 @@ static const struct sysfs_ops xcp_cfg_res_sysfs_ops = { }; static const struct kobj_type xcp_cfg_res_sysfs_ktype = { + /* + * Pre-existing: xcp_res is embedded in struct amdgpu_xcp_cfg + * rather than freed individually by kobject_put(). + */ + .release = NULL, .sysfs_ops = &xcp_cfg_res_sysfs_ops, .default_groups = xcp_cfg_res_sysfs_groups, }; @@ -1061,6 +1066,11 @@ static const struct attribute_group amdgpu_xcp_attrs_group = { }; static const struct kobj_type xcp_sysfs_ktype = { + /* + * Pre-existing: xcp is embedded in struct amdgpu_xcp_mgr + * rather than freed individually by kobject_put(). + */ + .release = NULL, .sysfs_ops = &kobj_sysfs_ops, }; diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sysfs.c index 372cfd13dc61..5a1aca06b542 100644 --- a/drivers/infiniband/hw/hfi1/sysfs.c +++ b/drivers/infiniband/hw/hfi1/sysfs.c @@ -608,6 +608,11 @@ static const struct sysfs_ops sde_sysfs_ops = { }; static struct kobj_type sde_ktype = { + /* + * Pre-existing: sdma_engine is embedded in dd->per_sdma array + * rather than freed by kobject_put(). + */ + .release = NULL, .sysfs_ops = &sde_sysfs_ops, }; diff --git a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c index fdb63a8fb997..0c9dbf93a0e9 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c @@ -245,6 +245,11 @@ static struct attribute *usnic_ib_qpn_default_attrs[] = { ATTRIBUTE_GROUPS(usnic_ib_qpn_default); static struct kobj_type usnic_ib_qpn_type = { + /* + * Pre-existing: qp_grp->kobj is embedded in RDMA core-managed + * struct usnic_ib_qp_grp rather than freed by kobject_put(). + */ + .release = NULL, .sysfs_ops = &usnic_ib_qpn_sysfs_ops, .default_groups = usnic_ib_qpn_default_groups, }; diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c index 6b567a74fc2c..2f530e8c6757 100644 --- a/drivers/parisc/pdc_stable.c +++ b/drivers/parisc/pdc_stable.c @@ -484,6 +484,11 @@ ATTRIBUTE_GROUPS(paths_subsys); /* Specific kobject type for our PDC paths */ static const struct kobj_type ktype_pdcspath = { + /* + * Pre-existing: pdcspath_entry instances are static; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, .sysfs_ops = &pdcspath_attr_ops, .default_groups = paths_subsys_groups, }; diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c index 069e7fee1d16..f71630d92231 100644 --- a/drivers/power/supply/ab8500_fg.c +++ b/drivers/power/supply/ab8500_fg.c @@ -2539,6 +2539,11 @@ static struct attribute *ab8500_fg_attrs[] = { ATTRIBUTE_GROUPS(ab8500_fg); static const struct kobj_type ab8500_fg_ktype = { + /* + * Pre-existing: fg_kobject is embedded in devm-allocated struct + * ab8500_fg; ab8500_fg_sysfs_exit() only calls kobject_del(). + */ + .release = NULL, .sysfs_ops = &ab8500_fg_sysfs_ops, .default_groups = ab8500_fg_groups, }; diff --git a/drivers/s390/char/sclp_mem.c b/drivers/s390/char/sclp_mem.c index 6df1926d4c62..2fb7271dce36 100644 --- a/drivers/s390/char/sclp_mem.c +++ b/drivers/s390/char/sclp_mem.c @@ -305,6 +305,8 @@ static ssize_t sclp_memmap_on_memory_store(struct kobject *kobj, struct kobj_att } static const struct kobj_type ktype = { + /* Pre-existing: permanent firmware kobjects, never freed */ + .release = NULL, .sysfs_ops = &kobj_sysfs_ops, }; diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c index 0cc2953d59a5..da7a64c95058 100644 --- a/drivers/soc/hisilicon/kunpeng_hccs.c +++ b/drivers/soc/hisilicon/kunpeng_hccs.c @@ -1038,6 +1038,13 @@ static struct attribute *hccs_port_default_attrs[] = { ATTRIBUTE_GROUPS(hccs_port_default); static const struct kobj_type hccs_port_type = { + /* + * Pre-existing: hccs_port_info is allocated via devm_kzalloc() + * rather than freed by kobject_put(). With + * CONFIG_DEBUG_KOBJECT_RELEASE the delayed kobject cleanup may run + * after devm frees it on unbind, a use-after-free. + */ + .release = NULL, .sysfs_ops = &hccs_comm_ops, .default_groups = hccs_port_default_groups, }; @@ -1110,6 +1117,13 @@ static struct attribute *hccs_die_default_attrs[] = { ATTRIBUTE_GROUPS(hccs_die_default); static const struct kobj_type hccs_die_type = { + /* + * Pre-existing: hccs_die_info is allocated via devm_kzalloc() + * rather than freed by kobject_put(). With + * CONFIG_DEBUG_KOBJECT_RELEASE the delayed kobject cleanup may run + * after devm frees it on unbind, a use-after-free. + */ + .release = NULL, .sysfs_ops = &hccs_comm_ops, .default_groups = hccs_die_default_groups, }; @@ -1213,6 +1227,13 @@ static struct attribute *hccs_chip_default_attrs[] = { ATTRIBUTE_GROUPS(hccs_chip_default); static const struct kobj_type hccs_chip_type = { + /* + * Pre-existing: hccs_chip_info is allocated via devm_kzalloc() + * rather than freed by kobject_put(). With + * CONFIG_DEBUG_KOBJECT_RELEASE the delayed kobject cleanup may run + * after devm frees it on unbind, a use-after-free. + */ + .release = NULL, .sysfs_ops = &hccs_comm_ops, .default_groups = hccs_chip_default_groups, }; diff --git a/drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c b/drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c index ae937854403b..452920a4e2a9 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c @@ -304,6 +304,13 @@ static const struct sysfs_ops display_sysfs_ops = { }; static struct kobj_type display_ktype = { + /* + * Pre-existing: dssdev->kobj is embedded in struct omap_dss_device + * and zeroed in display_uninit_sysfs() right after kobject_put(). + * With CONFIG_DEBUG_KOBJECT_RELEASE that memset() clobbers the + * pending delayed kobject cleanup. + */ + .release = NULL, .sysfs_ops = &display_sysfs_ops, .default_groups = display_sysfs_groups, }; diff --git a/drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c b/drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c index 1b644be5fe2e..c343c33199af 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c @@ -496,6 +496,14 @@ static const struct sysfs_ops manager_sysfs_ops = { }; static struct kobj_type manager_ktype = { + /* + * Pre-existing: mgr->kobj is embedded in dynamically allocated + * managers[], zeroed in dss_manager_kobj_uninit() right after + * kobject_put(), and freed in dss_uninit_overlay_managers(). With + * CONFIG_DEBUG_KOBJECT_RELEASE that clobbers and frees the pending + * delayed kobject cleanup. + */ + .release = NULL, .sysfs_ops = &manager_sysfs_ops, .default_groups = manager_sysfs_groups, }; diff --git a/drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c b/drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c index 1da4fb1c77b4..5c14446af9b3 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c @@ -429,6 +429,14 @@ static const struct sysfs_ops overlay_sysfs_ops = { }; static struct kobj_type overlay_ktype = { + /* + * Pre-existing: ovl->kobj is embedded in dynamically allocated + * overlays[] and freed in dss_uninit_overlays() right after + * dss_overlay_kobj_uninit() calls kobject_put(). With + * CONFIG_DEBUG_KOBJECT_RELEASE the delayed kobject cleanup may run + * after kfree(overlays), a use-after-free. + */ + .release = NULL, .sysfs_ops = &overlay_sysfs_ops, .default_groups = overlay_sysfs_groups, }; diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c index dfcec9376cd5..2ea6773cd98f 100644 --- a/fs/erofs/sysfs.c +++ b/fs/erofs/sysfs.c @@ -238,6 +238,11 @@ static const struct kobj_type erofs_sb_ktype = { static const struct kobj_type erofs_ktype = { .default_groups = erofs_groups, .sysfs_ops = &erofs_attr_ops, + /* + * Pre-existing: erofs_root is a static struct kset; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kset erofs_root = { @@ -247,6 +252,11 @@ static struct kset erofs_root = { static const struct kobj_type erofs_feat_ktype = { .default_groups = erofs_feat_groups, .sysfs_ops = &erofs_attr_ops, + /* + * Pre-existing: erofs_feat is a static struct kobject; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kobject erofs_feat = { diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 430356e500af..6e15695cb75f 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1683,6 +1683,11 @@ static const struct kobj_type f2fs_sb_ktype = { static const struct kobj_type f2fs_ktype = { .sysfs_ops = &f2fs_attr_ops, + /* + * Pre-existing: f2fs_kset is a static struct kset; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kset f2fs_kset = { @@ -1697,6 +1702,11 @@ static const struct sysfs_ops f2fs_feat_attr_ops = { static const struct kobj_type f2fs_feat_ktype = { .default_groups = f2fs_feat_groups, .sysfs_ops = &f2fs_feat_attr_ops, + /* + * Pre-existing: f2fs_feat is a static struct kobject; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kobject f2fs_feat = { @@ -1711,6 +1721,11 @@ static const struct sysfs_ops f2fs_tune_attr_ops = { static const struct kobj_type f2fs_tune_ktype = { .default_groups = f2fs_tune_groups, .sysfs_ops = &f2fs_tune_attr_ops, + /* + * Pre-existing: f2fs_tune is a static struct kobject; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kobject f2fs_tune = { diff --git a/fs/ocfs2/cluster/masklog.c b/fs/ocfs2/cluster/masklog.c index 563881ddbf00..ff8a1cf51e72 100644 --- a/fs/ocfs2/cluster/masklog.c +++ b/fs/ocfs2/cluster/masklog.c @@ -147,6 +147,11 @@ static const struct sysfs_ops mlog_attr_ops = { static struct kobj_type mlog_ktype = { .default_groups = mlog_default_groups, .sysfs_ops = &mlog_attr_ops, + /* + * Pre-existing: mlog_kset is a static struct kset; lifetime + * is not controlled by kobject_put(). + */ + .release = NULL, }; static struct kset mlog_kset = { diff --git a/include/linux/kobject.h b/include/linux/kobject.h index 55e37a5d405e..8a1332030884 100644 --- a/include/linux/kobject.h +++ b/include/linux/kobject.h @@ -114,7 +114,7 @@ void kobject_get_ownership(const struct kobject *kobj, kuid_t *uid, kgid_t *gid) char *kobject_get_path(const struct kobject *kobj, gfp_t flag); struct kobj_type { - void (*release)(struct kobject *kobj); + void (*release)(struct kobject *kobj) __must_init; const struct sysfs_ops *sysfs_ops; const struct attribute_group **default_groups; const struct kobj_ns_type_operations *(*child_ns_type)(const struct kobject *kobj); -- 2.56.0.455.g6c5a503b38-goog