From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4545F606A336 for ; Sun, 8 Nov 2026 22:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=gyOusd00 Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jN7C70YH2z2xmk; Mon, 09 Nov 2026 09:39:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::1247" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794177586; cv=none; b=ieC08nwTf4cMvHwMPuoxIsznlPvxHMLyXjk/0zXoneYfCmUURiPilI3wIMeeAdj9WHXml1tjyXackkYIxggz9ub0DMYqphkqNusgWk8m4K6XomxHWtfBTjPvey8EGNtz2kqbmSRzDa0MOwO/OSgsAWMFT9G+lxU5RuBpcyvom+mpeIJmzDn4K2ApSU1zM0VgZPjSQkk4anfKTewcTA/mu3Jr0XYn1r1WrDwNQYfAWaMZ0sFivYQCvffgB9MNhjWKNT3CuwpOBz8Prv6VhUT1pObsiJJTU2bK20nd6AX3xEOCB/FnpMrcaNXNJmYC8hTbFzzWi8oj0r8+ZXAxUzdGuQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794177586; c=relaxed/relaxed; bh=AHLMqwM6/67Zcd/LOxQ2+hhUbtfPU/BOw3z2THUGUxg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=k9wLik67zz+rt2YXE8wHA5ckUcLMY2YluzLoat2tOox2gM5LJlbI+qYv1ZTnDvFsWwJdIp4bIFoQjJHYYYP4Frtg/uJs7Al1WEySR8nAlamLnm/ECe9LVn8mB1QJWvnUPw1BLFU6tsc9vmvL4DEt0AvMR/w0fb2mpeO62FP16+ZCzNHMlWWsdf9QT9at/iVi3See5rggQinvD04zhL+1hH/LQqcKf9125mxUwLF6o9mtQb1dJBJXm0J+XVQbzIlYZQpc9At1if5YuXdDL/Jn96h/vA6Wm2gNSGt/sWERGHhk/isxvKSQ8R3LIPBfSJp0Czk51+ex7CdG98vei3oChg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=gyOusd00; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::1247; helo=mail-dl1-x1247.google.com; envelope-from=3lfrwagckdeqoxumkxymuumrk.iusrot03vvi-jk1royzy.u5rghy.uxm@flex--irogers.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=gyOusd00; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--irogers.bounces.google.com (client-ip=2607:f8b0:4864:20::1247; helo=mail-dl1-x1247.google.com; envelope-from=3lfrwagckdeqoxumkxymuumrk.iusrot03vvi-jk1royzy.u5rghy.uxm@flex--irogers.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-dl1-x1247.google.com (mail-dl1-x1247.google.com [IPv6:2607:f8b0:4864:20::1247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jN7C46w7Qz2xWR for ; Mon, 09 Nov 2026 09:39:44 +1100 (AEDT) Received: by mail-dl1-x1247.google.com with SMTP id a92af1059eb24-154e9d2d94fso923114c88.0 for ; Sun, 08 Nov 2026 14:39:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177582; x=1794782382; darn=lists.ozlabs.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AHLMqwM6/67Zcd/LOxQ2+hhUbtfPU/BOw3z2THUGUxg=; b=gyOusd00j0krQ7bhNFla9j7n6gPDiU8Lyr/qsafYTb3RJejI9yMKQ4w1APXt5YXlXl 9fmAfL1fWrNnSAbPdov6QGlPlvg4u/jA10KCCv6m+WiQg17pYlNnJBR7/R0G5/QOeTpo jHsbaLROc6ZvjyWdmcYx2soQ5q4rxn37UK/iMvVGh2UDi/hYuULrdwQMoEIxppWF8VWD 25+dEfAV955AnTZSyd5mYy90kwneuJXMKRak4w5SBU8/YQyE54PrE7pMNjULeqhH5L0F Cv60O840kE2BEB2pX0a7ULL2i8nVLZEcGcQKEpIG4FhSDEoIBsF5ZPJYkkCfFrN+qzuq AmkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177582; x=1794782382; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AHLMqwM6/67Zcd/LOxQ2+hhUbtfPU/BOw3z2THUGUxg=; b=k17H0yLvLEKNXYZPzmuOvr+yVZxSDscsBtTXMr5IKXIvSo+IBi8AlevA1M8I9ZLvPj xt6huQ9NeJtir/E4x++PnH0dFi0tnD9cfEp+tMzkERwNQUDSdbTcgonksBk7t5sayQy0 5iNUx3gWheReurzcRRZEGmjOL2R4pHZ0tSm5BhV4/raKD6Kns1OfAfRFCxR4UaYfVBfX XBTazNXFPXVrja2q5YiKJDNGK9x2pzDzNg0fGvtvXc9i4IrEHVduCmmnSe/hOibg8M/F JO7NixQf4Cb8BdHjCxHvI6YdiWxsnpAj/GDjSlxo2P4A5BuxTIvftm+pveF/9KOr70VT F5pQ== X-Forwarded-Encrypted: i=1; AL+hErG/HoqvBOF+YIbEAIyzPqUFlZ8CJ4aDcQbNmcti4/6YXc5PjoSO6X3ccO1L9AIHwQxQk50E65wIpnQq/FQ=@lists.ozlabs.org X-Gm-Message-State: APuU4Z8UQTmQ//WogNonXoS/JT/EOPyKger64wm1tmWYNXlotGd4qivp R5CoI5dZjloBhZ0zhevn4crkZM9ZotfnXthdNdvmunSnsgq2HfmnsmJR5GBNXSGXvv12qZb04Xf XNz/7MQhO/g== X-Received: from dlbox21.prod.google.com ([2002:a05:7022:1215:b0:1ab:fb55:f657]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:b884:b0:1b2:695b:79f0 with SMTP id a92af1059eb24-1b39fef03f3mr3576923c88.32.1794177581955; Sun, 08 Nov 2026 14:39:41 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:05 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-2-irogers@google.com> Subject: [PATCH v3 1/9] Compiler Attributes: Add __must_init macro From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-31.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_PASS,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Clang supports the 'require_explicit_initialization' attribute on struct fields to indicate that a field must be initialized explicitly by the user when the object is constructed. When an aggregate initializer or uninitialized variable omits an annotated field, Clang emits a -Wuninitialized-explicit-init warning (enabled by default). Add the __must_init macro to include/linux/compiler_attributes.h (which is included by include/linux/compiler_types.h and include/linux/compiler.h) so kernel structs with error-prone initialization (such as mandatory callbacks or cleanup handlers) can enforce explicit initialization at compile time, as discussed at the Linux Plumbers Conference. The shorter __must_init spelling, rather than the attribute's full name, keeps annotated struct members readable and was suggested by Greg Kroah-Hartman. Note that Clang versions prior to the fix for https://github.com/llvm/llvm-project/issues/232483 do not diagnose file-scope objects declared without any initializer (initializers at file scope that omit the field are diagnosed). Also teach Sphinx (Documentation/conf.py), kernel-doc (tools/lib/python/kdoc/xforms_lists.py), and checkpatch.pl about the new attribute macro. Link: https://lpc.events/event/20/contributions/2392/ Link: https://lore.kernel.org/lkml/2026101532-fantastic-deafness-e04c@gregkh/ Acked-by: Miguel Ojeda Reviewed-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Acked-by: Greg Kroah-Hartman Reviewed-by: Kees Cook Signed-off-by: Ian Rogers --- Documentation/conf.py | 1 + include/linux/compiler_attributes.h | 12 ++++++++++++ scripts/checkpatch.pl | 1 + tools/lib/python/kdoc/xforms_lists.py | 1 + 4 files changed, 15 insertions(+) diff --git a/Documentation/conf.py b/Documentation/conf.py index 5ab26ce89daf..baaa4035258c 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -203,6 +203,7 @@ c_id_attributes = [ "__noreturn", "__packed", "__pure", + "__must_init", "__section", "__always_unused", "__maybe_unused", diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h index 476c4c560d17..b9c0b56dd22e 100644 --- a/include/linux/compiler_attributes.h +++ b/include/linux/compiler_attributes.h @@ -322,6 +322,18 @@ */ #define __pure __attribute__((__pure__)) +/* + * Optional: not supported by gcc + * Optional: only supported since clang >= 20.0 + * + * clang: https://clang.llvm.org/docs/AttributeReference.html#require-explicit-initialization + */ +#if __has_attribute(__require_explicit_initialization__) +# define __must_init __attribute__((__require_explicit_initialization__)) +#else +# define __must_init +#endif + /* * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-section-function-attribute * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#index-section-variable-attribute diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b8b64f720191..6a091c45b1a1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6888,6 +6888,7 @@ sub process { "noreturn" => "__noreturn", "packed" => "__packed", "pure" => "__pure", + "require_explicit_initialization" => "__must_init", "section" => "__section", "used" => "__used", "weak" => "__weak" diff --git a/tools/lib/python/kdoc/xforms_lists.py b/tools/lib/python/kdoc/xforms_lists.py index db23fb650ea8..42956b98aae3 100644 --- a/tools/lib/python/kdoc/xforms_lists.py +++ b/tools/lib/python/kdoc/xforms_lists.py @@ -36,6 +36,7 @@ class CTransforms: (CMatch("CRYPTO_MINALIGN_ATTR"), ""), (CMatch("__private"), ""), (CMatch("__rcu"), ""), + (CMatch("__must_init"), ""), (CMatch("____cacheline_aligned_in_smp"), ""), (CMatch("____cacheline_aligned"), ""), (CMatch("__cacheline_group_(?:begin|end)"), ""), -- 2.56.0.455.g6c5a503b38-goog