From: Michael Neuling <mikey@neuling.org>
To: John Rose <johnrose@austin.ibm.com>
Cc: External List <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: force 4k update_flash block and list sizes
Date: Wed, 08 Nov 2006 13:06:22 +1100 [thread overview]
Message-ID: <20286.1162951582@neuling.org> (raw)
In-Reply-To: <1162943615.13499.15.camel@sinatra.austin.ibm.com>
> +
> + if (flash_block_cache) {
> + rc = kmem_cache_destroy(flash_block_cache);
> + if (rc)
> + printk(KERN_WARNING "%s: cache memory leak\n",
> + __FUNCTION__);
> + }
kmem_cache_destroy doesn't return anything. Hence we get:
arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_cleanup':
arch/powerpc/kernel/rtas_flash.c:835: error: void value not ignored as it ought to be
Mikey
next prev parent reply other threads:[~2006-11-08 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 23:53 [PATCH] powerpc: force 4k update_flash block and list sizes John Rose
2006-11-08 2:06 ` Michael Neuling [this message]
2006-11-08 4:30 ` John Rose
2006-11-08 4:39 ` Michael Neuling
2006-11-08 16:07 ` John Rose
2006-11-08 4:41 ` Michael Ellerman
2006-11-08 9:28 ` Arnd Bergmann
2006-11-08 22:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20286.1162951582@neuling.org \
--to=mikey@neuling.org \
--cc=johnrose@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).