linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bill Fink <billfink@mindspring.com>,
	LinuxPPC Developers <linuxppc-dev@lists.linuxppc.org>
Cc: YellowDog Linux General <yellowdog-general@lists.terrasoftsolutions.com>
Subject: Re: dmasound audio patch
Date: Mon, 8 Apr 2002 13:49:04 +0200	[thread overview]
Message-ID: <20340714231722.28828@smtp.adsl.oleane.com> (raw)
In-Reply-To: <20020407172358.36f3fd3e.billfink@mindspring.com>


>Hi,
>
>A friend of mine, Rob Scott, worked up a patch to the dmasound driver
>that fixes some of the PPC endianness issues by doing byte swapping
>in the driver.  He uses it on a Titanium PowerBook, and I am using it
>on a dual 500 MHz G4 with good results.  Before the patch, using xmms
>with the AudioCD Reader plugin, I had to use the esound driver since
>the OSS driver just gave static.  Now I can use the OSS driver directly,
>so there's no need to run the esd daemon.
>
>I know this patch probably isn't politically correct, since as I understand
>it Linus doesn't believe that things such as byte swapping should be done
>in the kernel.  But then he lives on a little endian machine and doesn't
>need to mess with dozens of broken audio applications.  So if you're not
>worried about kernel political correctness, you might want to give this
>patch a try.  Of course I make no warranty of any kind, but I can attest
>that it works fine on a couple of different PPC systems with BenH kernels
>around 2.4.18.

Hi Bill, thanks for the patch, though I decided long ago I agree with linus
and that swapping shouldn't take place in the kernel. If we go that way, we
make sure userland apps will never be fixed ;)

Ben.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  parent reply	other threads:[~2002-04-08 11:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-07 21:23 dmasound audio patch Bill Fink
2002-04-08 10:30 ` Michel Dänzer
2002-04-08 12:41   ` Bill Fink
2002-04-08 12:50     ` Michel Dänzer
2002-04-08 14:14       ` Bill Fink
2002-04-08 13:22     ` Bill Fink
2002-04-08 11:49 ` Benjamin Herrenschmidt [this message]
2002-04-08 19:23   ` Bill Fink
2002-04-08 18:45     ` Benjamin Herrenschmidt
2002-04-09  1:52       ` Bill Fink
2002-04-09  2:24         ` jeffk
2002-04-09  7:18         ` Ethan Benson
  -- strict thread matches above, loose matches on Subject: below --
2002-04-10  3:36 Bill Fink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20340714231722.28828@smtp.adsl.oleane.com \
    --to=benh@kernel.crashing.org \
    --cc=billfink@mindspring.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=yellowdog-general@lists.terrasoftsolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).