From: Jiri Slaby <jirislaby@kernel.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>,
gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de,
osandov@fb.com
Cc: shile.zhang@linux.alibaba.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()
Date: Tue, 26 Oct 2021 07:10:54 +0200 [thread overview]
Message-ID: <208f7a41-a9fa-630c-cb44-c37c503f3a72@kernel.org> (raw)
In-Reply-To: <20211015024658.1353987-3-xianting.tian@linux.alibaba.com>
On 15. 10. 21, 4:46, Xianting Tian wrote:
> @@ -151,9 +142,11 @@ static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] =
> static void hvc_console_print(struct console *co, const char *b,
> unsigned count)
> {
> - char c[N_OUTBUF] __ALIGNED__;
> + char *c;
> unsigned i = 0, n = 0;
> int r, donecr = 0, index = co->index;
> + unsigned long flags;
> + struct hvc_struct *hp;
>
> /* Console access attempt outside of acceptable console range. */
> if (index >= MAX_NR_HVC_CONSOLES)
> @@ -163,6 +156,13 @@ static void hvc_console_print(struct console *co, const char *b,
> if (vtermnos[index] == -1)
> return;
>
> + hp = cons_hvcs[index];
> + if (!hp)
> + return;
You effectively make the console unusable until someone calls
hvc_alloc() for this device, correct? This doesn't look right. Neither
you describe this change of behaviour in the commit log.
regards,
--
js
suse labs
next prev parent reply other threads:[~2021-10-26 5:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 2:46 [PATCH v11 0/3] make hvc pass dma capable memory to its backend Xianting Tian
2021-10-15 2:46 ` [PATCH v11 1/3] tty: hvc: use correct dma alignment size Xianting Tian
2021-10-15 2:46 ` [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-10-15 12:59 ` Xianting Tian
2021-10-20 8:47 ` Xianting Tian
2021-10-20 8:56 ` Greg KH
2021-10-26 5:10 ` Jiri Slaby [this message]
2021-10-26 6:02 ` Xianting Tian
2021-10-26 6:10 ` Greg KH
2021-10-26 6:11 ` Xianting Tian
2021-10-26 6:49 ` Greg KH
2021-10-15 2:46 ` [PATCH v11 3/3] virtio-console: remove unnecessary kmemdup() Xianting Tian
2021-10-21 8:35 ` [PATCH v11 0/3] make hvc pass dma capable memory to its backend Greg KH
2021-10-21 8:56 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208f7a41-a9fa-630c-cb44-c37c503f3a72@kernel.org \
--to=jirislaby@kernel.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=osandov@fb.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).