LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: vitb@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: remove WARN_ON() from dma-noncoherent.c
Date: Mon, 10 Nov 2008 18:33:36 -0600	[thread overview]
Message-ID: <2094bb9371fc6b6c228b.1226363616@localhost.localdomain> (raw)

I can't tell why this WARN_ON exists, and there's no comment explaining it.
Whether the pmd is present or not, pte_alloc_kernel() seems to handle both
cases.

Booting a 440 kernel with 64K PAGE_SIZE triggers the warning, but boot
successfully completes and I see no problems beyond that.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

---

Large page support is critical for improving KVM performance, so I'd like this
apparently unnecessary warning to be removed to make way for Ilya's patch.

Vitaly, this code was added by you in Feb 2007. Any thoughts?

diff --git a/arch/powerpc/lib/dma-noncoherent.c b/arch/powerpc/lib/dma-noncoherent.c
--- a/arch/powerpc/lib/dma-noncoherent.c
+++ b/arch/powerpc/lib/dma-noncoherent.c
@@ -320,7 +320,6 @@ static int __init dma_alloc_init(void)
 			ret = -ENOMEM;
 			break;
 		}
-		WARN_ON(!pmd_none(*pmd));
 
 		pte = pte_alloc_kernel(pmd, CONSISTENT_BASE);
 		if (!pte) {

             reply	other threads:[~2008-11-11  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11  0:33 Hollis Blanchard [this message]
2008-11-11  2:09 ` [PATCH] powerpc: remove WARN_ON() from dma-noncoherent.c Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2094bb9371fc6b6c228b.1226363616@localhost.localdomain \
    --to=hollisb@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox