From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HTML_ONLY,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14BADC3A59F for ; Thu, 29 Aug 2019 21:37:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B37921726 for ; Thu, 29 Aug 2019 21:37:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B37921726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46KGD85y4XzDrGG for ; Fri, 30 Aug 2019 07:37:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=ukrishn@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46KDsP5kK6zDrgj for ; Fri, 30 Aug 2019 06:36:06 +1000 (AEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7TKWCRR118234; Thu, 29 Aug 2019 16:35:56 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 2upkyx3xrp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Aug 2019 16:35:51 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7TKVVr3025023; Thu, 29 Aug 2019 20:35:50 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma03dal.us.ibm.com with ESMTP id 2umpctursu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Aug 2019 20:35:50 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7TKZmWg19988896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Aug 2019 20:35:48 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B9156E04C; Thu, 29 Aug 2019 20:35:48 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 735E96E054; Thu, 29 Aug 2019 20:35:47 +0000 (GMT) Received: from [9.24.4.105] (unknown [9.24.4.105]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 29 Aug 2019 20:35:47 +0000 (GMT) Subject: Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings. Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/html; charset=us-ascii X-Apple-Auto-Saved: 1 X-Apple-Mail-Plain-Text-Draft: yes From: Uma Krishnan X-Apple-Mail-Remote-Attachments: YES X-Apple-Base-Url: x-msg://6/ In-Reply-To: <279d33f05007e9f3e3fb4e6ea19634b2608ffbd3.1567081143.git.msuchanek@suse.de> X-Apple-Windows-Friendly: 1 Date: Thu, 29 Aug 2019 15:34:08 -0500 X-Apple-Mail-Signature: SKIP_SIGNATURE Content-Transfer-Encoding: quoted-printable Message-Id: <21A3BB0F-98DB-4D64-AE93-9B8A8B6193B3@linux.ibm.com> References: <279d33f05007e9f3e3fb4e6ea19634b2608ffbd3.1567081143.git.msuchanek@suse.de> X-Uniform-Type-Identifier: com.apple.mail-draft To: Michal Suchanek X-Mailer: Apple Mail (2.3445.104.11) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-29_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=5 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908290206 X-Mailman-Approved-At: Fri, 30 Aug 2019 07:29:31 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, "Martin K. Petersen" , "James E.J. Bottomley" , linux-kernel@vger.kernel.org, "Manoj N. Kumar" , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "Matthew R. Ochs" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev"

Below = commit queued up for 5.4 includes these changes.

commit = 657bd277c162580674ddb86a90c4aeb62639bff5
Author: Gustavo A. R. Silva = <gustavo@embeddedor.com>
Date: Sun Jul 28 19:21:19 = 2019 -0500

Thanks,
Uma Krishnan

On Aug 29, 2019, at 7:32 AM, Michal Suchanek = <msuchanek@suse.de> wrote:

Add fallthrough comments where = missing.

Signed-off-by: Michal Suchanek = <msuchanek@suse.de>
---
drivers/scsi/cxlflash/main.c | 8 = ++++++++
1 file changed, 8 insertions(+)

diff --git = a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index = b1f4724efde2..f402fa9a7bec 100644
--- = a/drivers/scsi/cxlflash/main.c
+++ = b/drivers/scsi/cxlflash/main.c
@@ -753,10 +753,13 @@ static void = term_intr(struct cxlflash_cfg *cfg, enum undo_level level,
/* = SISL_MSI_ASYNC_ERROR is setup only for the primary HWQ */
if (index = =3D=3D PRIMARY_HWQ)
= cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 3, = hwq);
+ = = /* fall through */
case UNMAP_TWO:
= cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 2, = hwq);
+ = = /* fall through */
case UNMAP_ONE:
= cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 1, = hwq);
+ = = /* fall through */
case FREE_IRQ:
= cfg->ops->free_afu_irqs(hwq->ctx_cookie);
/* fall = through */
@@ -973,14 +976,18 @@ static void cxlflash_remove(struct = pci_dev *pdev)
switch (cfg->init_state) = {
= case INIT_STATE_CDEV:
= cxlflash_release_chrdev(cfg);
+ /* fall through */
case = INIT_STATE_SCSI:
= cxlflash_term_local_luns(cfg);
= scsi_remove_host(cfg->host);
+ /* fall through */
case = INIT_STATE_AFU:
term_afu(cfg);
+ /* fall = through */
= case INIT_STATE_PCI:
= cfg->ops->destroy_afu(cfg->afu_cookie);
= pci_disable_device(pdev);
+ /* fall through */
case = INIT_STATE_NONE:
free_mem(cfg);
= scsi_host_put(cfg->host);
@@ -3017,6 +3024,7 @@ static = ssize_t num_hwqs_store(struct device *dev,
= wait_event(cfg->reset_waitq, cfg->state !=3D = STATE_RESET);
= = if (cfg->state =3D=3D STATE_NORMAL)
goto = retry;
+ = = /* fall through */
default:
/* = Ideally should not happen */
dev_err(dev, "%s: Device is not = ready, state=3D%d\n",
-- =
2.12.3

=