From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 419BdC4QFDzDrbK for ; Wed, 20 Jun 2018 01:26:23 +1000 (AEST) Received: by mail-io0-x242.google.com with SMTP id u4-v6so584043iof.2 for ; Tue, 19 Jun 2018 08:26:23 -0700 (PDT) Subject: Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1) To: Michael Ellerman , Tejun Heo Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Linus Torvalds , linuxppc-dev References: <20180605190807.GE1351649@devbig577.frc2.facebook.com> <20180605191525.GF1351649@devbig577.frc2.facebook.com> <87bmc8a6qi.fsf@concordia.ellerman.id.au> <87sh5jxmif.fsf@concordia.ellerman.id.au> From: Jens Axboe Message-ID: <21c94bb3-f2d6-535d-f9fe-399e7919c59c@kernel.dk> Date: Tue, 19 Jun 2018 09:26:17 -0600 MIME-Version: 1.0 In-Reply-To: <87sh5jxmif.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/19/18 1:29 AM, Michael Ellerman wrote: > Jens Axboe writes: >> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>> Tejun Heo writes: >>> ... >>>> Jens Axboe (10): >>>> libata: introduce notion of separate hardware tags >>>> libata: convert core and drivers to ->hw_tag usage >>>> libata: bump ->qc_active to a 64-bit type >>>> libata: use ata_tag_internal() consistently >>>> libata: remove assumption that ATA_MAX_QUEUE - 1 is the max >>>> sata_nv: set host can_queue count appropriately >>>> libata: add extra internal command >>> >>> Replying here because I can't find the original mail. >>> >>> The above commit is causing one of my machines to constantly spew ata >>> messages on the console, according to bisect: >>> >>> # first bad commit: [28361c403683c2b00d4f5e76045f3ccd299bf99d] libata: add extra internal command >>> >>> To get it to boot I have to also apply: >>> >>> 88e10092f6a6 ("sata_fsl: use the right type for tag bitshift") >>> >>> >>> The system boots OK and seems fine, except that it's just printing >>> multiple of these per second: >>> >>> ata2: Signature Update detected @ 0 msecs >>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>> ata2.00: configured for UDMA/100 >>> ata2: Signature Update detected @ 0 msecs >>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>> ata2.00: configured for UDMA/100 >>> ata2: Signature Update detected @ 0 msecs >>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>> ata2.00: configured for UDMA/100 >>> ata2: Signature Update detected @ 0 msecs >>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>> ata2.00: configured for UDMA/100 >>> ata2: Signature Update detected @ 0 msecs >>> >>> And it never seems to stop. >>> >>> The machine is a Freescale/NXP P5020ds, using the sata_fsl driver >>> presumably. Any ideas? >> >> Hmm that's odd. Can you include the boot log from a working boot as >> well? Would be nice to see what devices are on the sata adapter. >> The above just looks like a hardreset loop. > > Ah yep. I stupidly assumed it was working, because the machine booted, > but that's because the root disk is on ata1. > > Booting the good kernel: > > ba80c3a572f4 ("sata_nv: set host can_queue count appropriately") > > I see: > > root@p5020ds:~# ls -l /sys/class/ata_port/ > total 0 > lrwxrwxrwx 1 root root 0 Jun 19 06:49 ata1 -> ../../devices/platform/ffe000000.soc/ffe220000.sata/ata1/ata_port/ata1 > lrwxrwxrwx 1 root root 0 Jun 19 17:06 ata2 -> ../../devices/platform/ffe000000.soc/ffe221000.sata/ata2/ata_port/ata2 > > root@p5020ds:~# ls -l /sys/class/block/ | grep ata > lrwxrwxrwx 1 root root 0 Jun 19 17:11 sda -> ../../devices/platform/ffe000000.soc/ffe220000.sata/ata1/host0/target0:0:0/0:0:0:0/block/sda > lrwxrwxrwx 1 root root 0 Jun 19 17:11 sda1 -> ../../devices/platform/ffe000000.soc/ffe220000.sata/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda1 > lrwxrwxrwx 1 root root 0 Jun 19 17:11 sda2 -> ../../devices/platform/ffe000000.soc/ffe220000.sata/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda2 > lrwxrwxrwx 1 root root 0 Jun 19 17:11 sda5 -> ../../devices/platform/ffe000000.soc/ffe220000.sata/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda5 > lrwxrwxrwx 1 root root 0 Jun 19 17:11 sr0 -> ../../devices/platform/ffe000000.soc/ffe221000.sata/ata2/host1/target1:0:0/1:0:0:0/block/sr0 > > So it's the DVD drive. > > root@p5020ds:/sys/devices/platform/ffe000000.soc/ffe221000.sata/ata2/host1/target1:0:0/1:0:0:0/scsi_device/1:0:0:0/device# cat vendor > Optiarc > root@p5020ds:/sys/devices/platform/ffe000000.soc/ffe221000.sata/ata2/host1/target1:0:0/1:0:0:0/scsi_device/1:0:0:0/device# cat model > DVD RW AD-7260S > > > Full boot log from a good boot attached if that's helpful. > > All of the above looks the same when I boot with the broken setup, it > just spams dmesg constantly. > > One thing that is different, on the good kernel I see: > > root@p5020ds:~# mount /dev/sr0 /mnt > mount: no medium found on /dev/sr0 > > vs bad (88e10092f6a6): > > root@p5020ds:~# mount /dev/sr0 /mnt > mount: /dev/sr0 is already mounted or /mnt busy Can you try the below patch, on both 4.17 and on current -git? Might help shed some light on this. The fsl driver does weird stuff with the internal tag, I'm guessing that's related. diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index b8d9cfc60374..9bac5ba36dac 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -28,6 +28,9 @@ #include #include +#undef DPRINTK +#define DPRINTK printk + static unsigned int intr_coalescing_count; module_param(intr_coalescing_count, int, S_IRUGO); MODULE_PARM_DESC(intr_coalescing_count, @@ -318,7 +321,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, DPRINTK("interrupt coalescing, count = 0x%x, ticks = %x\n", intr_coalescing_count, intr_coalescing_ticks); - DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n", + DPRINTK("ICC register status: (hcr base: 0x%p) = 0x%x\n", hcr_base, ioread32(hcr_base + ICC)); } @@ -1479,7 +1482,7 @@ static int sata_fsl_probe(struct platform_device *ofdev) } DPRINTK("@reset i/o = 0x%x\n", ioread32(csr_base + TRANSCFG)); - DPRINTK("sizeof(cmd_desc) = %d\n", sizeof(struct command_desc)); + DPRINTK("sizeof(cmd_desc) = %d\n", (int) sizeof(struct command_desc)); DPRINTK("sizeof(#define cmd_desc) = %d\n", SATA_FSL_CMD_DESC_SIZE); host_priv = kzalloc(sizeof(struct sata_fsl_host_priv), GFP_KERNEL); -- Jens Axboe