Re: Machine check in 4xx ethernet driver

[Felix Radensky <felix@embedded-sol.com>]

Josh Boyer-4 wrote:
> 
> On Mon, Mar 09, 2009 at 03:53:25AM -0700, Felix Radensky wrote:
>>
>>
>>
>>Josh Boyer-4 wrote:
>>> 
>>> On Mon, Mar 09, 2009 at 12:47:02AM -0700, Felix Radensky wrote:
>>>>
>>>>Hi,
>>>>
>>>>I'm getting machine check exception when trying to dump
>>>>emac registers on 405EX Kilauea board. The kernel is 2.6.29-rc7
>>>>The problem seems not new, I can reproduce it on 2.6.25 Denx kernel
>>> 
>>> I've not looked at what that code path does, but the EMAC regs are
>>> in DCR space, not MMIO.  Using memcpy_fromio there seems odd.
>>> 
>>> 
>>
>>At least on 405EX MAL registers are in DCR space, but EMAC and RGMII
>>ones are in MMIO space.
> 
> Ah, quite right.  No coffee yet this morning.
> 
> You'll need to look at the code path ethtool is forcing.  Perhaps it's
> doing
> something stupid.
> 
> The problem goes away if I replace memcpy_fromio() by memcpy().
> Is memcpy_fromio() really necessary in this case ?
> 
> 

-- 
View this message in context: http://www.nabble.com/Machine-check-in-4xx-ethernet-driver-tp22408005p22412825.html
Sent from the linuxppc-dev mailing list archive at Nabble.com.