From: Michael Neuling <mikey@neuling.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc/cell: fix dependency in cpufreq
Date: Tue, 10 Feb 2009 12:48:46 +1100 [thread overview]
Message-ID: <22829.1234230526@neuling.org> (raw)
In-Reply-To: <1234227692.8149.58.camel@localhost>
> > cbe_cpufreq.c uses cbe_cpufreq_has_pmi which is provided by
> > cbe_cpufreq_pmi.c. Hence CBE_CPUFREQ depends on CBE_CPUFREQ_PMI.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > ---
> > I'm not 100% sure is this the right fix. Should CBE_CPUFREQ really
> > depend on CBE_CPUFREQ_PMI?
>
> No I don't think it is. Look at platforms/cell/cbe_cpufreq.h, the
> intention seems to be that if PMI isn't built in then that variable is
> hardcoded to 0 and we never use the pmi routines.
---
#if defined(CONFIG_CBE_CPUFREQ_PMI) || defined(CONFIG_CBE_CPUFREQ_PMI_MODULE)
extern bool cbe_cpufreq_has_pmi;
#else
#define cbe_cpufreq_has_pmi (0)
#endif
--
So, I think this is bust. If cpufreq_pmi is in a module, how does
cpufreq use cbe_cpufreq_has_pmi if the module is not inserted?
Arnd?
Mikey
next prev parent reply other threads:[~2009-02-10 1:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 0:46 [PATCH] powerpc/cell: fix dependency in cpufreq Michael Neuling
2009-02-10 1:01 ` Michael Ellerman
2009-02-10 1:48 ` Michael Neuling [this message]
2009-02-10 2:01 ` Michael Neuling
2009-02-10 15:55 ` Arnd Bergmann
2009-02-10 22:27 ` Michael Neuling
2009-02-10 6:51 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22829.1234230526@neuling.org \
--to=mikey@neuling.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).