* net: fix typo in freescale/ucc_geth.c [not found] <20121008173653.1d17895964980c98af59c8ea@canb.auug.org.au> @ 2012-10-08 23:52 ` Michael Neuling 2012-10-09 4:21 ` David Miller 2012-10-09 6:04 ` Eric Dumazet 0 siblings, 2 replies; 3+ messages in thread From: Michael Neuling @ 2012-10-08 23:52 UTC (permalink / raw) To: Eric Dumazet Cc: Stephen Rothwell, LKML, linuxppc-dev, linux-next, Maxime Bizon, David S. Miller The following patch: acb600d net: remove skb recycling added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c This is a typo and should be dev_kfree_skb(). This fixes this. Signed-off-by: Michael Neuling <mikey@neuling.org> --- This hit as a compile error in next-20121008 with mpc85xx_defconfig. diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index dfa0aaa..0a70bb5 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -3268,7 +3268,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit if (netif_msg_rx_err(ugeth)) ugeth_err("%s, %d: ERROR!!! skb - 0x%08x", __func__, __LINE__, (u32) skb); - dev_free_skb(skb); + dev_kfree_skb(skb); ugeth->rx_skbuff[rxQ][ugeth->skb_currx[rxQ]] = NULL; dev->stats.rx_dropped++; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: net: fix typo in freescale/ucc_geth.c 2012-10-08 23:52 ` net: fix typo in freescale/ucc_geth.c Michael Neuling @ 2012-10-09 4:21 ` David Miller 2012-10-09 6:04 ` Eric Dumazet 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2012-10-09 4:21 UTC (permalink / raw) To: mikey; +Cc: sfr, linux-kernel, linuxppc-dev, edumazet, linux-next, mbizon From: Michael Neuling <mikey@neuling.org> Date: Tue, 09 Oct 2012 10:52:25 +1100 > The following patch: > acb600d net: remove skb recycling > added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c > > This is a typo and should be dev_kfree_skb(). This fixes this. > > Signed-off-by: Michael Neuling <mikey@neuling.org> Applied, thanks a lot. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: net: fix typo in freescale/ucc_geth.c 2012-10-08 23:52 ` net: fix typo in freescale/ucc_geth.c Michael Neuling 2012-10-09 4:21 ` David Miller @ 2012-10-09 6:04 ` Eric Dumazet 1 sibling, 0 replies; 3+ messages in thread From: Eric Dumazet @ 2012-10-09 6:04 UTC (permalink / raw) To: Michael Neuling Cc: Stephen Rothwell, LKML, linuxppc-dev, Eric Dumazet, linux-next, Maxime Bizon, David S. Miller On Tue, 2012-10-09 at 10:52 +1100, Michael Neuling wrote: > The following patch: > acb600d net: remove skb recycling > added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c > > This is a typo and should be dev_kfree_skb(). This fixes this. > > Signed-off-by: Michael Neuling <mikey@neuling.org> > --- > This hit as a compile error in next-20121008 with mpc85xx_defconfig. > > diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c > index dfa0aaa..0a70bb5 100644 > --- a/drivers/net/ethernet/freescale/ucc_geth.c > +++ b/drivers/net/ethernet/freescale/ucc_geth.c > @@ -3268,7 +3268,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit > if (netif_msg_rx_err(ugeth)) > ugeth_err("%s, %d: ERROR!!! skb - 0x%08x", > __func__, __LINE__, (u32) skb); > - dev_free_skb(skb); > + dev_kfree_skb(skb); > > ugeth->rx_skbuff[rxQ][ugeth->skb_currx[rxQ]] = NULL; > Oops, thanks Michael ! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-09 6:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121008173653.1d17895964980c98af59c8ea@canb.auug.org.au>
2012-10-08 23:52 ` net: fix typo in freescale/ucc_geth.c Michael Neuling
2012-10-09 4:21 ` David Miller
2012-10-09 6:04 ` Eric Dumazet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).