* [PATCH] selftests: cachestat: Fix build warnings on ppc64
@ 2024-05-21 3:01 Michael Ellerman
2024-05-29 22:19 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2024-05-21 3:01 UTC (permalink / raw)
To: linux-kselftest, skhan; +Cc: nphamcs, linuxppc-dev, linux-kernel, hannes
Fix warnings like:
test_cachestat.c: In function ‘print_cachestat’:
test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
‘long unsigned int’} [-Wformat=]
By switching to unsigned long long for u64 for ppc64 builds.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
tools/testing/selftests/cachestat/test_cachestat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
index b171fd53b004..632ab44737ec 100644
--- a/tools/testing/selftests/cachestat/test_cachestat.c
+++ b/tools/testing/selftests/cachestat/test_cachestat.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__ // Use ll64
#include <stdio.h>
#include <stdbool.h>
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: cachestat: Fix build warnings on ppc64
2024-05-21 3:01 [PATCH] selftests: cachestat: Fix build warnings on ppc64 Michael Ellerman
@ 2024-05-29 22:19 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-05-29 22:19 UTC (permalink / raw)
To: Michael Ellerman, linux-kselftest
Cc: nphamcs, linuxppc-dev, hannes, linux-kernel, Shuah Khan, shuah
On 5/20/24 21:01, Michael Ellerman wrote:
> Fix warnings like:
> test_cachestat.c: In function ‘print_cachestat’:
> test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
> type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
> ‘long unsigned int’} [-Wformat=]
>
> By switching to unsigned long long for u64 for ppc64 builds.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/cachestat/test_cachestat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
> index b171fd53b004..632ab44737ec 100644
> --- a/tools/testing/selftests/cachestat/test_cachestat.c
> +++ b/tools/testing/selftests/cachestat/test_cachestat.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>
> #include <stdio.h>
> #include <stdbool.h>
Applied to linux-kselftest fixes for the next rc.
Michael, If you want to take this through, let me know, I can drop this.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-29 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 3:01 [PATCH] selftests: cachestat: Fix build warnings on ppc64 Michael Ellerman
2024-05-29 22:19 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).