Re: [PATCH] powerpc/powernv/pci: Drop VF MPS fixup

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 02/09/2020 à 05:51, Oliver O'Halloran a écrit :
> The MPS field in the VF config space is marked as reserved in current
> versions of the SR-IOV spec. In other words, this fixup doesn't do
> anything.
> 
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>

A lot of cleanup patches from Oliver were merged in Septembre 2020 but 
not this one.

Any reason ?

Thanks
Christophe


> ---
>   arch/powerpc/platforms/powernv/eeh-powernv.c | 18 ------------------
>   1 file changed, 18 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c
> index 9af8c3b98853..0cabe4e632e3 100644
> --- a/arch/powerpc/platforms/powernv/eeh-powernv.c
> +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
> @@ -1689,24 +1689,6 @@ static struct eeh_ops pnv_eeh_ops = {
>   	.notify_resume		= NULL
>   };
>   
> -#ifdef CONFIG_PCI_IOV
> -static void pnv_pci_fixup_vf_mps(struct pci_dev *pdev)
> -{
> -	struct pci_dn *pdn = pci_get_pdn(pdev);
> -	int parent_mps;
> -
> -	if (!pdev->is_virtfn)
> -		return;
> -
> -	/* Synchronize MPS for VF and PF */
> -	parent_mps = pcie_get_mps(pdev->physfn);
> -	if ((128 << pdev->pcie_mpss) >= parent_mps)
> -		pcie_set_mps(pdev, parent_mps);
> -	pdn->mps = pcie_get_mps(pdev);
> -}
> -DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, pnv_pci_fixup_vf_mps);
> -#endif /* CONFIG_PCI_IOV */
> -
>   /**
>    * eeh_powernv_init - Register platform dependent EEH operations
>    *