linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* RTC rtc-cmos.c : Fix warning on PowerPC
@ 2010-10-08 12:49 srikanth krishnakar
  2010-10-13  3:24 ` Michael Neuling
  0 siblings, 1 reply; 3+ messages in thread
From: srikanth krishnakar @ 2010-10-08 12:49 UTC (permalink / raw)
  To: Linuxppc-dev, linuxppc-dev; +Cc: Linuxppc-embedded


[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

Hello,

I noticed a compilation warning of RTC for powerpc. Found the fix existing
for MIPS & not for available for PowerPC.

-- 
"The Good You Do, The Best You GET"

Regards
Srikanth Krishnakar
**********************

[-- Attachment #1.2: Type: text/html, Size: 276 bytes --]

[-- Attachment #2: 0001-RTC-rtc-cmos.c-Fix-warning-on-PowerPC.patch --]
[-- Type: text/x-patch, Size: 1218 bytes --]

From 8435e5876fc3d629406c63b85bff82c25fc4bf75 Mon Sep 17 00:00:00 2001
From: Srikanth Krishnakar <skrishna@mvista.com>
Date: Fri, 8 Oct 2010 18:07:06 +0530
Subject: [PATCH] RTC: rtc-cmos.c: Fix warning on PowerPC

The following warning is seen while compilation of PowerPC kernel:

 CC      drivers/rtc/rtc-cmos.o
drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes
of RTC+NVRAM address space, not 64 bytes.

Fix it by adding defined(__powerpc__).

Signed-off-by: Srikanth Krishnakar <skrishna@mvista.com>
---
 drivers/rtc/rtc-cmos.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 5856167..7e6ce62 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -687,7 +687,8 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
 #if	defined(CONFIG_ATARI)
 	address_space = 64;
 #elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \
-			|| defined(__sparc__) || defined(__mips__)
+			|| defined(__sparc__) || defined(__mips__) \
+			|| defined(__powerpc__)
 	address_space = 128;
 #else
 #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes.
-- 
1.6.3.3.333.gdf68


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: RTC rtc-cmos.c : Fix warning on PowerPC
  2010-10-08 12:49 RTC rtc-cmos.c : Fix warning on PowerPC srikanth krishnakar
@ 2010-10-13  3:24 ` Michael Neuling
  2010-10-14 14:03   ` srikanth krishnakar
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Neuling @ 2010-10-13  3:24 UTC (permalink / raw)
  To: srikanth krishnakar; +Cc: linuxppc-dev, Linuxppc-embedded

> I noticed a compilation warning of RTC for powerpc. Found the fix existing
> for MIPS & not for available for PowerPC.

Can you please add the waring text here.

> [1. text/x-patch; 0001-RTC-rtc-cmos.c-Fix-warning-on-PowerPC.patch]...

Please inline the patch rather than using an attachment.

Mikey

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RTC rtc-cmos.c : Fix warning on PowerPC
  2010-10-13  3:24 ` Michael Neuling
@ 2010-10-14 14:03   ` srikanth krishnakar
  0 siblings, 0 replies; 3+ messages in thread
From: srikanth krishnakar @ 2010-10-14 14:03 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, Linuxppc-embedded

>From 8435e5876fc3d629406c63b85bff82c25fc4bf75 Mon Sep 17 00:00:00 2001
From: Srikanth Krishnakar <skrishna@mvista.com>
Date: Fri, 8 Oct 2010 18:07:06 +0530
Subject: [PATCH] RTC: rtc-cmos.c: Fix warning on PowerPC

The following warning is seen while compilation of PowerPC kernel:

 CC      drivers/rtc/rtc-cmos.o
drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes
of RTC+NVRAM address space, not 64 bytes.

Fix it by adding defined(__powerpc__).

Signed-off-by: Srikanth Krishnakar <skrishna@mvista.com>
---
 drivers/rtc/rtc-cmos.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 5856167..7e6ce62 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -687,7 +687,8 @@ cmos_do_probe(struct device *dev, struct resource
*ports, int rtc_irq)
 #if    defined(CONFIG_ATARI)
        address_space = 64;
 #elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \
-                       || defined(__sparc__) || defined(__mips__)
+                       || defined(__sparc__) || defined(__mips__) \
+                       || defined(__powerpc__)
        address_space = 128;
 #else
 #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes.
-- 
1.6.3.3.333.gdf68

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-14 14:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-08 12:49 RTC rtc-cmos.c : Fix warning on PowerPC srikanth krishnakar
2010-10-13  3:24 ` Michael Neuling
2010-10-14 14:03   ` srikanth krishnakar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).