From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 789C4C28D13 for ; Fri, 19 Aug 2022 23:29:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M8dJ06Yxmz3f3F for ; Sat, 20 Aug 2022 09:29:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=p/vghahI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=geoff@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=p/vghahI; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M8Qj82MbSz2xKX for ; Sat, 20 Aug 2022 01:31:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=24MYTNmWKwuz612F53s8OGxxNoOr440y1r636RmtOyM=; b=p/vghahIi+rGsJOOBcIrm0yvFt 0YajqQ0rLEYEnvp2xZHIGxLITHzgOXXEv4M41MX318pD2xLf6gcLiQNI09vS6bl60rwA2GWTjaCQv mxLM0ELFbzpxaMzJrb/xq0jOEuym4AOaZVkU3/CJnmE5ZwD8OhMDokLssZhE6l8fD8W61/qAvfDfS M6u4mrQh7+6QBfnjdHEB1sbLlPEGx9kkwjr0UDMvfCYbuc2drfea8G4keCpflasM8TCCm6QZTYQYv AlZxuTfljpn7GdTINGFYyc+NLCc0rFeua3I+6v+zIHZYya8ZcmJxLSXVRvpYUM4Js1B21+nTRCTGD cnR0C4pg==; Received: from [2600:1702:3c30:6ca0:77cd:43b1:3d69:dd7b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3uE-00BHzl-Dd; Fri, 19 Aug 2022 15:27:30 +0000 Message-ID: <245d4220-a88a-5665-c756-a5b32e5bfeae@infradead.org> Date: Fri, 19 Aug 2022 08:26:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Content-Language: en-US To: Wolfram Sang , linux-kernel@vger.kernel.org References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> From: Geoff Levand In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sat, 20 Aug 2022 09:27:17 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shyam Sundar S K , Igor Russkikh , Kevin Brace , David Dillow , Somnath Kotur , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "K. Y. Srinivasan" , linux-stm32@st-md-mailman.stormreply.com, Andy Gospodarek , Wei Liu , Manish Chopra , Samuel Holland , Madalin Bucur , Christian Lamparter , Michal Simek , Jose Abreu , Radhey Shyam Pandey , Franky Lin , Mark Lee , Chris Lee , Nick Child , Jiri Pirko , Jay Vosburgh , Vinay Kumar Yadav , Arend van Spriel , Nicholas Piggin , Igor Mitsyanko , Krzysztof Halasa , Shay Agroskin , linux-omap@vger.kernel.org, Petr Machata , libertas-dev@lists.infradead.org, Rasesh Mody , Ilias Apalodimas , Douglas Miller , Joakim Zhang , Ralf Baechle , Vivien Didelot , Ion Badulescu , Hartley Sweeten , Stanislav Yakovlev , Jon Mason , Vladimir Oltean , Claudiu Beznea , Christian Benvenuti , Samuel Chessman , linux-usb@vger.kernel.org, Ronak Doshi , Kunihiko Hayashi , Chris Snook , Deni s Kirjanov , Prashant Sreedharan , virtualization@lists.linux-foundation.org, Daniele Venzano , Eric Dumazet , Zhu Yanjun , Tony Nguyen , Arthur Kiyanovski , Leon Romanovsky , "David S. Miller" , Sergey Matyukevich , Jesse Brandeburg , Rain River , Veaceslav Falico , Martin Habets , Yisen Zhuang , Wolfgang Grandegger , Steve Glendinning , Tom Lendacky , Michael Hennerich , Ido Schimmel , Sean Wang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, Siva Reddy Kallam , Cl audiu Manoil , Doug Berger , Simon Kelley , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, Mirko Lindner , Sriharsha Basavapatna , Nicolas Pitre , David Arinzon , Rohit Maheshwari , Tariq Toukan , Sudarsana Kalluru , Taras Chornyi , Maxime Coquelin , linux-mediatek@lists.infradead.org, Heiner Kallweit , linux-wireless@vger.kernel.org, Ajit Khaparde , Petko Manolov , Andreas Larsson , Jason Wang , Kurt Kanzenbach , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, Subbaraya Sundeep , Hin-Tak Leung , Jassi Brar , Noam Dagan , Stanislaw Gruszka , Ajay Singh , Florian Fainelli , Dave Jiang , linux-rdma@vger.kernel.org, Guo-Fu Tseng , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , b43-dev@lists.infradead.org, Simon Horman , Paolo Abeni , Allen Hubbe , Shahed Shaikh , Grygorii Strashko , Byungho An , Haiyang Zhang , Francois Romieu , Hante Meuleman , Vladimir Zapolskiy , Don Fry , John Crispin , Michael Chan , Salil Mehta , GR-Linux-NIC-Dev@marvell.com, linux-parisc@vger.kernel.org, linux-sunxi@lists.linux.dev, Edward Cree , Bryan Whitehead , Saeed Bishara , Mark Einon , Geetha sowjanya , Oliver Neukum , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Ioana Ciornei , Alexandre Torgue , Govindarajulu Varadarajan <_govind@gmx.com>, Thomas Petazzoni , Ayush Sawal , UNGLinuxDriver@microchip.com, linux-acenic@sunsite.dk, Herton Ronaldo Krzesinski , Rahul Verma , Russell King , SHA-cyfmac-dev-list@infineon.com, Lino Sanfilippo , intel-wired-lan@lists.osuosl.org, Jakub Ki cinski , Steffen Klassert , Sunil Goutham , Sebastian Hesselbarth , Jes Sorensen , nic_swsd@realtek.com, Ariel Elior , Jouni Malinen , Kalle Valo , Marc Kleine-Budde , Matthias Brugger , Marcin Wojtas , brcm80211-dev-list.pdl@broadcom.com, Sridhar Samudrala , David Ahern , linux-mips@vger.kernel.org, Li Yang , Stephen Hemminger , hariprasad , ntb@lists.linux.dev, Raju Rangoju , Larry Finger , Saeed Mahameed , Felix Fietkau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Wolfram, On 8/18/22 14:00, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang ... > diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c > index 3dbfb1b20649..6e838e8f79d0 100644 > --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c > +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c > @@ -1187,8 +1187,8 @@ int gelic_net_open(struct net_device *netdev) > void gelic_net_get_drvinfo(struct net_device *netdev, > struct ethtool_drvinfo *info) > { > - strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > - strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > + strscpy(info->driver, DRV_NAME, sizeof(info->driver)); > + strscpy(info->version, DRV_VERSION, sizeof(info->version)); > } > ps3_gelic_net > static int gelic_ether_get_link_ksettings(struct net_device *netdev, > diff --git a/drivers/net/ethernet/toshiba/spider_net_ethtool.c b/drivers/net/ethernet/toshiba/spider_net_ethtool.c > index 93110dba0bfa..fef9fd127b5e 100644 > --- a/drivers/net/ethernet/toshiba/spider_net_ethtool.c > +++ b/drivers/net/ethernet/toshiba/spider_net_ethtool.c > @@ -63,12 +63,12 @@ spider_net_ethtool_get_drvinfo(struct net_device *netdev, > card = netdev_priv(netdev); > > /* clear and fill out info */ > - strlcpy(drvinfo->driver, spider_net_driver_name, > + strscpy(drvinfo->driver, spider_net_driver_name, > sizeof(drvinfo->driver)); > - strlcpy(drvinfo->version, VERSION, sizeof(drvinfo->version)); > - strlcpy(drvinfo->fw_version, "no information", > + strscpy(drvinfo->version, VERSION, sizeof(drvinfo->version)); > + strscpy(drvinfo->fw_version, "no information", > sizeof(drvinfo->fw_version)); > - strlcpy(drvinfo->bus_info, pci_name(card->pdev), > + strscpy(drvinfo->bus_info, pci_name(card->pdev), > sizeof(drvinfo->bus_info)); > } Seems OK for both ps3_gelic_net and spider_net_ethtool. Acked-by: Geoff Levand