From: Kumar Gala <galak@kernel.crashing.org>
To: Jon Loeliger <jdl@jdl.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Xianghua Xiao <x.xiao@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/5] Add initial MPC8610 HPCD Platform files.
Date: Thu, 4 Oct 2007 08:43:27 -0500 [thread overview]
Message-ID: <24AD58B3-9FB4-4A67-B53E-8B666601FB48@kernel.crashing.org> (raw)
In-Reply-To: <E1IdQ7s-0006DC-8I@jdl.com>
On Oct 4, 2007, at 7:48 AM, Jon Loeliger wrote:
> So, like, the other day Kumar Gala mumbled:
>>
>> On Oct 3, 2007, at 10:41 PM, Stephen Rothwell wrote:
>>
>>> On Wed, 03 Oct 2007 15:09:33 -0500 Jon Loeliger <jdl@freescale.com>
>>> wrote:
>>>>
>>>> +++ b/arch/powerpc/platforms/86xx/mpc8610_hpcd.c
>>>> +#include <linux/stddef.h>
>>>> +#include <linux/kernel.h>
>>>> +#include <linux/pci.h>
>>>> +#include <linux/kdev_t.h>
>>>> +#include <linux/delay.h>
>>>> +#include <linux/seq_file.h>
>>>> +
>>>> +#include <asm/system.h>
>>>> +#include <asm/time.h>
>>>> +#include <asm/machdep.h>
>>>> +#include <asm/pci-bridge.h>
>>>> +#include <asm/mpc86xx.h>
>>>> +#include <asm/prom.h>
>>>
>>> You should include linux/of.h as well to use the of_ accessor
>>> functions.
>>
>> added.
>>
>> - k
>
> Thanks, Kumar.
np. I made a few other changes (like killing the cpuinfo code in the
platform).
this is on my for-2.6.24 branch now.
- k
prev parent reply other threads:[~2007-10-04 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 20:09 [PATCH 2/5] Add initial MPC8610 HPCD Platform files Jon Loeliger
2007-10-04 3:41 ` Stephen Rothwell
2007-10-04 4:35 ` Kumar Gala
2007-10-04 12:48 ` Jon Loeliger
2007-10-04 13:43 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24AD58B3-9FB4-4A67-B53E-8B666601FB48@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=x.xiao@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox