From: Dan Malek <dan@embeddededge.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Vitaly Bordug <vbordug@dev.rtsoft.ru>,
linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS
Date: Wed, 23 Nov 2005 15:22:40 -0500 [thread overview]
Message-ID: <24aa4090f558206fa04f9d584c590034@embeddededge.com> (raw)
In-Reply-To: <20051123125326.GB4526@logos.cnet>
On Nov 23, 2005, at 7:53 AM, Marcelo Tosatti wrote:
> Shouldnt you handle ioremap() failure? Most 85xx code written
> by Kumar also does not.
And do what if it fails? Chances are you don't have any
way to report an error message or panic at this point. In
fact, there are a few silly tests like this where the
failure tries to panic or print some message that will never
be seen. Fortunately, the code will never fail and we will
never take such code paths.
-- Dan
next prev parent reply other threads:[~2005-11-23 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 16:42 [PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS Vitaly Bordug
2005-11-23 12:53 ` Marcelo Tosatti
2005-11-23 18:42 ` Kumar Gala
2005-11-23 20:22 ` Dan Malek [this message]
2005-11-23 15:13 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24aa4090f558206fa04f9d584c590034@embeddededge.com \
--to=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=vbordug@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).