From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com,
kbusch@kernel.org
Cc: mahesh@linux.ibm.com, oohall@gmail.com,
Jonathan.Cameron@huawei.com, terry.bowman@amd.com,
tianruidong@linux.alibaba.com
Subject: Re: [PATCH v4 2/3] PCI/DPC: Run recovery on device that detected the error
Date: Mon, 3 Mar 2025 11:48:34 +0800 [thread overview]
Message-ID: <24c07fb8-8a85-42fb-87fe-9f5dbd53eea3@linux.alibaba.com> (raw)
In-Reply-To: <8bb49ca2-6b27-4b05-9ad7-ed10cfa841d5@linux.intel.com>
在 2025/3/3 11:36, Sathyanarayanan Kuppuswamy 写道:
>
> On 2/16/25 6:42 PM, Shuai Xue wrote:
>> The current implementation of pcie_do_recovery() assumes that the
>> recovery process is executed on the device that detected the error.
>> However, the DPC driver currently passes the error port that experienced
>> the DPC event to pcie_do_recovery().
>>
>> Use the SOURCE ID register to correctly identify the device that
>> detected the error. When passing the error device, the
>> pcie_do_recovery() will find the upstream bridge and walk bridges
>> potentially AER affected. And subsequent patches will be able to
>> accurately access AER status of the error device.
>>
>> Should not observe any functional changes.
>>
>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>> ---
>
> Looks good to me
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
Thanks.
Shuai
next prev parent reply other threads:[~2025-03-03 3:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 2:42 [PATCH v4 0/3] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2025-02-17 2:42 ` [PATCH v4 1/3] PCI/DPC: Clarify naming for error port in DPC Handling Shuai Xue
2025-02-17 2:42 ` [PATCH v4 2/3] PCI/DPC: Run recovery on device that detected the error Shuai Xue
2025-03-03 3:36 ` Sathyanarayanan Kuppuswamy
2025-03-03 3:48 ` Shuai Xue [this message]
2025-06-12 10:31 ` Manivannan Sadhasivam
2025-06-19 6:28 ` Shuai Xue
2025-02-17 2:42 ` [PATCH v4 3/3] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2025-03-03 3:43 ` Sathyanarayanan Kuppuswamy
2025-03-03 4:33 ` Shuai Xue
2025-03-17 6:02 ` Shuai Xue
2025-04-24 11:48 ` Shuai Xue
2025-06-12 10:46 ` Manivannan Sadhasivam
2025-03-03 2:03 ` [PATCH v4 0/3] " Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24c07fb8-8a85-42fb-87fe-9f5dbd53eea3@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=terry.bowman@amd.com \
--cc=tianruidong@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).