From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0604FC282C5 for ; Mon, 3 Mar 2025 03:48:46 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Z5lCw3R4kz30VV; Mon, 3 Mar 2025 14:48:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=115.124.30.110 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1740973724; cv=none; b=QjfyIGomy0VufE5nm9LcmD6tDn056WK92ozzjrMGGKjfzzE/r7k3JBAHTO4Br5sDuDeK6NPGWcXns0PCFLD/A28MIhS0I5aiCTymzrmu2ZaWY/QGnB3aAcGadrYz75vUq5OUhQCugwRt2uf/QwaRmopOuqpfXeSqls2f7gAFyHY0bRgpzTtxX0fxKA5bZw5rNDPIsuk6fDvfdJ4RjisZYZURIxNsFOh/GnmQ5nti0/WaiQOC982ufMYRQGLNfxuJTKzUw3xxO9V9n453HWVhlHlSRrWGnFYSQIMFC1oTdyHSQVcAq8gR2BMUxNEUmGjjGM6/1pxOda8hpdLiFMgyGw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1740973724; c=relaxed/relaxed; bh=x6zF8fFARCSUTdMgI1FTCddqWiaaLjFTVKmfeG7gs9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SZ2ejnzELNI+V35UXyT+4VuAXsM89P1Na/+tIEYdSXiQmXHY69DjuzC10DJ/PN6R7zB9A938QzyXcz6klckjTN/xMPeHoJ4p8cmvSnu8BghMUh8Gi5owH6yNVC0lHcM6WGrx9XnPKj4eJek6++2ULYnsrqLQA6ws3cS0W4kQzeg+GKX5BJjvein4yqGjnr57Pf84cukzYgqpnjwrbJEgnQ0gku8ebiB5S7pq2b3luVXKyLffvWdWUY2+p9SucMVUqOdMCAnr5e7F2BblQgJ/xnB/Gzu5/Oy1H76wFo7PgqGsLbcpni+9+PscPDuqhWeY9TqjM+w9l47qK3ubVRnMfw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=g29kH/mG; dkim-atps=neutral; spf=pass (client-ip=115.124.30.110; helo=out30-110.freemail.mail.aliyun.com; envelope-from=xueshuai@linux.alibaba.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=g29kH/mG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.110; helo=out30-110.freemail.mail.aliyun.com; envelope-from=xueshuai@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Z5lCt4zWBz30VQ for ; Mon, 3 Mar 2025 14:48:41 +1100 (AEDT) DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1740973717; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=x6zF8fFARCSUTdMgI1FTCddqWiaaLjFTVKmfeG7gs9E=; b=g29kH/mG7Cr6vvqiXD/EhVW65HFAIJKZG3N/OhrEofhyc1QuxkJHPCr2yU/l9ZEKIi6ek25uCU2inDp1kpDVXVbVMi5Vk18EwwqXwkEapQ+Wf+lnSrA31zrWn/cCjqGerCvMdASWK+SkikKFz30ZcqbidBUqsRk9cwn03PZ0NsI= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQY07TD_1740973714 cluster:ay36) by smtp.aliyun-inc.com; Mon, 03 Mar 2025 11:48:35 +0800 Message-ID: <24c07fb8-8a85-42fb-87fe-9f5dbd53eea3@linux.alibaba.com> Date: Mon, 3 Mar 2025 11:48:34 +0800 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] PCI/DPC: Run recovery on device that detected the error To: Sathyanarayanan Kuppuswamy , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com, kbusch@kernel.org Cc: mahesh@linux.ibm.com, oohall@gmail.com, Jonathan.Cameron@huawei.com, terry.bowman@amd.com, tianruidong@linux.alibaba.com References: <20250217024218.1681-1-xueshuai@linux.alibaba.com> <20250217024218.1681-3-xueshuai@linux.alibaba.com> <8bb49ca2-6b27-4b05-9ad7-ed10cfa841d5@linux.intel.com> From: Shuai Xue In-Reply-To: <8bb49ca2-6b27-4b05-9ad7-ed10cfa841d5@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2025/3/3 11:36, Sathyanarayanan Kuppuswamy 写道: > > On 2/16/25 6:42 PM, Shuai Xue wrote: >> The current implementation of pcie_do_recovery() assumes that the >> recovery process is executed on the device that detected the error. >> However, the DPC driver currently passes the error port that experienced >> the DPC event to pcie_do_recovery(). >> >> Use the SOURCE ID register to correctly identify the device that >> detected the error. When passing the error device, the >> pcie_do_recovery() will find the upstream bridge and walk bridges >> potentially AER affected. And subsequent patches will be able to >> accurately access AER status of the error device. >> >> Should not observe any functional changes. >> >> Signed-off-by: Shuai Xue >> --- > > Looks good to me > > Reviewed-by: Kuppuswamy Sathyanarayanan > Thanks. Shuai