From: Michael Neuling <mikey@neuling.org>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org,
jk@ozlabs.org, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h
Date: Thu, 02 Apr 2009 11:34:03 +1100 [thread overview]
Message-ID: <25834.1238632443@neuling.org> (raw)
In-Reply-To: <49D3419E.7000005@in.ibm.com>
> randconfig build on powerpc failed with :
>=20
>=20
> arch/powerpc/platforms/pseries/dtl.c: In function =C2=91dtl_init=C2=92:
> arch/powerpc/platforms/pseries/dtl.c:238: error: implicit declaration of =
func
tion =C2=91firmware_has_feature=C2=92
> arch/powerpc/platforms/pseries/dtl.c:238: error: =C2=91FW_FEATURE_SPLPAR=
=C2=92 undeclared
(first use in this function)
> arch/powerpc/platforms/pseries/dtl.c:238: error: (Each undeclared identif=
ier=20
is reported only once
> arch/powerpc/platforms/pseries/dtl.c:238: error: for each function it app=
ears
in.)
>=20
> Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
> ---
It's great that you're sending patches to fix these issues but it's not
quite formatted as the maintainers like.
The patch needs to be included inline in the message, rather than as an
attachment. You can see it as an attachment here:
http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070122.html
.. as opposed to the required inline format like this patch:
http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070120.html
Adding a diffstat would also be nice.
Mikey
>=20
>=20
>=20
> --------------050404090408000502010008
> Content-Type: text/x-patch;
> name=3D"fix-dtl-build-break.patch"
> Content-Transfer-Encoding: 8bit
> Content-Disposition: inline;
> filename=3D"fix-dtl-build-break.patch"
>=20
> * Fixes the following build error
> *
> * arch/powerpc/platforms/pseries/dtl.c: In function =E2=80=98dtl_init=E2=
=80=99:
> * arch/powerpc/platforms/pseries/dtl.c:238:
> * error: implicit declaration of function =E2=80=98firmware_has_fea=
ture=E2=80=99
> * arch/powerpc/platforms/pseries/dtl.c:238:
> * error: =E2=80=98FW_FEATURE_SPLPAR=E2=80=99 undeclared (first use =
in this function)
> * arch/powerpc/platforms/pseries/dtl.c:238:
> * error: (Each undeclared identifier is reported only once
> * arch/powerpc/platforms/pseries/dtl.c:238:=20
> * error: for each function it appears in.)
>=20
> Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
> ---
>=20
> diff -Naurp a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platfor=
ms/p
series/dtl.c
> --- a/arch/powerpc/platforms/pseries/dtl.c 2009-04-01 15:46:59.000000000 +
0530
> +++ b/arch/powerpc/platforms/pseries/dtl.c 2009-04-01 15:47:58.000000000 +
0530
> @@ -25,6 +25,7 @@
> #include <asm/smp.h>
> #include <asm/system.h>
> #include <asm/uaccess.h>
> +#include <asm/firmware.h>
>=20=20
> #include "plpar_wrappers.h"
>=20=20
>=20
> --------------050404090408000502010008
> Content-Type: text/plain; charset=3D"us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> --------------050404090408000502010008--
>=20
next prev parent reply other threads:[~2009-04-02 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090401164450.f8192631.sfr@canb.auug.org.au>
2009-04-01 10:27 ` [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h Sachin Sant
2009-04-02 0:34 ` Michael Neuling [this message]
2009-04-02 5:31 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25834.1238632443@neuling.org \
--to=mikey@neuling.org \
--cc=jk@ozlabs.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sachinp@in.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).