From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40c11M36fJzF2Tf for ; Thu, 3 May 2018 13:32:39 +1000 (AEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w433SweZ024076 for ; Wed, 2 May 2018 23:32:36 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hqspf9r5q-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 02 May 2018 23:32:36 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 May 2018 04:32:34 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w433WVne1769924 for ; Thu, 3 May 2018 03:32:31 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C9724C050 for ; Thu, 3 May 2018 04:24:40 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 445484C04A for ; Thu, 3 May 2018 04:24:40 +0100 (BST) Received: from [9.124.35.178] (unknown [9.124.35.178]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP for ; Thu, 3 May 2018 04:24:40 +0100 (BST) Subject: Re: [PATCH 3/4] powerpc/perf: Return appropriate value for unknown domain To: linuxppc-dev@lists.ozlabs.org References: <1523264425-19544-1-git-send-email-anju@linux.vnet.ibm.com> <1523264425-19544-4-git-send-email-anju@linux.vnet.ibm.com> From: Madhavan Srinivasan Date: Thu, 3 May 2018 09:02:30 +0530 MIME-Version: 1.0 In-Reply-To: <1523264425-19544-4-git-send-email-anju@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <25b7b67d-497e-40ec-145f-db38fc64bfd5@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 09 April 2018 02:30 PM, Anju T Sudhakar wrote: > Return proper error code for unknown domain during IMC initialization. Looks good to me. Reviewed-by: Madhavan Srinivasan > Signed-off-by: Anju T Sudhakar > --- > arch/powerpc/perf/imc-pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c > index 1b285cd..4b4ca83 100644 > --- a/arch/powerpc/perf/imc-pmu.c > +++ b/arch/powerpc/perf/imc-pmu.c > @@ -1371,7 +1371,7 @@ int init_imc_pmu(struct device_node *parent, struct imc_pmu *pmu_ptr, int pmu_id > > break; > default: > - return -1; /* Unknown domain */ > + return -EINVAL; /* Unknown domain */ > } > > ret = update_events_in_group(parent, pmu_ptr);