From: David Howells <dhowells@redhat.com>
To: Hannes Hering <hannes.hering@linux.vnet.ibm.com>
Cc: themann@de.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ossrosch@linux.vnet.ibm.com,
linuxppc-dev@ozlabs.org, raisch@de.ibm.com, ossthema@de.ibm.com,
osstklei@de.ibm.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2.6.30-rc5] ehea: fix invalid pointer access
Date: Tue, 05 May 2009 13:19:54 +0100 [thread overview]
Message-ID: <26110.1241525994@redhat.com> (raw)
In-Reply-To: <200905051319.05806.hannes.hering@linux.vnet.ibm.com>
Hannes Hering <hannes.hering@linux.vnet.ibm.com> wrote:
> this is an ehea driver problem, which is occuring when the receive queue runs
> empty. The faulting code is more specifically the following line:
>
> pref = (skb_array[x]->data);
In that case, you might want to move the prefetchw() calls in the following:
pref = skb_array[x];
- prefetchw(pref);
- prefetchw(pref + EHEA_CACHE_LINE);
+ if (pref) {
+ prefetchw(pref);
+ prefetchw(pref + EHEA_CACHE_LINE);
to before the if-statement. That way the CPU can be attempting the prefetch
whilst it's chewing over the test and branch. prefetching shouldn't fault on
a bad address.
David
next prev parent reply other threads:[~2009-05-05 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 16:02 [PATCH 2.6.30-rc5] ehea: fix invalid pointer access Hannes Hering
2009-05-04 18:07 ` David Miller
2009-05-05 9:11 ` David Howells
2009-05-05 11:19 ` Hannes Hering
2009-05-05 12:19 ` David Howells [this message]
2009-05-05 13:45 ` Hannes Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26110.1241525994@redhat.com \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes.hering@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).