From: Michael Neuling <mikey@neuling.org>
To: Milton Miller <miltonm@bga.com>
Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline
Date: Mon, 04 Jun 2007 19:42:16 +1000 [thread overview]
Message-ID: <26608.1180950136@neuling.org> (raw)
In-Reply-To: <8f5d8a214e9042b0c556ac7256928a52@bga.com>
> While this appears to fix the stated problem, did you explore my
> suggestion of deleting and creating the property like we do for
> the initrd base and size?
Yeah, but it didn't seem "hapazard" enough for kexec. :-)
> Deleting and recreating should also handle the case of no boot-args in
> the original /chosen sub-tree (when the bootloader didn't (need to)
> supply a command line).
Yeah, we're screwed when the first boot has no bootargs.
Let me get the policy right. We blow away the old command line except
for the "root=blah" item. Correct?
Mikey
next prev parent reply other threads:[~2007-06-04 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 7:23 [PATCH] kexec ppc64: fix misaligned cmdline Michael Neuling
2007-06-04 9:22 ` Milton Miller
2007-06-04 9:42 ` Michael Neuling [this message]
2007-06-07 1:19 ` Michael Neuling
2007-06-07 16:19 ` Geoff Levand
2007-06-19 5:06 ` Horms
2007-06-04 23:49 ` David Gibson
2007-06-04 23:56 ` Michael Neuling
2007-06-05 0:16 ` David Gibson
2007-06-05 0:58 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26608.1180950136@neuling.org \
--to=mikey@neuling.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).