From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mikey@neuling.org>
From: Michael Neuling <mikey@neuling.org>
To: Tony Breeds <tony@bakeyournoodle.com>
Subject: Re: [PATCH] powerpc: fix uninitialised error in numa.c
In-reply-to: <20120620053808.GD11330@thor.bakeyournoodle.com>
References: <20741.1340165867@neuling.org>
 <20120620053808.GD11330@thor.bakeyournoodle.com>
Date: Wed, 20 Jun 2012 15:46:06 +1000
Message-ID: <27235.1340171166@neuling.org>
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

Tony Breeds <tony@bakeyournoodle.com> wrote:

> On Wed, Jun 20, 2012 at 02:17:47PM +1000, Michael Neuling wrote:
> > chroma_defconfig currently gives me this with gcc 4.6:
> >   arch/powerpc/mm/numa.c:638:13: error: 'dm' may be used uninitialized in this function [-Werror=uninitialized]
> > 
> > It's a bogus warning since of_get_drconf_memory() only writes it
> > anyway.  
> > 
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > cc: stable@kernel.org
> > ---
> > Also affects 3.4 and 3.3 stable.
> > 
> > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> > index 5ca3a15..880acde 100644
> > --- a/arch/powerpc/mm/numa.c
> > +++ b/arch/powerpc/mm/numa.c
> > @@ -637,7 +637,7 @@ static inline int __init read_usm_ranges(const u32 **usm)
> >   */
> >  static void __init parse_drconf_memory(struct device_node *memory)
> >  {
> > -	const u32 *dm, *usm;
> > +	const u32 *dm = NULL, *usm;
> 
> Woot bikeshed!  I think that's what the uninitialized_var() macro is for.

Doesn't work here.  Produces the same error.

Mikey