From: Michael Neuling <mikey@neuling.org>
To: Becky Bruce <beckyb@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] fsl_booke: Correct test for MMU_FTR_BIG_PHYS
Date: Sun, 11 Apr 2010 13:47:36 +1000 [thread overview]
Message-ID: <27522.1270957656@neuling.org> (raw)
In-Reply-To: <1270844541-11125-1-git-send-email-beckyb@kernel.crashing.org>
In message <1270844541-11125-1-git-send-email-beckyb@kernel.crashing.org> you w
rote:
> The code was looking for this in cpu_features, not mmu_features. Fix this.
>
> Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
> ---
> arch/powerpc/mm/fsl_booke_mmu.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/mm/fsl_booke_mmu.c b/arch/powerpc/mm/fsl_booke_mmu.
c
> index c539472..533cae5 100644
> --- a/arch/powerpc/mm/fsl_booke_mmu.c
> +++ b/arch/powerpc/mm/fsl_booke_mmu.c
> @@ -116,7 +116,7 @@ void loadcam_entry(int idx)
> mtspr(SPRN_MAS2, TLBCAM[idx].MAS2);
> mtspr(SPRN_MAS3, TLBCAM[idx].MAS3);
>
> - if (cur_cpu_spec->cpu_features & MMU_FTR_BIG_PHYS)
> + if (cur_cpu_spec->mmu_features & MMU_FTR_BIG_PHYS)
How about using mmu_has_feature()?
> mtspr(SPRN_MAS7, TLBCAM[idx].MAS7);
>
> asm volatile("isync;tlbwe;isync" : : : "memory");
> @@ -152,7 +152,7 @@ static void settlbcam(int index, unsigned long virt, phys
_addr_t phys,
>
> TLBCAM[index].MAS3 = (phys & MAS3_RPN) | MAS3_SX | MAS3_SR;
> TLBCAM[index].MAS3 |= ((flags & _PAGE_RW) ? MAS3_SW : 0);
> - if (cur_cpu_spec->cpu_features & MMU_FTR_BIG_PHYS)
> + if (cur_cpu_spec->mmu_features & MMU_FTR_BIG_PHYS)
Ditto.
Mikey
> TLBCAM[index].MAS7 = (u64)phys >> 32;
>
> #ifndef CONFIG_KGDB /* want user access for breakpoints */
> --
> 1.6.0.6
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2010-04-11 3:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 20:22 [PATCH] fsl_booke: Correct test for MMU_FTR_BIG_PHYS Becky Bruce
2010-04-11 3:47 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27522.1270957656@neuling.org \
--to=mikey@neuling.org \
--cc=beckyb@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).