From: Michael Neuling <michael.neuling@au1.ibm.com>
To: benh@kernel.crashing.org
Cc: Linux PPC dev <linuxppc-dev@ozlabs.org>,
Nishanth Aravamudan <nacc@us.ibm.com>
Subject: Re: [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0
Date: Thu, 25 Apr 2013 17:05:53 +1000 [thread overview]
Message-ID: <27559.1366873553@ale.ozlabs.ibm.com> (raw)
In-Reply-To: <27249.1366873237@ale.ozlabs.ibm.com>
Michael Neuling <mikey@neuling.org> wrote:
> In __restore_cpu_power8 we determine if we are HV and if not, we return
> before setting HV only resources.
>
> Unfortunately we forgot to restore the link register from r11 before
> returning.
>
> This will happen on boot and with secondary CPUs not coming online.
>
> This adds the missing link register restore.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
cc: stable@kernel.org
>
> diff --git a/arch/powerpc/kernel/cpu_setup_power.S b/arch/powerpc/kernel/cpu_setup_power.S
> index ea847ab..1167008 100644
> --- a/arch/powerpc/kernel/cpu_setup_power.S
> +++ b/arch/powerpc/kernel/cpu_setup_power.S
> @@ -66,6 +66,7 @@ _GLOBAL(__restore_cpu_power8)
> bl __init_FSCR
> mfmsr r3
> rldicl. r0,r3,4,63
> + mtlr r11
> beqlr
> li r0,0
> mtspr SPRN_LPID,r0
prev parent reply other threads:[~2013-04-25 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 7:00 [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0 Michael Neuling
2013-04-25 7:05 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27559.1366873553@ale.ozlabs.ibm.com \
--to=michael.neuling@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).