* [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0
@ 2013-04-25 7:00 Michael Neuling
2013-04-25 7:05 ` Michael Neuling
0 siblings, 1 reply; 2+ messages in thread
From: Michael Neuling @ 2013-04-25 7:00 UTC (permalink / raw)
To: benh; +Cc: Linux PPC dev, Nishanth Aravamudan
In __restore_cpu_power8 we determine if we are HV and if not, we return
before setting HV only resources.
Unfortunately we forgot to restore the link register from r11 before
returning.
This will happen on boot and with secondary CPUs not coming online.
This adds the missing link register restore.
Signed-off-by: Michael Neuling <mikey@neuling.org>
diff --git a/arch/powerpc/kernel/cpu_setup_power.S b/arch/powerpc/kernel/cpu_setup_power.S
index ea847ab..1167008 100644
--- a/arch/powerpc/kernel/cpu_setup_power.S
+++ b/arch/powerpc/kernel/cpu_setup_power.S
@@ -66,6 +66,7 @@ _GLOBAL(__restore_cpu_power8)
bl __init_FSCR
mfmsr r3
rldicl. r0,r3,4,63
+ mtlr r11
beqlr
li r0,0
mtspr SPRN_LPID,r0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0
2013-04-25 7:00 [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0 Michael Neuling
@ 2013-04-25 7:05 ` Michael Neuling
0 siblings, 0 replies; 2+ messages in thread
From: Michael Neuling @ 2013-04-25 7:05 UTC (permalink / raw)
To: benh; +Cc: Linux PPC dev, Nishanth Aravamudan
Michael Neuling <mikey@neuling.org> wrote:
> In __restore_cpu_power8 we determine if we are HV and if not, we return
> before setting HV only resources.
>
> Unfortunately we forgot to restore the link register from r11 before
> returning.
>
> This will happen on boot and with secondary CPUs not coming online.
>
> This adds the missing link register restore.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
cc: stable@kernel.org
>
> diff --git a/arch/powerpc/kernel/cpu_setup_power.S b/arch/powerpc/kernel/cpu_setup_power.S
> index ea847ab..1167008 100644
> --- a/arch/powerpc/kernel/cpu_setup_power.S
> +++ b/arch/powerpc/kernel/cpu_setup_power.S
> @@ -66,6 +66,7 @@ _GLOBAL(__restore_cpu_power8)
> bl __init_FSCR
> mfmsr r3
> rldicl. r0,r3,4,63
> + mtlr r11
> beqlr
> li r0,0
> mtspr SPRN_LPID,r0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-25 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-25 7:00 [PATCH] powerpc/power8: fix secondary CPUs hanging on boot for HV=0 Michael Neuling
2013-04-25 7:05 ` Michael Neuling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).