From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168FEC48BCF for ; Wed, 9 Jun 2021 10:52:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6855561059 for ; Wed, 9 Jun 2021 10:52:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6855561059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G0P8L47Hdz3byq for ; Wed, 9 Jun 2021 20:52:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=frTfy1YD; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=frTfy1YD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=frTfy1YD; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=frTfy1YD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G0P7m1TB6z2yQy for ; Wed, 9 Jun 2021 20:52:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=frTfy1YDgNqJUa6+Wl1fkhQV/+kPWz532OoTHULtA6AK2s8MFtdjlqiYnbWoeFzINWwnvG amzLFXrvHcogwLVEUnozyFlZKUE/1pPMnuK2pUBGbSELEsLE2ZrgaWXRGAM8EKoP6mbosP hXIIlMtw1yEzn2UEs0vmRqpLwyhTMnc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=frTfy1YDgNqJUa6+Wl1fkhQV/+kPWz532OoTHULtA6AK2s8MFtdjlqiYnbWoeFzINWwnvG amzLFXrvHcogwLVEUnozyFlZKUE/1pPMnuK2pUBGbSELEsLE2ZrgaWXRGAM8EKoP6mbosP hXIIlMtw1yEzn2UEs0vmRqpLwyhTMnc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-Ishn2fwRPSazO8IDoji68A-1; Wed, 09 Jun 2021 06:52:14 -0400 X-MC-Unique: Ishn2fwRPSazO8IDoji68A-1 Received: by mail-wr1-f71.google.com with SMTP id n4-20020a5d42040000b0290119fef97609so757093wrq.18 for ; Wed, 09 Jun 2021 03:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=ScnPKNVtfvhIXmJxnWamAmildpdYaBBUL+T2iFXUG3Ryi9bRphpqzu1mxHPBkhc+Hx nv89PT7t2DtnoEVYGyEC3vI/oAdfCWwtT4oEH8XX3wIM16/9ghJZdFsaTDSNU7DVzL8V +f/ht7YGf7lU1UP9MfzkzgL4SvZX32gE0l1rJ6mIhvpCC+5gsxSx9C/1ddh0bj4X3gyQ A/Xearg2kvfev3Ap+oJln7kfuLxwryD6rwBFOzuVGkyMXjblhBmwreu1A+Nr90M7ICC/ JO1HF6/vAGYEhAwvvi5UABzxAhNnJreRrb8tzrZko53idtsC7GrvcXwmanl3zLDJLM6U rUQA== X-Gm-Message-State: AOAM532x+2EqCFaRX+7IcCgYdzjEbOR3gehUazupmLsWf05akrQuWKCd P587THqTegea1KTVPv5htKaBkle4gLSkyQhZ7Jx0/4kzvXIAb415Bq9DmcrtWTR91JDcDLiEup6 YVmHhI5eOJDq6RRw/m8WI4Osq5Q== X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528275wmm.156.1623235933571; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOhpm0kR/qb02GnRlZAdwrQqqdavzoWPuk2BGBrMztminfq9lmdrK+j2M/FH+Xh9QtwaeMHg== X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528228wmm.156.1623235933268; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id 89sm25391165wrq.14.2021.06.09.03.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Subject: Re: [PATCH 2/9] arc: update comment about HIGHMEM implementation To: Mike Rapoport , Andrew Morton References: <20210602105348.13387-1-rppt@kernel.org> <20210602105348.13387-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <2764dca8-f395-f76a-0939-215eccdfd82e@redhat.com> Date: Wed, 9 Jun 2021 12:52:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602105348.13387-3-rppt@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Mike Rapoport , Geert Uytterhoeven , Matt Turner , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-arm-kernel@lists.infradead.org, Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 02.06.21 12:53, Mike Rapoport wrote: > From: Mike Rapoport > > Arc does not use DISCONTIGMEM to implement high memory, update the comment > describing how high memory works to reflect this. > > Signed-off-by: Mike Rapoport > --- > arch/arc/mm/init.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c > index e2ed355438c9..397a201adfe3 100644 > --- a/arch/arc/mm/init.c > +++ b/arch/arc/mm/init.c > @@ -139,16 +139,13 @@ void __init setup_arch_memory(void) > > #ifdef CONFIG_HIGHMEM > /* > - * Populate a new node with highmem > - * > * On ARC (w/o PAE) HIGHMEM addresses are actually smaller (0 based) > - * than addresses in normal ala low memory (0x8000_0000 based). > + * than addresses in normal aka low memory (0x8000_0000 based). > * Even with PAE, the huge peripheral space hole would waste a lot of > - * mem with single mem_map[]. This warrants a mem_map per region design. > - * Thus HIGHMEM on ARC is imlemented with DISCONTIGMEM. > - * > - * DISCONTIGMEM in turns requires multiple nodes. node 0 above is > - * populated with normal memory zone while node 1 only has highmem > + * mem with single contiguous mem_map[]. > + * Thus when HIGHMEM on ARC is enabled the memory map corresponding > + * to the hole is freed and ARC specific version of pfn_valid() > + * handles the hole in the memory map. > */ > #ifdef CONFIG_DISCONTIGMEM > node_set_online(1); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb