From: Michael Neuling <mikey@neuling.org>
To: Anton Blanchard <anton@samba.org>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Linux PPC dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/perf: Fix finding overflowed PMC in interrupt
Date: Tue, 06 Nov 2012 12:53:03 +1100 [thread overview]
Message-ID: <27691.1352166783@neuling.org> (raw)
In-Reply-To: <20121106122559.38ea906f@kryten>
> Thanks for looking into this mess. One small thing we can fix in a
> follow up patch:
> > + if (!found)
> > + printk(KERN_WARNING "Can't find PMC that caused
>
> I think it would be worth making that a printk_ratelimited. We are
> probably dead at this stage but we shouldn't spam the console
> at ludicrous speed in the process.
Thanks, good point.
Mikey
next prev parent reply other threads:[~2012-11-06 1:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 1:07 [PATCH] Use pmc_overflow() to detect rolled back events Sukadev Bhattiprolu
2012-09-21 0:38 ` Sukadev Bhattiprolu
2012-11-06 1:08 ` [PATCH 1/2] powerpc/perf: Fix finding overflowed PMC in interrupt Michael Neuling
2012-11-06 1:08 ` [PATCH 2/2] powerpc/perf: Fix for PMCs not making progress Michael Neuling
2012-11-06 1:25 ` [PATCH 1/2] powerpc/perf: Fix finding overflowed PMC in interrupt Anton Blanchard
2012-11-06 1:53 ` Michael Neuling [this message]
2012-11-06 1:53 ` Michael Neuling
2012-11-06 6:47 ` Anshuman Khandual
2012-11-06 10:19 ` Michael Neuling
2012-11-06 10:42 ` Anshuman Khandual
2012-12-22 1:07 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27691.1352166783@neuling.org \
--to=mikey@neuling.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).