From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id B028EDDFE7 for ; Tue, 9 Oct 2007 05:41:45 +1000 (EST) In-Reply-To: References: <20071008151254.7777.38512.stgit@trillian.cg.shawcable.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <27C642CB-ACC0-4E3E-85AA-8319F56364EB@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH] Eval boards should not need to mess with ROOT_DEV Date: Mon, 8 Oct 2007 14:41:54 -0500 To: Grant Likely Cc: Paul Mackerras , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > On 10/8/07, Kumar Gala wrote: >> >> On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: >> >>> From: Grant Likely >>> >>> I can't see a good reason for eval board platform code to mess with >>> the >>> ROOT_DEV value instead of using the default behaviour (so I'm >>> writing >>> this patch to see if anyone will clue me in). >>> >>> Signed-off-by: Grant Likely >>> --- >>> >>> arch/powerpc/platforms/52xx/efika.c | 9 --------- >>> arch/powerpc/platforms/52xx/lite5200.c | 12 ------------ >>> arch/powerpc/platforms/82xx/mpc82xx_ads.c | 6 ------ >>> arch/powerpc/platforms/8xx/mpc86xads_setup.c | 2 -- >>> arch/powerpc/platforms/8xx/mpc885ads_setup.c | 2 -- >>> arch/powerpc/platforms/chrp/setup.c | 10 ---------- >>> 6 files changed, 0 insertions(+), 41 deletions(-) >> >> FYI, 82xx_ads and 885ads don't have this issue in my tree based on >> fixes from Scott. > > So, if I respin this patch to exclude those two platforms, will you > merge it? (Efika and Lite5200 only have it because they were cloned > from CHRP. > > Powermac and pseries also do this weirdness. Should it be removed > from there too? We need benh to make a comment about powermac. I think its ok to remove everywhere but we should see if he has any issue. - k