From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0ACCC433E2 for ; Mon, 14 Sep 2020 07:37:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2778217BA for ; Mon, 14 Sep 2020 07:37:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2778217BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BqdVQ49mQzDqWP for ; Mon, 14 Sep 2020 17:37:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.208.67; helo=mail-ed1-f67.google.com; envelope-from=jirislaby@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BqZgd0dzJzDqPj for ; Mon, 14 Sep 2020 15:30:01 +1000 (AEST) Received: by mail-ed1-f67.google.com with SMTP id l17so16220971edq.12 for ; Sun, 13 Sep 2020 22:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z1T/2900SANPNqCTbSqc4He4lRILj51ILCl9GCqP3W4=; b=s3UUJkIebXRh+ra61w7BmNjBAu6fWOopXCVonXcGAhdzlUx8e0NeKp67TA1pRcLEMz mhNjfNj9q2IRrJs8dbpeU7tC5+Sjk3dmUtKysQA/PUfXCC/A+nRQr78N8li39ZB0d89I YgAq64B6pPeO3rWmcLHr0PBYPDJjOAaqvLo/O4/gEMOoCB3dS0orSr++gW0N1gJH5d7O 7cKRDvVc0yEUvkWIK6GIyWTBpAEqquc8N56B/8HyytQTqFkyIKS/OJpYIuFYZ4hQH3qy B36XMiH4YoujKfIzorH807JVuvDVgBSzPH0bHEVkumnE7xYmT+OvDYbGrKOmNwy/bQ8C YByQ== X-Gm-Message-State: AOAM532+ONri99Szi+JG0vJ6p6ec/hTih3GVaumLKD/W3QtDmEsDpv15 PHQgYH2CwUq23nYNkSzwWDc= X-Google-Smtp-Source: ABdhPJws3XUQIstEOGdOZPJBBXittRedeH4J1mdmUeRlgYjVJja4dh8lelFgQzZbYXI6D6tqtn3KRQ== X-Received: by 2002:aa7:c896:: with SMTP id p22mr15216133eds.382.1600061397730; Sun, 13 Sep 2020 22:29:57 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id k10sm8371017edo.36.2020.09.13.22.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2020 22:29:56 -0700 (PDT) Subject: Re: [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static To: Jason Yan , timur@kernel.org, gregkh@linuxfoundation.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org References: <20200912033834.143166-1-yanaijie@huawei.com> From: Jiri Slaby Message-ID: <27cadfe5-7a7e-6d59-476d-1d03acc2185d@kernel.org> Date: Mon, 14 Sep 2020 07:29:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200912033834.143166-1-yanaijie@huawei.com> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 14 Sep 2020 17:35:24 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hulk Robot Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 12. 09. 20, 5:38, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/tty/serial/ucc_uart.c:286:6: warning: symbol 'qe_uart_set_mctrl' > was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Sure: Acked-by: Jiri Slaby > --- > drivers/tty/serial/ucc_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c > index 3c8c662c69e2..d6a8604157ab 100644 > --- a/drivers/tty/serial/ucc_uart.c > +++ b/drivers/tty/serial/ucc_uart.c > @@ -283,7 +283,7 @@ static unsigned int qe_uart_tx_empty(struct uart_port *port) > * don't need that support. This function must exist, however, otherwise > * the kernel will panic. > */ > -void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl) > +static void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl) > { > } > > -- js