From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 800AED2ECF9 for ; Tue, 20 Jan 2026 06:43:29 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dwHpR4lXFz3bcf; Tue, 20 Jan 2026 17:43:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768891407; cv=none; b=SUhAJq3bvmwblwhhtvq/4EUNUT1hO6s1Jsb8JRLZn5mpUqAxbL2CI+IWMi2C2oGpwNmQW394Tt2vRLAHAa0HqF4iW6SOlrzL/PfOgrGoZ9PDu3x1Po6WDmznauF+EJh14s8MQZsFR2mgFnXUwR9c38tRp8UAE23bcnK8KS8VBQ0BfCSTObnzkJsULqYa5KEJNUsq9S8NKkImuspVj8hJqTosv7c4n777mlCA3hgJJ7OWP3ojBrOPTGlmXBY0tY87qjyiMAZYKrSgTKoiJTdHOIK66cqrZRKQihKhNOuxhbr9MKI+uOBYJKzEtRR7pVtagpIf0ufKnC+lu7de7ECNjQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768891407; c=relaxed/relaxed; bh=C6if+LcGjNYtJ4hNc0emoNvyfA7JdNu83+Hmj3PNywc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PxdRZebYMjxWJuPgL6p1CYwBW3FNyCbi4y1cigDQYdrUFhhbnqXrYKpw/LXMtdhnYnTFS3yU8QltsSbSdgjbN7KgVoYPch+zrTl/JUqTtCVbJgPFr6EB4B+URSdY2U7MXC9gE8j1VFrn00mcMODzDYMSeutSkROZDxO7v0rj/YFiTqirmfNdRLIGvG8yykTmy0XgFfWm9XO1j0MpjWOkzugSwPep5U4NBirCgpma+WZ7vIBquh/GDuRbo+ANXWMoq4n5tGtsAUPZ3zXSwF178Pau0drPpwnMA0DItiWzQhJmqfH41TWhYxPQUdGH/NPkWEXhCyfTWKUVi3wYI37ahw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Nk4HkZgj; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Nk4HkZgj; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dwHpQ4DsQz30M6 for ; Tue, 20 Jan 2026 17:43:26 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 00D1C60008; Tue, 20 Jan 2026 06:43:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72DB0C19424; Tue, 20 Jan 2026 06:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768891403; bh=Q6DZgPGZjNX1B9EVQMzmA20g4dsscqih90PlrSVuaYc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Nk4HkZgjrYVS+vhm53rXMdVIPfF/97GazOLwF6yiaxf1o4KqZQTLLVJF7anBpTgW8 IX0EjbkwPDONkljjeuUrH9DeRlecTWkuglPX0u1Ksldi8dlywyFAqrWEOJAgw8A94X kK/W1bCa86MHEZezshHbLp3czwvGHHJqlgh52Xk3zzFP7kbzfgV2iUMd27UjsI/g14 5tO71nd1Kj4c7PJV1rc1n/+2BoaBm+PLjAsgpfqS5J5UhhoaXoZ70Bxi55xoleKVLd YIOPFXksCOdxkz0/lg9MkziwkVfBoxdaLQ71BWcCKWCekvgvd+N/fTwo9KM5nbV2Le VQ/XM0a6NfcFw== Message-ID: <27f0adf1-54c1-4d99-8b7f-fd45574e7f41@kernel.org> Date: Tue, 20 Jan 2026 07:43:15 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/24] mm/balloon_compaction: move internal helpers to balloon_compaction.c To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Broadcom internal kernel review list , linux-doc@vger.kernel.org, virtualization@lists.linux.dev, Andrew Morton , Oscar Salvador , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Arnd Bergmann , Greg Kroah-Hartman , Jerrin Shaji George , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Zi Yan References: <20260119230133.3551867-1-david@kernel.org> <20260119230133.3551867-16-david@kernel.org> From: "David Hildenbrand (Red Hat)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAa2VybmVsLm9yZz7CwY0EEwEIADcWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaKYhwAIbAwUJJlgIpAILCQQVCgkIAhYCAh4FAheAAAoJEE3eEPcA/4Naa5EP/3a1 9sgS9m7oiR0uenlj+C6kkIKlpWKRfGH/WvtFaHr/y06TKnWn6cMOZzJQ+8S39GOteyCCGADh 6ceBx1KPf6/AvMktnGETDTqZ0N9roR4/aEPSMt8kHu/GKR3gtPwzfosX2NgqXNmA7ErU4puf zica1DAmTvx44LOYjvBV24JQG99bZ5Bm2gTDjGXV15/X159CpS6Tc2e3KvYfnfRvezD+alhF XIym8OvvGMeo97BCHpX88pHVIfBg2g2JogR6f0PAJtHGYz6M/9YMxyUShJfo0Df1SOMAbU1Q Op0Ij4PlFCC64rovjH38ly0xfRZH37DZs6kP0jOj4QdExdaXcTILKJFIB3wWXWsqLbtJVgjR YhOrPokd6mDA3gAque7481KkpKM4JraOEELg8pF6eRb3KcAwPRekvf/nYVIbOVyT9lXD5mJn IZUY0LwZsFN0YhGhQJ8xronZy0A59faGBMuVnVb3oy2S0fO1y/r53IeUDTF1wCYF+fM5zo14 5L8mE1GsDJ7FNLj5eSDu/qdZIKqzfY0/l0SAUAAt5yYYejKuii4kfTyLDF/j4LyYZD1QzxLC MjQl36IEcmDTMznLf0/JvCHlxTYZsF0OjWWj1ATRMk41/Q+PX07XQlRCRcE13a8neEz3F6we 08oWh2DnC4AXKbP+kuD9ZP6+5+x1H1zEzsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCgh Cj/CA/lc/LMthqQ773gauB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseB fDXHA6m4B3mUTWo13nid0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts 6TZ+IrPOwT1hfB4WNC+X2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiu Qmt3yqrmN63V9wzaPhC+xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKB Tccu2AXJXWAE1Xjh6GOC8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvF FFyAS0Nk1q/7EChPcbRbhJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh 2YmnmLRTro6eZ/qYwWkCu8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRk F3TwgucpyPtcpmQtTkWSgDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0L LH63+BrrHasfJzxKXzqgrW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4v q7oFCPsOgwARAQABwsF8BBgBCAAmAhsMFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmic2qsF CSZYCKEACgkQTd4Q9wD/g1oq0xAAsAnw/OmsERdtdwRfAMpC74/++2wh9RvVQ0x8xXvoGJwZ rk0Jmck1ABIM//5sWDo7eDHk1uEcc95pbP9XGU6ZgeiQeh06+0vRYILwDk8Q/y06TrTb1n4n 7FRwyskKU1UWnNW86lvWUJuGPABXjrkfL41RJttSJHF3M1C0u2BnM5VnDuPFQKzhRRktBMK4 GkWBvXlsHFhn8Ev0xvPE/G99RAg9ufNAxyq2lSzbUIwrY918KHlziBKwNyLoPn9kgHD3hRBa Yakz87WKUZd17ZnPMZiXriCWZxwPx7zs6cSAqcfcVucmdPiIlyG1K/HIk2LX63T6oO2Libzz 7/0i4+oIpvpK2X6zZ2cu0k2uNcEYm2xAb+xGmqwnPnHX/ac8lJEyzH3lh+pt2slI4VcPNnz+ vzYeBAS1S+VJc1pcJr3l7PRSQ4bv5sObZvezRdqEFB4tUIfSbDdEBCCvvEMBgoisDB8ceYxO cFAM8nBWrEmNU2vvIGJzjJ/NVYYIY0TgOc5bS9wh6jKHL2+chrfDW5neLJjY2x3snF8q7U9G EIbBfNHDlOV8SyhEjtX0DyKxQKioTYPOHcW9gdV5fhSz5tEv+ipqt4kIgWqBgzK8ePtDTqRM qZq457g1/SXSoSQi4jN+gsneqvlTJdzaEu1bJP0iv6ViVf15+qHuY5iojCz8fa0= In-Reply-To: <20260119230133.3551867-16-david@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/26 00:01, David Hildenbrand (Red Hat) wrote: > Let's move the helpers that are not required by drivers anymore. > > While at it, drop the doc of balloon_page_device() as it is trivial. > > Reviewed-by: Lorenzo Stoakes > Acked-by: Michael S. Tsirkin > Signed-off-by: David Hildenbrand (Red Hat) > --- > include/linux/balloon_compaction.h | 44 ------------------------------ > mm/balloon_compaction.c | 38 ++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+), 44 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index d1d4739398978..eec8994056a44 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -75,48 +75,4 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon) > balloon->migratepage = NULL; > balloon->adjust_managed_page_count = false; > } > - > -#ifdef CONFIG_BALLOON_COMPACTION > -/* > - * balloon_page_device - get the b_dev_info descriptor for the balloon device > - * that enqueues the given page. > - */ > -static inline struct balloon_dev_info *balloon_page_device(struct page *page) > -{ > - return (struct balloon_dev_info *)page_private(page); > -} > -#endif /* CONFIG_BALLOON_COMPACTION */ > - > -/* > - * balloon_page_insert - insert a page into the balloon's page list and make > - * the page->private assignment accordingly. > - * @balloon : pointer to balloon device > - * @page : page to be assigned as a 'balloon page' > - * > - * Caller must ensure the balloon_pages_lock is held. > - */ > -static inline void balloon_page_insert(struct balloon_dev_info *balloon, > - struct page *page) > -{ > - __SetPageOffline(page); > - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) { > - SetPageMovableOps(page); > - set_page_private(page, (unsigned long)balloon); > - } > - list_add(&page->lru, &balloon->pages); > -} > - > -/* > - * balloon_page_finalize - prepare a balloon page that was removed from the > - * balloon list for release to the page allocator > - * @page: page to be released to the page allocator > - * > - * Caller must ensure the balloon_pages_lock is held. > - */ > -static inline void balloon_page_finalize(struct page *page) > -{ > - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) > - set_page_private(page, 0); > - /* PageOffline is sticky until the page is freed to the buddy. */ > -} > #endif /* _LINUX_BALLOON_COMPACTION_H */ > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 1843e168db3ca..e0a4b481c3eda 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -17,6 +17,44 @@ > */ > static DEFINE_SPINLOCK(balloon_pages_lock); > > +static struct balloon_dev_info *balloon_page_device(struct page *page) > +{ > + return (struct balloon_dev_info *)page_private(page); > +} > + > +/* > + * balloon_page_insert - insert a page into the balloon's page list and make > + * the page->private assignment accordingly. > + * @balloon : pointer to balloon device > + * @page : page to be assigned as a 'balloon page' > + * > + * Caller must ensure the balloon_pages_lock is held. > + */ > +static void balloon_page_insert(struct balloon_dev_info *balloon, > + struct page *page) > +{ > + __SetPageOffline(page); > + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) { > + SetPageMovableOps(page); > + set_page_private(page, (unsigned long)balloon); > + } > + list_add(&page->lru, &balloon->pages); > +} > + > +/* > + * balloon_page_finalize - prepare a balloon page that was removed from the > + * balloon list for release to the page allocator > + * @page: page to be released to the page allocator > + * > + * Caller must ensure the balloon_pages_lock is held. > + */ > +static void balloon_page_finalize(struct page *page) > +{ > + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) > + set_page_private(page, 0); > + /* PageOffline is sticky until the page is freed to the buddy. */ > +} > + > static void balloon_page_enqueue_one(struct balloon_dev_info *b_dev_info, > struct page *page) > { The following on top to silence [1]. Results in two contextual conflicts in later patches which is easy to resolve. As an alternative, we could throw in a __maybe_unused but this is cleaner. [1] https://lkml.kernel.org/r/202601201338.4muFmFHV-lkp@intel.com From a02a0de0670a6be9a34d06eea3ba41297ce547dc Mon Sep 17 00:00:00 2001 From: "David Hildenbrand (Red Hat)" Date: Tue, 20 Jan 2026 07:37:39 +0100 Subject: [PATCH] fixup: mm/balloon_compaction: move internal helpers to balloon_compaction.c Move balloon_page_device() under CONFIG_BALLOON_COMPACTION. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202601201338.4muFmFHV-lkp@intel.com/ Signed-off-by: David Hildenbrand (Red Hat) --- mm/balloon_compaction.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index e0a4b481c3eda..30fa7ee8e1f3a 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -17,11 +17,6 @@ */ static DEFINE_SPINLOCK(balloon_pages_lock); -static struct balloon_dev_info *balloon_page_device(struct page *page) -{ - return (struct balloon_dev_info *)page_private(page); -} - /* * balloon_page_insert - insert a page into the balloon's page list and make * the page->private assignment accordingly. @@ -232,6 +227,10 @@ struct page *balloon_page_dequeue(struct balloon_dev_info *b_dev_info) EXPORT_SYMBOL_GPL(balloon_page_dequeue); #ifdef CONFIG_BALLOON_COMPACTION +static struct balloon_dev_info *balloon_page_device(struct page *page) +{ + return (struct balloon_dev_info *)page_private(page); +} static bool balloon_page_isolate(struct page *page, isolate_mode_t mode) -- 2.52.0 -- Cheers David