From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DE9CE77188 for ; Thu, 2 Jan 2025 05:41:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YNwZ86tMgz2xst; Thu, 2 Jan 2025 16:41:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1735796512; cv=none; b=ObYj/XglC4o/0r56Ubu6pTAZ+BnYcHrafjvTQ7+Rz3BwwByTTv6BM1kgrmN7vC7p2pEX82/ifgUMs9KFZdSgR1udcG6FEi9aB4BQEgGzJefROM1laJ+UxQdhCUpBoc/1WA+w7YwBnPwW1vXCu0Uw9RQHToxBVthBazC48hTFI6Nf1s6M732FAYujXahgyIsH7NHeIxPQo5RFPcJhhkIEeT1Le1/p6uYDOuG1FIe1jJRCM7ufIKyHIHa07OiiyICnhJ4GjQ2T1o5MdFrcw5FfDthbz26ID5wFZcVdEot5BHvIzILKjJ0EN7oWSq0EyeDxT7Mu/8eN/kRBBbMB3fexkA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1735796512; c=relaxed/relaxed; bh=SDxj6ZRZpsE3FyDvmD4550kV1XKhjwzGx5jUxyVhJ3w=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Vm83OD1wQoMG0vKcf9C0PhfP/qSWuGeAulkGr5cGhgqrjGKvywC2L5N0fjiBUtjJwejvan3LGtAYY4K9U1c3D0YCsQ74eHrYI5g3Za/whiNegU9k50WgUtT5U4+TfzZbb0KUql7TOl3/fuY6tgqP5Cp+cZeyvw75Ra+PC7wN5wt1QMbd5XxIkxkX+Rx8mxT4IHdEV5MOXGxceMxvjTc/RETv6TXhskFiZRZzo65GXwOzR/3kU7LrcV/PwcTJmXwGyOriWxYQkKZtRSLeTeaX/6y1tBOrMLat29ldIcS/QobZcNU3XaePdZVwwPBn5CN39Kx3ZNqLvQps0R58qbMokw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Pi3gg13b; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=adityag@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Pi3gg13b; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=adityag@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YNwZ75Fcnz2xGr for ; Thu, 2 Jan 2025 16:41:51 +1100 (AEDT) Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 501JtB2I011586; Thu, 2 Jan 2025 05:41:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=SDxj6Z RZpsE3FyDvmD4550kV1XKhjwzGx5jUxyVhJ3w=; b=Pi3gg13b/fQT1cuLh5tmSt 5BFxL3I9aByc1kVxo1Z7bUXZQHF5bgGun+ObJGcNNkj1pEtpTf5PngfUGMd1YLkk yyMFFu60LIUxHgmOZVg4ocbRJkqVFXQH09TN6as4HlnXuJANis/1763QrVdj9n92 oYpsehqxtIimLHo9hC0NHIVImpcjdZ1HSwlbu/AsPxL1XBByXD2BHr+rhj12ooaE s1zysMO2Y1xpQF08+RKXQtM0ywUDhEhxLgFIUBBiKH4LRDFAvE5Wv6loUH3b6gAm Tspkp5NVdH7gJzAZFltL/lqUvw+QNyURHgWErLniGKNczA5yWuffmrfFTCgZk8kw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43w7649xsv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jan 2025 05:41:23 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5025Zc76016587; Thu, 2 Jan 2025 05:41:22 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43w7649xst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jan 2025 05:41:22 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50252Pvo004355; Thu, 2 Jan 2025 05:41:21 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43twvk0p5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jan 2025 05:41:21 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5025fHT556230172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Jan 2025 05:41:18 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6DA92004B; Thu, 2 Jan 2025 05:41:17 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8664320040; Thu, 2 Jan 2025 05:41:13 +0000 (GMT) Received: from [9.109.199.160] (unknown [9.109.199.160]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 2 Jan 2025 05:41:13 +0000 (GMT) Message-ID: <283dd9ba-99ab-43d9-904a-efca1358cf06@linux.ibm.com> Date: Thu, 2 Jan 2025 11:11:10 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read() From: Aditya Gupta To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, bpf@vger.kernel.org References: <20241228-sysfs-const-bin_attr-simple-v2-0-7c6f3f1767a3@weissschuh.net> <20241228-sysfs-const-bin_attr-simple-v2-1-7c6f3f1767a3@weissschuh.net> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: WtZIlJs1cezSxKdP-nJ8mwr-9fgi25s4 X-Proofpoint-ORIG-GUID: F5lb7f80hhitWxlXGZmJA_DhfqwgJMfO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 clxscore=1011 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501020046 Hi, Please use this Tested-by instead of the previous one i sent: Tested-by: Aditya Gupta Thanks, - Aditya G On 02/01/25 11:07, Aditya Gupta wrote: > Looks good to me. Did boot test and reading the /sys files works. > > Linux-ci tests [0] are also good (the failing tests are broken from > some time, ignoring them): > > [0]: https://github.com/adi-g15-ibm/linux-ci/actions?query=branch%3Atmp-test-branch-10962+branch%3Atmp-test-branch-26310+branch%3Atmp-test-branch-23431++ > > Tested-by: Aditya Gupta > > Thanks, > - Aditya G > > On 24/12/28 09:43AM, Thomas Weißschuh wrote: >> Most users use this function through the BIN_ATTR_SIMPLE* macros, >> they can handle the switch transparently. >> Also adapt the two non-macro users in the same change. >> >> Signed-off-by: Thomas Weißschuh >> --- >> arch/powerpc/platforms/powernv/opal.c | 2 +- >> fs/sysfs/file.c | 2 +- >> include/linux/sysfs.h | 4 ++-- >> kernel/module/sysfs.c | 2 +- >> 4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c >> index 5d0f35bb917ebced8c741cd3af2c511949a1d2ef..013637e2b2a8e6a4ec6b93a520f8d5d9d3245467 100644 >> --- a/arch/powerpc/platforms/powernv/opal.c >> +++ b/arch/powerpc/platforms/powernv/opal.c >> @@ -818,7 +818,7 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name, >> sysfs_bin_attr_init(attr); >> attr->attr.name = name; >> attr->attr.mode = 0400; >> - attr->read = sysfs_bin_attr_simple_read; >> + attr->read_new = sysfs_bin_attr_simple_read; >> attr->private = __va(vals[0]); >> attr->size = vals[1]; >> >> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c >> index 785408861c01c89fc84c787848243a13c1338367..6931308876c4ac3b4c19878d5e1158ad8fe4f16f 100644 >> --- a/fs/sysfs/file.c >> +++ b/fs/sysfs/file.c >> @@ -817,7 +817,7 @@ EXPORT_SYMBOL_GPL(sysfs_emit_at); >> * Returns number of bytes written to @buf. >> */ >> ssize_t sysfs_bin_attr_simple_read(struct file *file, struct kobject *kobj, >> - struct bin_attribute *attr, char *buf, >> + const struct bin_attribute *attr, char *buf, >> loff_t off, size_t count) >> { >> memcpy(buf, attr->private + off, count); >> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h >> index 0f2fcd244523f050c5286f19d4fe1846506f9214..2205561159afdb57d0a250bb0439b28c01d9010e 100644 >> --- a/include/linux/sysfs.h >> +++ b/include/linux/sysfs.h >> @@ -511,7 +511,7 @@ __printf(3, 4) >> int sysfs_emit_at(char *buf, int at, const char *fmt, ...); >> >> ssize_t sysfs_bin_attr_simple_read(struct file *file, struct kobject *kobj, >> - struct bin_attribute *attr, char *buf, >> + const struct bin_attribute *attr, char *buf, >> loff_t off, size_t count); >> >> #else /* CONFIG_SYSFS */ >> @@ -774,7 +774,7 @@ static inline int sysfs_emit_at(char *buf, int at, const char *fmt, ...) >> >> static inline ssize_t sysfs_bin_attr_simple_read(struct file *file, >> struct kobject *kobj, >> - struct bin_attribute *attr, >> + const struct bin_attribute *attr, >> char *buf, loff_t off, >> size_t count) >> { >> diff --git a/kernel/module/sysfs.c b/kernel/module/sysfs.c >> index 456358e1fdc43e6b5b24f383bbefa37812971174..254017b58b645d4afcf6876d29bcc2e2113a8dc4 100644 >> --- a/kernel/module/sysfs.c >> +++ b/kernel/module/sysfs.c >> @@ -196,7 +196,7 @@ static int add_notes_attrs(struct module *mod, const struct load_info *info) >> nattr->attr.mode = 0444; >> nattr->size = info->sechdrs[i].sh_size; >> nattr->private = (void *)info->sechdrs[i].sh_addr; >> - nattr->read = sysfs_bin_attr_simple_read; >> + nattr->read_new = sysfs_bin_attr_simple_read; >> ++nattr; >> } >> ++loaded; >> >> -- >> 2.47.1 >>