From: Kumar Gala <galak@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: Build breakage for CONFIG_PM but no CONFIG_SUSPEND
Date: Fri, 6 Feb 2009 10:26:46 -0600 [thread overview]
Message-ID: <287EB610-4821-4F0A-A3EF-7DCA146D2F73@kernel.crashing.org> (raw)
In-Reply-To: <20090206160452.GB1641@ld0162-tx32.am.freescale.net>
On Feb 6, 2009, at 10:04 AM, Scott Wood wrote:
> On Fri, Feb 06, 2009 at 11:10:27AM +1100, Michael Neuling wrote:
>> I noticed this doing some randconfig testing (.config below). I have
>> CONFIG_PM but no CONFIG_SUSPEND. Bug is against mainline.
>>
>> arch/powerpc/sysdev/built-in.o: In function `ipic_suspend':
>> ipic.c:(.text+0x6b34): undefined reference to `fsl_deep_sleep'
>> make[1]: *** [.tmp_vmlinux1] Error 1
>> make: *** [sub-make] Error 2
>>
>> Looks like #ifdef CONFIG_PM in arch/powerpc/sysdev/ipic.c should be
>> CONFIG_SUSPEND. d49747bdfb2ddebea24d1580da55b79d093d48a9 introduced
>> this.
>>
>> Maybe this fixes it?
>>
>>
>> Fix build when we have CONFIG_PM but no CONFIG_SUSPEND.
>
> ACK. That was a leftover from before CONFIG_SUSPEND was introduced.
If you send a proper patch I'll apply it and queue it up with some
other fixes.
- k
next prev parent reply other threads:[~2009-02-06 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 0:10 Build breakage for CONFIG_PM but no CONFIG_SUSPEND Michael Neuling
2009-02-06 16:04 ` Scott Wood
2009-02-06 16:26 ` Kumar Gala [this message]
2009-02-06 16:37 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=287EB610-4821-4F0A-A3EF-7DCA146D2F73@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).