From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
"Venkata Prasad Potturu" <venkataprasad.potturu@amd.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Shengjiu Wang" <shengjiu.wang@gmail.com>,
"Xiubo Li" <Xiubo.Lee@gmail.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Nicolin Chen" <nicoleotsuka@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH v1 4/4] ASOC: Unify code style for platform_device_id arrays
Date: Thu, 28 May 2026 11:27:57 +0200 [thread overview]
Message-ID: <28c0e1ae-e2a4-43e8-8be9-c05f8cbeecdb@intel.com> (raw)
In-Reply-To: <d131f7afc3c61ca8ac82a848aaa6ecfbb57ec63b.1779958164.git.u.kleine-koenig@baylibre.com>
On 5/28/2026 11:06 AM, Uwe Kleine-König (The Capable Hub) wrote:
> - Add a trailing comma for initializers unless the closing brace is on
> the same line and for the list terminator;
> - Use a single space in the list terminator;
> - Use compact one-line style for small entries;
> - s/\t=/ =/ were the tab is only one char wide anyhow;
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> sound/soc/amd/acp/acp-sof-mach.c | 14 +++++++-------
> sound/soc/codecs/adau7118-hw.c | 2 +-
> sound/soc/codecs/bt-sco.c | 10 +++-------
> sound/soc/codecs/wcd934x.c | 6 ++----
> sound/soc/fsl/imx-pcm-rpmsg.c | 6 +++---
...
> sound/soc/intel/avs/boards/da7219.c | 6 ++----
> sound/soc/intel/avs/boards/dmic.c | 6 ++----
> sound/soc/intel/avs/boards/es8336.c | 6 ++----
> sound/soc/intel/avs/boards/hdaudio.c | 6 ++----
> sound/soc/intel/avs/boards/i2s_test.c | 6 ++----
> sound/soc/intel/avs/boards/max98357a.c | 6 ++----
> sound/soc/intel/avs/boards/max98373.c | 6 ++----
> sound/soc/intel/avs/boards/max98927.c | 6 ++----
> sound/soc/intel/avs/boards/nau8825.c | 6 ++----
> sound/soc/intel/avs/boards/pcm3168a.c | 6 ++----
Please separate all the avs-driver changes into a separate patch with
the following prefix for the title: "ASoC: Intel: avs:".
The code itself looks good. Provided the separation is done, feel free
to add my tag:
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
prev parent reply other threads:[~2026-05-28 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:05 [PATCH v1 0/4] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-28 9:06 ` [PATCH v1 4/4] ASOC: Unify code style " Uwe Kleine-König (The Capable Hub)
2026-05-28 9:27 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c0e1ae-e2a4-43e8-8be9-c05f8cbeecdb@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Frank.Li@nxp.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Xiubo.Lee@gmail.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=festevam@gmail.com \
--cc=gpiccoli@igalia.com \
--cc=imx@lists.linux.dev \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mario.limonciello@amd.com \
--cc=nicoleotsuka@gmail.com \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=shengjiu.wang@gmail.com \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox